Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: <intel-gfx@lists.freedesktop.org>, <intel-xe@lists.freedesktop.org>
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 2/2] drm/i915/dp_mst: Fix ww mutex lock failure in for_each_joiner_candidate() loop
Date: Wed, 18 Feb 2026 12:57:08 +0200	[thread overview]
Message-ID: <20260218105708.845161-2-imre.deak@intel.com> (raw)
In-Reply-To: <20260218105708.845161-1-imre.deak@intel.com>

Handle modeset WW mutex lock failures due to contention properly.
Return -EDEADLK to the caller instead of attempting to lock the same
mutex again in a subsequent joiner candidate iteration, where the WW
mutex is already in a contended state.

This fixes the following warning:

WARNING: drivers/gpu/drm/drm_modeset_lock.c:298 at modeset_lock+0x1c0/0x210

triggered by ctx->contended.

Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Fixes: b506a8e18c972 ("drm/i915/dp_mst: Rework pipe joiner logic in compute_config")
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index f833f47643271..94c0231426642 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -729,7 +729,7 @@ static int mst_stream_compute_config(struct intel_encoder *encoder,
 							       pipe_config,
 							       conn_state,
 							       num_joined_pipes);
-		if (ret == 0)
+		if (ret == 0 || ret == -EDEADLK)
 			break;
 	}
 
-- 
2.49.1


  reply	other threads:[~2026-02-18 10:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18 10:57 [PATCH 1/2] drm/i915/dp: Fix ww mutex lock failure in for_each_joiner_candidate() loop Imre Deak
2026-02-18 10:57 ` Imre Deak [this message]
2026-02-18 11:51   ` [PATCH 2/2] drm/i915/dp_mst: " Nautiyal, Ankit K
2026-02-18 11:50 ` [PATCH 1/2] drm/i915/dp: " Nautiyal, Ankit K
2026-02-18 14:40 ` ✓ CI.KUnit: success for series starting with [1/2] " Patchwork
2026-02-18 14:56 ` ✗ CI.checksparse: warning " Patchwork
2026-02-18 15:32 ` ✓ Xe.CI.BAT: success " Patchwork
2026-02-18 16:51 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260218105708.845161-2-imre.deak@intel.com \
    --to=imre.deak@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox