Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 10/19] drm/i915/overlay: Extract i915_overlay_cleanup()
Date: Wed, 18 Feb 2026 17:27:57 +0200	[thread overview]
Message-ID: <20260218152806.18885-11-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20260218152806.18885-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Pull the i915 specific bits of the overlay cleanup into
a separate function (i915_overlay_cleanup()) to accommodate
the upcoming parent vs. display driver split.

For now we'll also have to pass in the overlay struct, but
that will disappear once the i915 vs. display split is completed.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_overlay.c | 22 +++++++++++++-------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c
index 5683bddf33b4..9b5ae3f4f5bd 100644
--- a/drivers/gpu/drm/i915/display/intel_overlay.c
+++ b/drivers/gpu/drm/i915/display/intel_overlay.c
@@ -1490,23 +1490,29 @@ bool intel_overlay_available(struct intel_display *display)
 	return display->overlay;
 }
 
-void intel_overlay_cleanup(struct intel_display *display)
+static void i915_overlay_cleanup(struct drm_device *drm,
+				 struct intel_overlay *overlay)
 {
-	struct intel_overlay *overlay;
-
-	overlay = fetch_and_zero(&display->overlay);
-	if (!overlay)
-		return;
-
 	/*
 	 * The bo's should be free'd by the generic code already.
 	 * Furthermore modesetting teardown happens beforehand so the
 	 * hardware should be off already.
 	 */
-	drm_WARN_ON(display->drm, i915_overlay_is_active(display->drm));
+	drm_WARN_ON(drm, i915_overlay_is_active(drm));
 
 	i915_gem_object_put(overlay->reg_bo);
 	i915_active_fini(&overlay->last_flip);
+}
+
+void intel_overlay_cleanup(struct intel_display *display)
+{
+	struct intel_overlay *overlay;
+
+	overlay = fetch_and_zero(&display->overlay);
+	if (!overlay)
+		return;
+
+	i915_overlay_cleanup(display->drm, overlay);
 
 	kfree(overlay);
 }
-- 
2.52.0


  parent reply	other threads:[~2026-02-18 15:28 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18 15:27 [PATCH 00/19] drm/i915/overlay: Convert to parent interface Ville Syrjala
2026-02-18 15:27 ` [PATCH 01/19] drm/i915/overlay: Remove GPU hang snapshot stuff Ville Syrjala
2026-02-18 15:27 ` [PATCH 02/19] drm/i915/overlay: Track current frontbuffer_bits Ville Syrjala
2026-02-25 10:38   ` Jani Nikula
2026-02-18 15:27 ` [PATCH 03/19] drm/i915/overlay: Extract i915_overlay_is_active() Ville Syrjala
2026-02-18 15:27 ` [PATCH 04/19] drm/i915/overlay: Remove redundant overlay->active Ville Syrjala
2026-02-18 15:27 ` [PATCH 05/19] drm/i915/overlay: Relocate the underrun check Ville Syrjala
2026-02-18 15:27 ` [PATCH 06/19] drm/i915/overlay: Introduce i915_overlay_obj_lookup() Ville Syrjala
2026-02-25  9:40   ` Jani Nikula
2026-02-25 10:06     ` Ville Syrjälä
2026-02-18 15:27 ` [PATCH 07/19] drm/i915/overlay: Use struct drm_gem_object as the type Ville Syrjala
2026-02-18 15:27 ` [PATCH 08/19] drm/i915/overlay: Extract i915_overlay_reset() Ville Syrjala
2026-02-18 15:27 ` [PATCH 09/19] drm/i915/overlay: Extract i915_overlay_setup() Ville Syrjala
2026-02-18 15:27 ` Ville Syrjala [this message]
2026-02-18 15:27 ` [PATCH 11/19] drm/i915/overlay: Abstract buffer (un)pinning Ville Syrjala
2026-02-18 15:27 ` [PATCH 12/19] drm/i915/overlay: Rename low level i915 specific functions Ville Syrjala
2026-02-18 15:28 ` [PATCH 13/19] drm/i915/overlay: Adjust i915 specific interfaces Ville Syrjala
2026-02-18 15:28 ` [PATCH 14/19] drm/i915/overlay: Make i830_overlay_clock_gating() i915 specific Ville Syrjala
2026-02-18 15:28 ` [PATCH 15/19] drm/i915/overlay: s/dev_priv/i915/ Ville Syrjala
2026-02-18 15:28 ` [PATCH 16/19] drm/i915/overlay: Split 'struct intel_overlay' Ville Syrjala
2026-02-18 15:28 ` [PATCH 17/19] drm/i915/overlay: Don't use fetch_and_zero() in display code Ville Syrjala
2026-02-25  9:47   ` Jani Nikula
2026-02-25 10:00     ` Ville Syrjälä
2026-02-18 15:28 ` [PATCH 18/19] drm/i915/overlay: Move i915 specific code into i915_overlay.c Ville Syrjala
2026-02-18 15:28 ` [PATCH 19/19] drm/i915/overlay: Convert overlay to parent interface Ville Syrjala
2026-02-18 18:09 ` ✗ CI.checkpatch: warning for drm/i915/overlay: Convert " Patchwork
2026-02-18 18:11 ` ✓ CI.KUnit: success " Patchwork
2026-02-18 18:26 ` ✗ CI.checksparse: warning " Patchwork
2026-02-18 19:12 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-02-18 21:42 ` ✗ Xe.CI.FULL: " Patchwork
2026-02-25 11:19 ` [PATCH 00/19] " Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260218152806.18885-11-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox