Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: <intel-gfx@lists.freedesktop.org>, <intel-xe@lists.freedesktop.org>
Subject: [PATCH 1/5] drm/i915/dp_tunnel: Don't update tunnel state during system resume
Date: Thu, 19 Feb 2026 20:28:19 +0200	[thread overview]
Message-ID: <20260219182823.926702-2-imre.deak@intel.com> (raw)
In-Reply-To: <20260219182823.926702-1-imre.deak@intel.com>

During system resume, restoring the pre-suspend display state must not
fail. This requires preserving the sink capabilities from before
suspend, including the available link bandwidth.

If these capabilities are not preserved, the restore modeset may fail,
either due to a missing sink capability or insufficient link bandwidth
for the restored mode.

When the sink is connected through a DP tunnel, prevent such capability
changes by skipping tunnel state updates during resume. This also avoids
updating the sink state via the tunnel while it is being resumed.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_tunnel.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_tunnel.c b/drivers/gpu/drm/i915/display/intel_dp_tunnel.c
index faa2b7a46699d..eb1eed1c8c7bb 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_tunnel.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_tunnel.c
@@ -150,11 +150,9 @@ static int allocate_initial_tunnel_bw_for_pipes(struct intel_dp *intel_dp, u8 pi
 			    drm_dp_tunnel_name(intel_dp->tunnel),
 			    encoder->base.base.id, encoder->base.name,
 			    ERR_PTR(err));
-
-		return err;
 	}
 
-	return update_tunnel_state(intel_dp);
+	return err;
 }
 
 static int allocate_initial_tunnel_bw(struct intel_dp *intel_dp,
@@ -200,10 +198,13 @@ static int detect_new_tunnel(struct intel_dp *intel_dp, struct drm_modeset_acqui
 	}
 
 	ret = allocate_initial_tunnel_bw(intel_dp, ctx);
-	if (ret < 0)
+	if (ret < 0) {
 		intel_dp_tunnel_destroy(intel_dp);
 
-	return ret;
+		return ret;
+	}
+
+	return update_tunnel_state(intel_dp);
 }
 
 /**
-- 
2.49.1


  reply	other threads:[~2026-02-19 18:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-19 18:28 [PATCH 0/5] drm/i915/dp_tunnel: Preparation for UHBR DP tunnels Imre Deak
2026-02-19 18:28 ` Imre Deak [this message]
2026-02-23 15:54   ` [PATCH 1/5] drm/i915/dp_tunnel: Don't update tunnel state during system resume Murthy, Arun R
2026-02-23 16:30     ` Imre Deak
2026-02-24  2:33       ` Murthy, Arun R
2026-02-24  7:49         ` Imre Deak
2026-02-24 12:55           ` Murthy, Arun R
2026-02-19 18:28 ` [PATCH 2/5] drm/i915/dp_tunnel: Simplify detection of link BW change Imre Deak
2026-02-23 16:02   ` Murthy, Arun R
2026-02-23 16:35     ` Imre Deak
2026-02-24 12:56       ` Murthy, Arun R
2026-02-19 18:28 ` [PATCH 3/5] drm/i915/dp_tunnel: Split update_tunnel_state() Imre Deak
2026-02-24 12:57   ` Murthy, Arun R
2026-02-19 18:28 ` [PATCH 4/5] drm/i915/dp_tunnel: Sanitize documentation of intel_dp_tunnel_detect() Imre Deak
2026-02-23 16:12   ` Murthy, Arun R
2026-02-23 16:45     ` Imre Deak
2026-02-24  2:36       ` Murthy, Arun R
2026-02-24  7:55         ` Imre Deak
2026-02-24 12:55           ` Murthy, Arun R
2026-02-19 18:28 ` [PATCH 5/5] drm/i915/dp_tunnel: Send BW change notification after tunnel creation Imre Deak
2026-02-24 12:58   ` Murthy, Arun R
2026-02-19 19:28 ` ✓ CI.KUnit: success for drm/i915/dp_tunnel: Preparation for UHBR DP tunnels Patchwork
2026-02-20  8:42 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-20 13:42 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260219182823.926702-2-imre.deak@intel.com \
    --to=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox