From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B794C53216 for ; Fri, 20 Feb 2026 05:02:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1109210E78B; Fri, 20 Feb 2026 05:02:36 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Q8KUNGyZ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0019C10E787; Fri, 20 Feb 2026 05:02:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771563755; x=1803099755; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=SUOcYwSW0KCjXqCWZh27GlIHPiCGy5Pt3HccXYs99ac=; b=Q8KUNGyZoimeUVnmoxEkxeBJfqJAXcHR/ZymfKD/+DbAxZRN2/tY5b7+ ttk+LkPLVrkNsh8SitYiAtDWD6weWwRaGqYAB9n6qxN2frEPEhXYQhBvn GxUn2cdMFD3q8uVfEOjykOqHYo+IpLfYAcCiNawQtp3qOYFInbK+Tt2v7 xHsoeXvfAF2C1ykC5DLcBjKVUj0p3ClV7pq7kmVb4qwhuxmaJoUR2pdSJ 2ZkQITaIgywTLI/C5dwfIizBy6l2jWbPqjrFGHnTH7CD6RzAtL2YfvGrZ 46aPhPlvVz3nEi25uflpHmUOGILkNYi2yeqi2hYs5VHqLWFsPD9zHTBhS w==; X-CSE-ConnectionGUID: ZWiwQyDtQDm7Od/oxe9oqQ== X-CSE-MsgGUID: /nOp+HHuSkK99KsoRy9jFQ== X-IronPort-AV: E=McAfee;i="6800,10657,11706"; a="72758236" X-IronPort-AV: E=Sophos;i="6.21,301,1763452800"; d="scan'208";a="72758236" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2026 21:02:35 -0800 X-CSE-ConnectionGUID: 0F1ZLhvmQIShcULRJBICQg== X-CSE-MsgGUID: IA2GysybTlGMD/oErT240w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,301,1763452800"; d="scan'208";a="218894650" Received: from kandpal-x299-ud4-pro.iind.intel.com ([10.190.239.10]) by orviesa003.jf.intel.com with ESMTP; 19 Feb 2026 21:02:33 -0800 From: Suraj Kandpal To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: ankit.k.nautiyal@intel.com, arun.r.murthy@intel.com, Suraj Kandpal Subject: [PATCH 5/8] drm/i915/backlight: Short circuit intel_dp_aux_supports_hdr_backlight Date: Fri, 20 Feb 2026 10:32:14 +0530 Message-Id: <20260220050217.2453681-6-suraj.kandpal@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260220050217.2453681-1-suraj.kandpal@intel.com> References: <20260220050217.2453681-1-suraj.kandpal@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" intel_dp_aux_supports_hdr_backlight() prints debug message for intel HDR backlight version. This is fine when dealing with eDP 1.4b and lower. When we are talking about eDP 1.5 it causes confusion in logs since we need to use VESA AUX backlight functions but this print causes confusion as to which path code take. Short circuit this function with a eDP version check. Make sure this is only called if eDP <= 1.4b Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c index a921bb4ccacf..c7143869bafd 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c @@ -701,8 +701,8 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *connector) * backlight interface at all. This means that the only sensible way for us to detect both * interfaces is to probe for Intel's first, and VESA's second. */ - if (try_intel_interface && intel_dp_aux_supports_hdr_backlight(connector) && - intel_dp->edp_dpcd[0] <= DP_EDP_14b) { + if (try_intel_interface && intel_dp->edp_dpcd[0] <= DP_EDP_14b && + intel_dp_aux_supports_hdr_backlight(connector)) { drm_dbg_kms(dev, "[CONNECTOR:%d:%s] Using Intel proprietary eDP backlight controls\n", connector->base.base.id, connector->base.name); panel->backlight.funcs = &intel_dp_hdr_bl_funcs; -- 2.34.1