From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAEBEC53216 for ; Fri, 20 Feb 2026 05:02:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 85DF910E78E; Fri, 20 Feb 2026 05:02:39 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="E5ut8wQi"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id ABA9710E780; Fri, 20 Feb 2026 05:02:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771563759; x=1803099759; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6j+8P+tpuL9EhwQDTZ2xJfAEHGjXO90NNAQwEonuUzM=; b=E5ut8wQiPHgEgHRb9K2Tp73FmlLG63mPu8SXIDY0GNrL+c/Ia+wQQ9PR j9dk9wxCnk/+pcU1rWnEFVANkmuj5g9C5uLJwBvRJO5Rcyma+5r2mxgKB nQ4k0NTy3nBl56C7o70oQC0CjDKzbuXRhorS2msrVGFfDgak/ftQ5gAVX MedGlnVsUWt3Xqp2FXQqjThei9VD8+QnHEzjj8TST9cwZuZq38XRhhTxe c++1pIXOmSbRZSmrblsQ+PXQB7nIeo2ov3/iyGyBcvSfW3CCatI6dZY7f UdISFntBipcCd8zIV5X6cGwzrfqlrYRstxui/GPjzttms9Ex9KKZqaYqf A==; X-CSE-ConnectionGUID: alKm2BmRTuqsohf0XYRoWg== X-CSE-MsgGUID: jOJrU7QxQNiOd6ijh91y5w== X-IronPort-AV: E=McAfee;i="6800,10657,11706"; a="72758238" X-IronPort-AV: E=Sophos;i="6.21,301,1763452800"; d="scan'208";a="72758238" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2026 21:02:39 -0800 X-CSE-ConnectionGUID: vGY40pU5RiKxnSVHXLWuQw== X-CSE-MsgGUID: CpF4cirtRP+NBjNrPmVzrQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,301,1763452800"; d="scan'208";a="218894657" Received: from kandpal-x299-ud4-pro.iind.intel.com ([10.190.239.10]) by orviesa003.jf.intel.com with ESMTP; 19 Feb 2026 21:02:37 -0800 From: Suraj Kandpal To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: ankit.k.nautiyal@intel.com, arun.r.murthy@intel.com, Suraj Kandpal Subject: [PATCH 7/8] drm/i915/backlight: Provide clear description on how backlight level is controlled Date: Fri, 20 Feb 2026 10:32:16 +0530 Message-Id: <20260220050217.2453681-8-suraj.kandpal@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260220050217.2453681-1-suraj.kandpal@intel.com> References: <20260220050217.2453681-1-suraj.kandpal@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Currently it takes us multiple log prints to arrive at the conclusion on how we are actually controlling backlight level. Make the logging concise. Signed-off-by: Suraj Kandpal --- .../drm/i915/display/intel_dp_aux_backlight.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c index 043c9aef2ea6..aac6cdb5b69b 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c @@ -368,6 +368,16 @@ static const char *dpcd_vs_pwm_str(bool aux) return aux ? "DPCD" : "PWM"; } +static const char *backlight_unit_str(struct intel_panel *panel) +{ + if (panel->backlight.edp.vesa.info.luminance_set) + return "NITS"; + else if (panel->backlight.edp.vesa.info.aux_set) + return "Brightness %"; + else + return "PWM"; +} + static void intel_dp_aux_write_panel_luminance_override(struct intel_connector *connector) { @@ -542,9 +552,11 @@ static int intel_dp_aux_vesa_setup_backlight(struct intel_connector *connector, dpcd_vs_pwm_str(panel->backlight.edp.vesa.info.aux_enable || panel->backlight.edp.vesa.info.luminance_set)); drm_dbg_kms(display->drm, - "[CONNECTOR:%d:%s] AUX VESA backlight level is controlled through %s\n", + "[CONNECTOR:%d:%s] AUX VESA backlight level is controlled through %s using %s values\n", connector->base.base.id, connector->base.name, - dpcd_vs_pwm_str(panel->backlight.edp.vesa.info.aux_set)); + dpcd_vs_pwm_str(panel->backlight.edp.vesa.info.aux_set || + panel->backlight.edp.vesa.info.luminance_set), + backlight_unit_str(panel)); if (!panel->backlight.edp.vesa.info.aux_set || !panel->backlight.edp.vesa.info.aux_enable) { @@ -569,9 +581,6 @@ static int intel_dp_aux_vesa_setup_backlight(struct intel_connector *connector, panel->backlight.enabled = panel->backlight.level != 0; if (!panel->backlight.level) panel->backlight.level = panel->backlight.max; - drm_dbg_kms(display->drm, - "[CONNECTOR:%d:%s] AUX VESA Nits backlight level is controlled through DPCD\n", - connector->base.base.id, connector->base.name); } else if (panel->backlight.edp.vesa.info.aux_set) { panel->backlight.max = panel->backlight.edp.vesa.info.max; panel->backlight.min = 0; -- 2.34.1