Re: [PATCH v2 01/10] drm/xe/pf: Expose LMTT page size

["Piotr Piórkowski" <piotr.piorkowski@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on śro [2026-lut-18 21:55:43 +0100]:
> The underlying LMTT implementation already provides the info about
> the page size it is using.  There is no need to have a separate
> helper function that is making assumption about the required size.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Piotr Piórkowski <piotr.piorkowski@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c |  3 +--
>  drivers/gpu/drm/xe/xe_lmtt.c               | 17 +++++++++++++++++
>  drivers/gpu/drm/xe/xe_lmtt.h               |  1 +
>  3 files changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> index 888193e1d2c5..e06baf12e108 100644
> --- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> @@ -1451,8 +1451,7 @@ int xe_gt_sriov_pf_config_set_fair_dbs(struct xe_gt *gt, unsigned int vfid,
>  
>  static u64 pf_get_lmem_alignment(struct xe_gt *gt)
>  {
> -	/* this might be platform dependent */
> -	return SZ_2M;
> +	return xe_lmtt_page_size(&gt->tile->sriov.pf.lmtt);
>  }
>  
>  static u64 pf_get_min_spare_lmem(struct xe_gt *gt)
> diff --git a/drivers/gpu/drm/xe/xe_lmtt.c b/drivers/gpu/drm/xe/xe_lmtt.c
> index 2077e1ef8b43..b583e0f20183 100644
> --- a/drivers/gpu/drm/xe/xe_lmtt.c
> +++ b/drivers/gpu/drm/xe/xe_lmtt.c
> @@ -57,6 +57,23 @@ static u64 lmtt_page_size(struct xe_lmtt *lmtt)
>  	return BIT_ULL(lmtt->ops->lmtt_pte_shift(0));
>  }
>  
> +/**
> + * xe_lmtt_page_size() - Get LMTT page size.
> + * @lmtt: the &xe_lmtt
> + *
> + * This function shall be called only by PF.
> + *
> + * Return: LMTT page size.
> + */
> +u64 xe_lmtt_page_size(struct xe_lmtt *lmtt)
> +{
> +	lmtt_assert(lmtt, IS_SRIOV_PF(lmtt_to_xe(lmtt)));
> +	lmtt_assert(lmtt, xe_device_has_lmtt(lmtt_to_xe(lmtt)));
> +	lmtt_assert(lmtt, lmtt->ops);
> +
> +	return lmtt_page_size(lmtt);
> +}
> +
>  static struct xe_lmtt_pt *lmtt_pt_alloc(struct xe_lmtt *lmtt, unsigned int level)
>  {
>  	unsigned int num_entries = level ? lmtt->ops->lmtt_pte_num(level) : 0;
> diff --git a/drivers/gpu/drm/xe/xe_lmtt.h b/drivers/gpu/drm/xe/xe_lmtt.h
> index 75a234fbf367..8fa387b38c52 100644
> --- a/drivers/gpu/drm/xe/xe_lmtt.h
> +++ b/drivers/gpu/drm/xe/xe_lmtt.h
> @@ -20,6 +20,7 @@ int xe_lmtt_prepare_pages(struct xe_lmtt *lmtt, unsigned int vfid, u64 range);
>  int xe_lmtt_populate_pages(struct xe_lmtt *lmtt, unsigned int vfid, struct xe_bo *bo, u64 offset);
>  void xe_lmtt_drop_pages(struct xe_lmtt *lmtt, unsigned int vfid);
>  u64 xe_lmtt_estimate_pt_size(struct xe_lmtt *lmtt, u64 size);
> +u64 xe_lmtt_page_size(struct xe_lmtt *lmtt);
>  #else
>  static inline int xe_lmtt_init(struct xe_lmtt *lmtt) { return 0; }
>  static inline void xe_lmtt_init_hw(struct xe_lmtt *lmtt) { }
> -- 

LGTM:
Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com>

> 2.47.1
> 

--