Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: vinod.govindapillai@intel.com, ville.syrjala@intel.com,
	uma.shankar@intel.com
Subject: [PATCH v2 1/6] drm/xe/fbdev: Fix BIOS FB vs.s stolen size check
Date: Fri, 20 Feb 2026 19:09:03 +0200	[thread overview]
Message-ID: <20260220170908.201422-2-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20260220170908.201422-1-vinod.govindapillai@intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Looks like stolen->size is in bytes, not pages. Remove the
bogus PAGE_SHIFT stuff.

Also for some rnadom reason xe rejects the FB if it takes up
exactly half of stolen, whereas i915 allows it to be used
in that case. Adjust xe to follow the i915 rule for consistency.

v2: rebase related updates

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 drivers/gpu/drm/xe/display/xe_initial_plane.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/display/xe_initial_plane.c b/drivers/gpu/drm/xe/display/xe_initial_plane.c
index 4cfeafcc158d..38ecc201ac4e 100644
--- a/drivers/gpu/drm/xe/display/xe_initial_plane.c
+++ b/drivers/gpu/drm/xe/display/xe_initial_plane.c
@@ -99,7 +99,7 @@ initial_plane_bo(struct xe_device *xe,
 		 * features.
 		 */
 		if (IS_ENABLED(CONFIG_FRAMEBUFFER_CONSOLE) &&
-		    plane_config->size * 2 >> PAGE_SHIFT >= stolen->size)
+		    plane_config->size * 2 > stolen->size)
 			return NULL;
 	}
 
-- 
2.43.0


  reply	other threads:[~2026-02-20 17:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-20 17:09 [PATCH v2 0/6] update the stolen memory allocation preference Vinod Govindapillai
2026-02-20 17:09 ` Vinod Govindapillai [this message]
2026-02-24 18:21   ` [PATCH v2 1/6] drm/xe/fbdev: Fix BIOS FB vs.s stolen size check Shankar, Uma
2026-02-20 17:09 ` [PATCH v2 2/6] drm/i915/display: remove the usage of dev_priv Vinod Govindapillai
2026-02-24 13:17   ` Kahola, Mika
2026-02-20 17:09 ` [PATCH v2 3/6] drm/i915/fbdev: Extract intel_fbdev_fb_prefer_stolen() Vinod Govindapillai
2026-02-21 12:31   ` kernel test robot
2026-02-21 13:44   ` kernel test robot
2026-02-24 18:55   ` Shankar, Uma
2026-02-20 17:09 ` [PATCH v2 4/6] drm/xe/fbdev: " Vinod Govindapillai
2026-02-20 17:09 ` [PATCH v2 5/6] drm/xe/fbdev: print info about stolen memory preference for fbdev Vinod Govindapillai
2026-02-24 18:36   ` Shankar, Uma
2026-02-20 17:09 ` [PATCH v2 6/6] drm/i915/fbdev: " Vinod Govindapillai
2026-02-24 18:37   ` Shankar, Uma
2026-02-20 18:21 ` ✓ CI.KUnit: success for update the stolen memory allocation preference (rev2) Patchwork
2026-02-20 18:37 ` ✗ CI.checksparse: warning " Patchwork
2026-02-20 18:59 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-02-21  9:24 ` ✗ Xe.CI.FULL: " Patchwork
2026-02-25 11:12 ` [PATCH v2 0/6] update the stolen memory allocation preference Kahola, Mika

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260220170908.201422-2-vinod.govindapillai@intel.com \
    --to=vinod.govindapillai@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=uma.shankar@intel.com \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox