From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87DF9EA4FBE for ; Mon, 23 Feb 2026 13:29:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4440F10E306; Mon, 23 Feb 2026 13:29:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Co7hihAk"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id ABDF610E2EB; Mon, 23 Feb 2026 13:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771853399; x=1803389399; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3+7xUhc1W9JJ++JdbK1rsozQS+muhpPU/WqLzeX8uq0=; b=Co7hihAkkolNeB/cVBuygzacTuBe4SkpH2v8c1ERcIAXirUKiHwWkRqL yPcCMyeJ6veoRmCG0LOwg+RRsmnKNcWmmcpnCyKwRKigx5UbFfh5oChZ+ LXDb07vdcwjPj1vBGrJwhj44zhoxB9aGcl8I8t3JF+Iz+gArig3+ZqdJB qhdTz+af1PiMzIwjSkfPT7I3QmDOmAO67PS6luP6Ql2YcOgizBGVyeqzb sU4WFAUOYF/If0laIqZpetgNS+YtSNKEq1HdfCz+vQHiwIm5rR8rBi+9y +k9bSe6C8X/XwjwgSP2q0RhJfJMEDzDlZZIWodr/hM4Nxs1Lef8nCz+di g==; X-CSE-ConnectionGUID: KJYI3LihT5e4pobW+h88FA== X-CSE-MsgGUID: J/7VysVZRHu1wipn74NUeQ== X-IronPort-AV: E=McAfee;i="6800,10657,11709"; a="72724134" X-IronPort-AV: E=Sophos;i="6.21,306,1763452800"; d="scan'208";a="72724134" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 05:29:59 -0800 X-CSE-ConnectionGUID: jhjbT01gQ3OyBKwf/C3XGg== X-CSE-MsgGUID: LBq5Adj4QZqgwwGXD/2VNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,306,1763452800"; d="scan'208";a="215580176" Received: from srr4-3-linux-103-aknautiy.iind.intel.com ([10.223.34.160]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 05:29:56 -0800 From: Ankit Nautiyal To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: ville.syrjala@linux.intel.com, jouni.hogander@intel.com, animesh.manna@intel.com, Ankit Nautiyal , Mitul Golani Subject: [PATCH 01/14] drm/i915/dp: Fix readback for target_rr in Adaptive Sync SDP Date: Mon, 23 Feb 2026 18:44:13 +0530 Message-ID: <20260223131426.1638946-2-ankit.k.nautiyal@intel.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260223131426.1638946-1-ankit.k.nautiyal@intel.com> References: <20251111093007.3771409-3-ankit.k.nautiyal@intel.com> <20260223131426.1638946-1-ankit.k.nautiyal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Correct the bit-shift logic to properly readback the 10 bit target_rr from DB3 and DB4. v2: Align the style with readback for vtotal. (Ville) Fixes: 12ea89291603 ("drm/i915/dp: Add Read/Write support for Adaptive Sync SDP") Cc: Mitul Golani Cc: Ankit Nautiyal Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 025e906b63a9..b999d8c085c7 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -5187,7 +5187,7 @@ int intel_dp_as_sdp_unpack(struct drm_dp_as_sdp *as_sdp, as_sdp->length = sdp->sdp_header.HB3 & DP_ADAPTIVE_SYNC_SDP_LENGTH; as_sdp->mode = sdp->db[0] & DP_ADAPTIVE_SYNC_SDP_OPERATION_MODE; as_sdp->vtotal = (sdp->db[2] << 8) | sdp->db[1]; - as_sdp->target_rr = (u64)sdp->db[3] | ((u64)sdp->db[4] & 0x3); + as_sdp->target_rr = ((sdp->db[4] & 0x3) << 8) | sdp->db[3]; as_sdp->target_rr_divider = sdp->db[4] & 0x20 ? true : false; return 0; -- 2.45.2