Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Shuicheng Lin <shuicheng.lin@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Shuicheng Lin <shuicheng.lin@intel.com>,
	Michal Wajdeczko <michal.wajdeczko@intel.com>,
	Matthew Brost <matthew.brost@intel.com>
Subject: [PATCH 1/2] drm/xe/guc: Accumulate CT H2G retry sleep budget
Date: Mon, 23 Feb 2026 16:23:52 +0000	[thread overview]
Message-ID: <20260223162350.3205364-5-shuicheng.lin@intel.com> (raw)
In-Reply-To: <20260223162350.3205364-4-shuicheng.lin@intel.com>

guc_ct_send_wait_for_retry() introduced sleep_total_ms as a
budget guard, but never incremented it. As a result, the
"about 1 second" bailout condition never triggers in the H2G
backpressure path.

Accumulate the delay returned by xe_sleep_exponential_ms() into
sleep_total_ms so the timeout logic works as intended.

Fixes: 943c4d0637cf ("drm/xe/guc: Limit sleep while waiting for H2G credits")
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_ct.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
index 8a45573f8812..1c37813d2ccd 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
@@ -1124,7 +1124,7 @@ static bool guc_ct_send_wait_for_retry(struct xe_guc_ct *ct, u32 len,
 						 h2g->info.size,
 						 h2g->info.space,
 						 len + GUC_CTB_HDR_LEN);
-		xe_sleep_exponential_ms(sleep_period_ms, 64);
+		*sleep_total_ms += xe_sleep_exponential_ms(sleep_period_ms, 64);
 	} else {
 		struct xe_device *xe = ct_to_xe(ct);
 		struct guc_ctb *g2h = &ct->ctbs.g2h;
-- 
2.50.1


  reply	other threads:[~2026-02-23 16:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 16:23 [PATCH 0/2] Misc fix for xe_guc_ct.c Shuicheng Lin
2026-02-23 16:23 ` Shuicheng Lin [this message]
2026-02-23 16:59   ` [PATCH 1/2] drm/xe/guc: Accumulate CT H2G retry sleep budget Matthew Brost
2026-02-23 16:23 ` [PATCH 2/2] drm/xe/guc: Refine CT queue checks and log formatting Shuicheng Lin
2026-02-23 17:05   ` Matthew Brost
2026-02-23 16:35 ` ✓ CI.KUnit: success for Misc fix for xe_guc_ct.c Patchwork
2026-02-24 21:26 ` ✓ CI.KUnit: success for Misc fix for xe_guc_ct.c (rev2) Patchwork
2026-02-24 21:59 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-25  5:48 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-25 16:15   ` Lin, Shuicheng
2026-02-25 17:28     ` Matt Roper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260223162350.3205364-5-shuicheng.lin@intel.com \
    --to=shuicheng.lin@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox