From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C79CEC1112 for ; Mon, 23 Feb 2026 17:26:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0635B10E2FA; Mon, 23 Feb 2026 17:26:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="my4Z9WGe"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7ECAB10E085; Mon, 23 Feb 2026 17:25:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771867559; x=1803403559; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Mt6a1bGaBkfwcx86mxJBvKi5TNIFAjm/uHANPLwQk10=; b=my4Z9WGe7Rpq264qKeiX7A59FNBMpxqgNS8Nrb+VOUJSbvcnEg6WDlv1 JVeb8UKtwVxeBxC2o0QvtNRkKiGvOMsWhUmUaXyRuxrocdDkY2aotlU1p pupKq6Bn3BUAYWvRAB98VAqAB9XIlbLozPZFK3snTcDYFHtnqfWjxSYVg 8iSCims7z2vWenFRTfRYhcAZbp88ZnXCnJJ/h7JDm9ZwzMEFV3P1Ppnhm HbHtuuRFyC3ZZGpljalrTD1y53DbYq4l+fpQQsBl6xTFylDSUtRH9x3O3 IUWytYL+YqY8RQ1K0kpMI1xpLjI9df7zl2wBaj/lmWNMZVES5l5/7dKVT Q==; X-CSE-ConnectionGUID: 16NKTkACQLKkNPP/Sqn/Tg== X-CSE-MsgGUID: SKarxq0kS2W84xil0M1/JA== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="83189896" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="83189896" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 09:25:59 -0800 X-CSE-ConnectionGUID: mCHH8IAYRJi1qS/Rq5z7xg== X-CSE-MsgGUID: SaYoXXaIRsGK144dR5FRvQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="220624129" Received: from lstrano-desk.jf.intel.com ([10.54.39.91]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 09:25:58 -0800 From: Matthew Brost To: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: =?UTF-8?q?Christian=20K=C3=B6nig?= Subject: [PATCH] drm/i915/selftests: Fix build after dma-fence locking rework Date: Mon, 23 Feb 2026 09:25:53 -0800 Message-Id: <20260223172553.1663749-1-matthew.brost@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" The i915_active selftest no longer builds after the dma-fence locking rework because it directly accessed the fence’s spinlock. The helper dma_fence_spinlock() must now be used to obtain the spinlock. Update the selftest to use dma_fence_spinlock() accordingly. Fixes: 1f32f310a13c ("dma-buf: inline spinlock for fence protection v5") Cc: Christian König Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/selftests/i915_active.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_active.c b/drivers/gpu/drm/i915/selftests/i915_active.c index 52345073b409..9fea2fabeac4 100644 --- a/drivers/gpu/drm/i915/selftests/i915_active.c +++ b/drivers/gpu/drm/i915/selftests/i915_active.c @@ -323,9 +323,9 @@ static void active_flush(struct i915_active *ref, if (!fence) return; - spin_lock_irq(fence->lock); + spin_lock_irq(dma_fence_spinlock(fence)); __list_del_entry(&active->cb.node); - spin_unlock_irq(fence->lock); /* serialise with fence->cb_list */ + spin_unlock_irq(dma_fence_spinlock(fence)); /* serialise with fence->cb_list */ atomic_dec(&ref->count); GEM_BUG_ON(!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)); -- 2.34.1