From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40251EEC2A4 for ; Mon, 23 Feb 2026 22:29:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EBE2010E460; Mon, 23 Feb 2026 22:29:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Lrar5eKJ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A93F10E453; Mon, 23 Feb 2026 22:29:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771885783; x=1803421783; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=I02v5LYNcZqb3x+3eaGsHOBVYexqrW7eU4j43mdmBUM=; b=Lrar5eKJi/dq0yIUNHmSvbgCorbvpIgckxh/A8cY1x/V76iGzeJbdM9Y L7135/xQd66waDiaixQ3L7/8wVRRuGk5+Qc4fUcPz4PEsnBenbxZ7afV/ f8pdRXCv0pLvsV7xhic5Ws2+nP/WGLuF2hU3WVNIpV6lqdhyXadBsYjrl HPbyOPyqPyykZj91tVT3iojO1UGQuNF8swBy/r7AppFOmTFapUUqLs/aj mzpCnYU2RSnt+8L7WleKZvpY+iVBCE5ch7ea1eDpbWOdS6wYr1o4Cuw4p YnJ1lA8V16eq5I0hNNXPuo836aEKVUEAh9J2ffDap2MH8DzQv9/W6YJ75 w==; X-CSE-ConnectionGUID: oklGQuqjQe2+KGfGbzUIvQ== X-CSE-MsgGUID: OPbCk0MCTee1VcqKX66qFg== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="71921648" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="71921648" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 14:29:42 -0800 X-CSE-ConnectionGUID: fS+nCH/DSFeHgIQpZGBYww== X-CSE-MsgGUID: JPebEQfuTmynAO0rXkgEkQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="215720957" Received: from lstrano-desk.jf.intel.com ([10.54.39.91]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 14:29:43 -0800 From: Matthew Brost To: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Cc: Bart Van Assche , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= Subject: [PATCH] drm/pagemap: Unlock cache->lock before freeing it Date: Mon, 23 Feb 2026 14:29:37 -0800 Message-Id: <20260223222937.2008492-1-matthew.brost@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" From: Bart Van Assche Although freeing a spinlock without unlocking it is fine, this confuses static analyzers. Hence this patch. Fixes: 77f14f2f2d73 ("drm/pagemap: Add a drm_pagemap cache and shrinker") Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: Thomas Hellström Cc: Matthew Brost Signed-off-by: Bart Van Assche Reviewed-by: Matthew Brost --- drivers/gpu/drm/drm_pagemap_util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/drm_pagemap_util.c b/drivers/gpu/drm/drm_pagemap_util.c index 14ddb948a32e..50cb5f9cdac5 100644 --- a/drivers/gpu/drm/drm_pagemap_util.c +++ b/drivers/gpu/drm/drm_pagemap_util.c @@ -74,6 +74,8 @@ static void drm_pagemap_cache_fini(void *arg) cache->dpagemap = NULL; spin_unlock(&cache->lock); drm_pagemap_destroy(dpagemap, false); + } else { + spin_unlock(&cache->lock); } out: -- 2.34.1