From: Zhanjun Dong <zhanjun.dong@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Zhanjun Dong <zhanjun.dong@intel.com>
Subject: [PATCH v8 6/7] drm/xe/uc: Drop xe_guc_sanitize in favor of managed cleanup
Date: Tue, 24 Feb 2026 11:35:54 -0500 [thread overview]
Message-ID: <20260224163555.218750-7-zhanjun.dong@intel.com> (raw)
In-Reply-To: <20260224163555.218750-1-zhanjun.dong@intel.com>
If the firmware fails to load in GT resets the device is wedged also
initiating a GuC state cleanup.
Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
---
drivers/gpu/drm/xe/xe_uc.c | 22 +++++++---------------
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_uc.c b/drivers/gpu/drm/xe/xe_uc.c
index d9aa845a308d..75091bde0d50 100644
--- a/drivers/gpu/drm/xe/xe_uc.c
+++ b/drivers/gpu/drm/xe/xe_uc.c
@@ -157,23 +157,19 @@ static int vf_uc_load_hw(struct xe_uc *uc)
err = xe_gt_sriov_vf_connect(uc_to_gt(uc));
if (err)
- goto err_out;
+ return err;
uc->guc.submission_state.enabled = true;
err = xe_guc_opt_in_features_enable(&uc->guc);
if (err)
- goto err_out;
+ return err;
err = xe_gt_record_default_lrcs(uc_to_gt(uc));
if (err)
- goto err_out;
+ return err;
return 0;
-
-err_out:
- xe_guc_sanitize(&uc->guc);
- return err;
}
/*
@@ -205,19 +201,19 @@ int xe_uc_load_hw(struct xe_uc *uc)
ret = xe_gt_record_default_lrcs(uc_to_gt(uc));
if (ret)
- goto err_out;
+ return ret;
ret = xe_guc_post_load_init(&uc->guc);
if (ret)
- goto err_out;
+ return ret;
ret = xe_guc_pc_start(&uc->guc.pc);
if (ret)
- goto err_out;
+ return ret;
ret = xe_guc_rc_enable(&uc->guc);
if (ret)
- goto err_out;
+ return ret;
xe_guc_engine_activity_enable_stats(&uc->guc);
@@ -232,10 +228,6 @@ int xe_uc_load_hw(struct xe_uc *uc)
xe_gsc_load_start(&uc->gsc);
return 0;
-
-err_out:
- xe_guc_sanitize(&uc->guc);
- return ret;
}
int xe_uc_reset_prepare(struct xe_uc *uc)
--
2.34.1
next prev parent reply other threads:[~2026-02-24 16:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 16:35 [PATCH v8 0/7] Attempt to fixup reset, wedge, unload corner cases Zhanjun Dong
2026-02-24 16:35 ` [PATCH v8 1/7] drm/xe: Always kill exec queues in xe_guc_submit_pause_abort Zhanjun Dong
2026-02-24 16:35 ` [PATCH v8 2/7] drm/xe: Forcefully tear down exec queues in GuC submit fini Zhanjun Dong
2026-02-24 16:35 ` [PATCH v8 3/7] drm/xe: Trigger queue cleanup if not in wedged mode 2 Zhanjun Dong
2026-02-24 16:35 ` [PATCH v8 4/7] drm/xe: Use XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET enum instead of magic number Zhanjun Dong
2026-02-24 16:35 ` [PATCH v8 5/7] drm/xe/guc: Ensure CT state transitions via STOP before DISABLED Zhanjun Dong
2026-02-24 16:35 ` Zhanjun Dong [this message]
2026-02-24 16:35 ` [PATCH v8 7/7] drm/xe: Open-code GGTT MMIO access protection Zhanjun Dong
2026-03-05 15:22 ` Dong, Zhanjun
2026-02-24 16:43 ` ✓ CI.KUnit: success for Attempt to fixup reset, wedge, unload corner cases Patchwork
2026-02-26 0:43 ` ✓ CI.KUnit: success for Attempt to fixup reset, wedge, unload corner cases (rev2) Patchwork
2026-02-26 1:18 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-26 4:45 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-06 21:13 ` ✓ CI.KUnit: success for Attempt to fixup reset, wedge, unload corner cases (rev3) Patchwork
2026-03-06 21:58 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-08 0:26 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-09 21:52 ` Dong, Zhanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224163555.218750-7-zhanjun.dong@intel.com \
--to=zhanjun.dong@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox