Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, Jani Nikula <jani.nikula@intel.com>
Subject: [PATCH v2 04/19] drm/i915/overlay: Remove redundant overlay->active
Date: Thu, 26 Feb 2026 12:07:23 +0200	[thread overview]
Message-ID: <20260226100738.29997-5-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20260226100738.29997-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Now that we have overlay->frontbuffer_bits, overlay->active
is completely redundant, so remove it.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_overlay.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c
index 5831af146b14..b2458840dfc4 100644
--- a/drivers/gpu/drm/i915/display/intel_overlay.c
+++ b/drivers/gpu/drm/i915/display/intel_overlay.c
@@ -194,7 +194,6 @@ struct intel_overlay {
 	struct i915_vma *vma;
 	struct i915_vma *old_vma;
 	struct intel_frontbuffer *frontbuffer;
-	bool active;
 	bool pfit_active;
 	u32 pfit_vscale_ratio; /* shifted-point number, (1<<12) == 1.0 */
 	u32 color_key:24;
@@ -260,7 +259,7 @@ static bool i915_overlay_is_active(struct drm_device *drm)
 	struct intel_display *display = to_intel_display(drm);
 	struct intel_overlay *overlay = display->overlay;
 
-	return overlay->active;
+	return overlay->frontbuffer_bits;
 }
 
 /* overlay needs to be disable in OCMD reg */
@@ -283,7 +282,6 @@ static int intel_overlay_on(struct intel_overlay *overlay,
 		return PTR_ERR(cs);
 	}
 
-	overlay->active = true;
 	overlay->frontbuffer_bits = frontbuffer_bits;
 
 	if (display->platform.i830)
@@ -392,7 +390,6 @@ static void intel_overlay_off_tail(struct intel_overlay *overlay)
 
 	intel_overlay_release_old_vma(overlay);
 
-	overlay->active = false;
 	overlay->frontbuffer_bits = 0;
 
 	if (display->platform.i830)
@@ -514,7 +511,6 @@ void intel_overlay_reset(struct intel_display *display)
 	overlay->old_xscale = 0;
 	overlay->old_yscale = 0;
 	overlay->crtc = NULL;
-	overlay->active = false;
 	overlay->frontbuffer_bits = 0;
 }
 
-- 
2.52.0


  parent reply	other threads:[~2026-02-26 10:08 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 10:07 [PATCH v2 00/19] drm/i915/overlay: Convert to parent interface Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 01/19] drm/i915/overlay: Remove GPU hang snapshot stuff Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 02/19] drm/i915/overlay: Track current frontbuffer_bits Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 03/19] drm/i915/overlay: Extract i915_overlay_is_active() Ville Syrjala
2026-02-26 10:07 ` Ville Syrjala [this message]
2026-02-26 10:07 ` [PATCH v2 05/19] drm/i915/overlay: Relocate the underrun check Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 06/19] drm/i915/overlay: Introduce i915_overlay_obj_lookup() Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 07/19] drm/i915/overlay: Use struct drm_gem_object as the type Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 08/19] drm/i915/overlay: Extract i915_overlay_reset() Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 09/19] drm/i915/overlay: Extract i915_overlay_setup() Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 10/19] drm/i915/overlay: Extract i915_overlay_cleanup() Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 11/19] drm/i915/overlay: Abstract buffer (un)pinning Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 12/19] drm/i915/overlay: Rename low level i915 specific functions Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 13/19] drm/i915/overlay: Adjust i915 specific interfaces Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 14/19] drm/i915/overlay: Make i830_overlay_clock_gating() i915 specific Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 15/19] drm/i915/overlay: s/dev_priv/i915/ Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 16/19] drm/i915/overlay: Split 'struct intel_overlay' Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 17/19] drm/i915/overlay: Don't use fetch_and_zero() in display code Ville Syrjala
2026-02-26 13:01   ` [PATCH v3 " Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 18/19] drm/i915/overlay: Move i915 specific code into i915_overlay.c Ville Syrjala
2026-02-26 13:38   ` [PATCH v3 " Ville Syrjala
2026-02-26 10:07 ` [PATCH v2 19/19] drm/i915/overlay: Convert overlay to parent interface Ville Syrjala
2026-02-26 13:01   ` [PATCH v3 " Ville Syrjala
2026-02-26 10:15 ` ✗ CI.checkpatch: warning for drm/i915/overlay: Convert to parent interface (rev2) Patchwork
2026-02-26 10:16 ` ✓ CI.KUnit: success " Patchwork
2026-02-26 11:03 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-02-26 12:27 ` ✗ Xe.CI.FULL: " Patchwork
2026-02-26 13:45 ` ✗ CI.checkpatch: warning for drm/i915/overlay: Convert to parent interface (rev5) Patchwork
2026-02-26 13:47 ` ✓ CI.KUnit: success " Patchwork
2026-02-26 14:42 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-26 16:14 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260226100738.29997-5-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox