From: Thomas Zimmermann <tzimmermann@suse.de>
To: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
airlied@gmail.com, simona@ffwll.ch
Cc: dri-devel@lists.freedesktop.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Matthew Brost" <matthew.brost@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
intel-xe@lists.freedesktop.org
Subject: [PATCH] drm/xe: Test for imported buffers with drm_gem_is_imported()
Date: Fri, 27 Feb 2026 14:31:12 +0100 [thread overview]
Message-ID: <20260227133113.235940-13-tzimmermann@suse.de> (raw)
Instead of testing import_attach for imported GEM buffers, invoke
drm_gem_is_imported() to do the test. The test itself does not change.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-xe@lists.freedesktop.org
---
drivers/gpu/drm/xe/xe_bo.c | 8 ++++----
drivers/gpu/drm/xe/xe_vm.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index 8ff193600443..b28ed3fa370e 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -817,7 +817,7 @@ static int xe_bo_move_notify(struct xe_bo *bo,
return ret;
/* Don't call move_notify() for imported dma-bufs. */
- if (ttm_bo->base.dma_buf && !ttm_bo->base.import_attach)
+ if (ttm_bo->base.dma_buf && !drm_gem_is_imported(&ttm_bo->base))
dma_buf_invalidate_mappings(ttm_bo->base.dma_buf);
/*
@@ -1707,7 +1707,7 @@ static void xe_ttm_bo_destroy(struct ttm_buffer_object *ttm_bo)
struct xe_tile *tile;
u8 id;
- if (bo->ttm.base.import_attach)
+ if (drm_gem_is_imported(&bo->ttm.base))
drm_prime_gem_destroy(&bo->ttm.base, NULL);
drm_gem_object_release(&bo->ttm.base);
@@ -2829,7 +2829,7 @@ int xe_bo_pin(struct xe_bo *bo, struct drm_exec *exec)
* No reason we can't support pinning imported dma-bufs we just don't
* expect to pin an imported dma-buf.
*/
- xe_assert(xe, !bo->ttm.base.import_attach);
+ xe_assert(xe, !drm_gem_is_imported(&bo->ttm.base));
/* We only expect at most 1 pin */
xe_assert(xe, !xe_bo_is_pinned(bo));
@@ -2899,7 +2899,7 @@ void xe_bo_unpin(struct xe_bo *bo)
struct ttm_place *place = &bo->placements[0];
struct xe_device *xe = xe_bo_device(bo);
- xe_assert(xe, !bo->ttm.base.import_attach);
+ xe_assert(xe, !drm_gem_is_imported(&bo->ttm.base));
xe_assert(xe, xe_bo_is_pinned(bo));
if (mem_type_is_vram(place->mem_type) || bo->flags & XE_BO_FLAG_GGTT) {
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 5adabfd5dc30..052ddb167dbf 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -3604,7 +3604,7 @@ static int xe_vm_bind_ioctl_validate_bo(struct xe_device *xe, struct xe_bo *bo,
* with a PAT index that enables compression.
*/
comp_en = xe_pat_index_get_comp_en(xe, pat_index);
- if (XE_IOCTL_DBG(xe, bo->ttm.base.import_attach && comp_en))
+ if (XE_IOCTL_DBG(xe, drm_gem_is_imported(&bo->ttm.base) && comp_en))
return -EINVAL;
/* If a BO is protected it can only be mapped if the key is still valid */
--
2.52.0
next reply other threads:[~2026-02-27 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 13:31 Thomas Zimmermann [this message]
2026-02-27 14:38 ` ✓ CI.KUnit: success for drm/xe: Test for imported buffers with drm_gem_is_imported() Patchwork
2026-02-27 15:27 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-27 17:39 ` [PATCH] " Matthew Brost
2026-02-28 1:34 ` ✗ Xe.CI.FULL: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260227133113.235940-13-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=mripard@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox