✗ CI.checkpatch: warning for Two-pass MMU interval notifiers (rev3)

Patchwork
2026-03-03T15:25:08Z

== Series Details ==

Series: Two-pass MMU interval notifiers (rev3)
URL : https://patchwork.freedesktop.org/series/153280/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
1f57ba1afceae32108bd24770069f764d940a0e4
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 86bdfee9959a3779793d38ca5d22371925d4f4bf
Author: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Date: Tue Mar 3 14:34:09 2026 +0100

drm/xe/userptr: Defer Waiting for TLB invalidation to the second pass if possible

Now that the two-pass notifier flow uses xe_vma_userptr_do_inval() for
the fence-wait + TLB-invalidate work, extend it to support a further
deferred TLB wait:

- xe_vma_userptr_do_inval(): when the embedded finish handle is free,
submit the TLB invalidation asynchronously (xe_vm_invalidate_vma_submit)
and return &userptr->finish so the mmu_notifier core schedules a third
pass. When the handle is occupied by a concurrent invalidation, fall
back to the synchronous xe_vm_invalidate_vma() path.

- xe_vma_userptr_complete_tlb_inval(): new helper called from
invalidate_finish when tlb_inval_submitted is set. Waits for the
previously submitted batch and unmaps the gpusvm pages.

xe_vma_userptr_invalidate_finish() dispatches between the two helpers
via tlb_inval_submitted, making the three possible flows explicit:

pass1 (fences pending) -> invalidate_finish -> do_inval (sync TLB)
pass1 (fences done) -> do_inval -> invalidate_finish
-> complete_tlb_inval (deferred TLB)
pass1 (finish occupied) -> do_inval (sync TLB, inline)

In multi-GPU scenarios this allows TLB flushes to be submitted on all
GPUs in one pass before any of them are waited on.

Also adds xe_vm_invalidate_vma_submit() which submits the TLB range
invalidation without blocking, populating a xe_tlb_inval_batch that
the caller waits on separately.

v3:
- Add locking asserts and notifier state asserts (Matt Brost)
- Update the locking documentation of the notifier
state members (Matt Brost)
- Remove unrelated code formatting changes (Matt Brost)

Assisted-by: GitHub Copilot:claude-sonnet-4.6
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
+ /mt/dim checkpatch 591d026bf9c13f8982524c9f6d945be1e6f4cfc6 drm-intel
d01070791437 mm/mmu_notifier: Allow two-pass struct mmu_interval_notifiers
-:53: WARNING:BAD_SIGN_OFF: Non-standard signature: Assisted-by:
#53:
Assisted-by: GitHub Copilot:claude-sonnet-4.6 # Documentation only.

-:53: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'GitHub Copilot:claude-sonnet-4.6 # Documentation only.'
#53:
Assisted-by: GitHub Copilot:claude-sonnet-4.6 # Documentation only.

total: 1 errors, 1 warnings, 0 checks, 169 lines checked
64e3bd5ff490 drm/xe/userptr: Convert invalidation to two-pass MMU notifier
-:38: WARNING:BAD_SIGN_OFF: Non-standard signature: Assisted-by:
#38:
Assisted-by: GitHub Copilot:claude-sonnet-4.6

-:38: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'GitHub Copilot:claude-sonnet-4.6'
#38:
Assisted-by: GitHub Copilot:claude-sonnet-4.6

total: 1 errors, 1 warnings, 0 checks, 191 lines checked
fab3e6bb8c28 drm/xe: Split TLB invalidation into submit and wait steps
-:26: WARNING:BAD_SIGN_OFF: Non-standard signature: Assisted-by:
#26:
Assisted-by: GitHub Copilot:claude-sonnet-4.6

-:26: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'GitHub Copilot:claude-sonnet-4.6'
#26:
Assisted-by: GitHub Copilot:claude-sonnet-4.6

total: 1 errors, 1 warnings, 0 checks, 282 lines checked
86bdfee9959a drm/xe/userptr: Defer Waiting for TLB invalidation to the second pass if possible
-:45: WARNING:BAD_SIGN_OFF: Non-standard signature: Assisted-by:
#45:
Assisted-by: GitHub Copilot:claude-sonnet-4.6

-:45: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'GitHub Copilot:claude-sonnet-4.6'
#45:
Assisted-by: GitHub Copilot:claude-sonnet-4.6

total: 1 errors, 1 warnings, 0 checks, 219 lines checked