From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CE74EDEC04 for ; Wed, 4 Mar 2026 04:07:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 28A5510E949; Wed, 4 Mar 2026 04:07:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="KZOLfMk2"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id A0EE110E949; Wed, 4 Mar 2026 04:07:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772597229; x=1804133229; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=50u9Oj7FhrCr0vpCi1mfAAMEjBGEUA4SmMMwZeUxinw=; b=KZOLfMk2KYbPJsK3FdJTtQ/6rmtIGHpbPityMlP4SJmEKhzlaymI85J7 o6vd9FpyvMWmkfmqBzWiApYnmZaKTMShvA3yQyF98fMq2kXinCul2dPgb naLHHLcvBjhUk7sMjSZ63v4i1Q1iOvCmRcEwvKGjG7hUkEiW19ngFPE+K z0JWvKjww9ycuhGrwBpb8TnwhSpRnfGV4kQN+Xe+dyVCVc2QB5PUGvfsJ dsEG2Pk/xXHoqsW7DBeoitD0wxqO7IqxmWL9yFwo2ads2bwbp3ABGV3gg ot9OhCXkdxqPWgUdZQr09DUf4EsMsW6iH69Va+B4SaouYD92cmwpJ60zB A==; X-CSE-ConnectionGUID: KAPnl87QSmC7TTnrTMtN8A== X-CSE-MsgGUID: uqYa8HMFRdC+l2jBE+UAjw== X-IronPort-AV: E=McAfee;i="6800,10657,11718"; a="77257903" X-IronPort-AV: E=Sophos;i="6.21,323,1763452800"; d="scan'208";a="77257903" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2026 20:07:08 -0800 X-CSE-ConnectionGUID: Ix/sq/wUToOcq2jpGTxgTw== X-CSE-MsgGUID: +okBiGiSRKWZIT3LDHp27g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,323,1763452800"; d="scan'208";a="218327171" Received: from srr4-3-linux-106-armuthy.iind.intel.com ([10.190.238.56]) by orviesa007.jf.intel.com with ESMTP; 03 Mar 2026 20:07:05 -0800 From: Arun R Murthy To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: animesh.manna@intel.com, ankit.k.nautiyal@intel.com, jani.nikula@intel.com, jouni.hogander@intel.com, Arun R Murthy Subject: [PATCHv4] drm/i915/dp: Read ALPM caps after DPCD init Date: Wed, 4 Mar 2026 09:35:51 +0530 Message-Id: <20260304040551.754483-1-arun.r.murthy@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260302033630.428913-1-arun.r.murthy@intel.com> References: <20260302033630.428913-1-arun.r.murthy@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" For eDP read the ALPM DPCD caps after DPCD initalization and just before the PSR init. v2: Move intel_alpm_init to intel_edp_init_dpcd (Jouni) v3: Add Fixes with commit-id (Jouni) v4: Separated the alpm dpcd read caps from alpm_init and moved to intel_edp_init_dpcd. Fixes: 15438b325987 ("drm/i915/alpm: Add compute config for lobf") Signed-off-by: Arun R Murthy --- drivers/gpu/drm/i915/display/intel_alpm.c | 6 ------ drivers/gpu/drm/i915/display/intel_dp.c | 9 +++++++++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c b/drivers/gpu/drm/i915/display/intel_alpm.c index b3334bc4d0f9..a7350ce8e716 100644 --- a/drivers/gpu/drm/i915/display/intel_alpm.c +++ b/drivers/gpu/drm/i915/display/intel_alpm.c @@ -44,12 +44,6 @@ bool intel_alpm_is_alpm_aux_less(struct intel_dp *intel_dp, void intel_alpm_init(struct intel_dp *intel_dp) { - u8 dpcd; - - if (drm_dp_dpcd_readb(&intel_dp->aux, DP_RECEIVER_ALPM_CAP, &dpcd) < 0) - return; - - intel_dp->alpm_dpcd = dpcd; mutex_init(&intel_dp->alpm.lock); } diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 025e906b63a9..e781d4d0dd1b 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -4709,6 +4709,7 @@ static bool intel_edp_init_dpcd(struct intel_dp *intel_dp, struct intel_connector *connector) { struct intel_display *display = to_intel_display(intel_dp); + int ret; /* this function is meant to be called only once */ drm_WARN_ON(display->drm, intel_dp->dpcd[DP_DPCD_REV] != 0); @@ -4748,6 +4749,14 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp, struct intel_connector *connector */ intel_dp_init_source_oui(intel_dp); + /* Read the ALPM DPCD caps */ + if (intel_dp->edp_dpcd[0] >= DP_EDP_14) { + ret = drm_dp_dpcd_readb(&intel_dp->aux, DP_RECEIVER_ALPM_CAP, + &intel_dp->alpm_dpcd); + if (ret < 0) + return false; + } + /* * This has to be called after intel_dp->edp_dpcd is filled, PSR checks * for SET_POWER_CAPABLE bit in intel_dp->edp_dpcd[1] -- 2.25.1