From: Arnd Bergmann <arnd@kernel.org>
To: "Matthew Brost" <matthew.brost@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Dnyaneshwar Bhadane" <dnyaneshwar.bhadane@intel.com>,
"Matt Roper" <matthew.d.roper@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Lucas De Marchi <demarchi@kernel.org>,
Tvrtko Ursulin <tvrtko.ursulin@igalia.com>,
Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
Raag Jadav <raag.jadav@intel.com>,
Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>,
intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] drm/xe: use %z format string for ptrdiff_t
Date: Mon, 16 Mar 2026 23:43:46 +0100 [thread overview]
Message-ID: <20260316224357.658520-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
ptrdiff_t, size_t and long are the same size on all supported architectures,
but gcc requires the use of the %zx modifier instead of %lx. On 32-bit
targets, the wrong one produces this warning:
drivers/gpu/drm/xe/xe_lrc.c:1913:7: error: format specifies type 'unsigned long' but the argument has type '__ptrdiff_t' (aka 'int') [-Werror,-Wformat]
1912 | drm_printf(p, "LRC[%#5lx] = [%#010x] MI_NOOP (%d dwords)\n",
| ~~~~~
| %#5tx
1913 | dw - num_noop - start, inst_header, num_noop);
| ^~~~~~~~~~~~~~~~~~~~~
Fixes: 65fcf19cb36b ("drm/xe: Include running dword offset in default_lrc dumps")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/xe/xe_lrc.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
index 5ab088e5e13d..c528818e8853 100644
--- a/drivers/gpu/drm/xe/xe_lrc.c
+++ b/drivers/gpu/drm/xe/xe_lrc.c
@@ -1909,17 +1909,17 @@ static int dump_mi_command(struct drm_printer *p,
while (num_noop < remaining_dw &&
(*(++dw) & REG_GENMASK(31, 23)) == MI_NOOP)
num_noop++;
- drm_printf(p, "LRC[%#5lx] = [%#010x] MI_NOOP (%d dwords)\n",
+ drm_printf(p, "LRC[%#5zx] = [%#010x] MI_NOOP (%d dwords)\n",
dw - num_noop - start, inst_header, num_noop);
return num_noop;
case MI_TOPOLOGY_FILTER:
- drm_printf(p, "LRC[%#5lx] = [%#010x] MI_TOPOLOGY_FILTER\n",
+ drm_printf(p, "LRC[%#5zx] = [%#010x] MI_TOPOLOGY_FILTER\n",
dw - start, inst_header);
return 1;
case MI_BATCH_BUFFER_END:
- drm_printf(p, "LRC[%#5lx] = [%#010x] MI_BATCH_BUFFER_END\n",
+ drm_printf(p, "LRC[%#5zx] = [%#010x] MI_BATCH_BUFFER_END\n",
dw - start, inst_header);
/* Return 'remaining_dw' to consume the rest of the LRC */
return remaining_dw;
@@ -1934,35 +1934,35 @@ static int dump_mi_command(struct drm_printer *p,
switch (inst_header & MI_OPCODE) {
case MI_LOAD_REGISTER_IMM:
- drm_printf(p, "LRC[%#5lx] = [%#010x] MI_LOAD_REGISTER_IMM: %d regs\n",
+ drm_printf(p, "LRC[%#5zx] = [%#010x] MI_LOAD_REGISTER_IMM: %d regs\n",
dw - start, inst_header, (numdw - 1) / 2);
for (int i = 1; i < numdw; i += 2)
- drm_printf(p, "LRC[%#5lx] = - %#6x = %#010x\n",
+ drm_printf(p, "LRC[%#5zx] = - %#6x = %#010x\n",
&dw[i] - start, dw[i], dw[i + 1]);
return numdw;
case MI_LOAD_REGISTER_MEM & MI_OPCODE:
- drm_printf(p, "LRC[%#5lx] = [%#010x] MI_LOAD_REGISTER_MEM: %s%s\n",
+ drm_printf(p, "LRC[%#5zx] = [%#010x] MI_LOAD_REGISTER_MEM: %s%s\n",
dw - start, inst_header,
dw[0] & MI_LRI_LRM_CS_MMIO ? "CS_MMIO " : "",
dw[0] & MI_LRM_USE_GGTT ? "USE_GGTT " : "");
if (numdw == 4)
- drm_printf(p, "LRC[%#5lx] = - %#6x = %#010llx\n",
+ drm_printf(p, "LRC[%#5zx] = - %#6x = %#010llx\n",
dw - start,
dw[1], ((u64)(dw[3]) << 32 | (u64)(dw[2])));
else
- drm_printf(p, "LRC[%#5lx] = - %*ph (%s)\n",
+ drm_printf(p, "LRC[%#5zx] = - %*ph (%s)\n",
dw - start, (int)sizeof(u32) * (numdw - 1),
dw + 1, numdw < 4 ? "truncated" : "malformed");
return numdw;
case MI_FORCE_WAKEUP:
- drm_printf(p, "LRC[%#5lx] = [%#010x] MI_FORCE_WAKEUP\n",
+ drm_printf(p, "LRC[%#5zx] = [%#010x] MI_FORCE_WAKEUP\n",
dw - start, inst_header);
return numdw;
default:
- drm_printf(p, "LRC[%#5lx] = [%#010x] unknown MI opcode %#x, likely %d dwords\n",
+ drm_printf(p, "LRC[%#5zx] = [%#010x] unknown MI opcode %#x, likely %d dwords\n",
dw - start, inst_header, opcode, numdw);
return numdw;
}
@@ -1989,12 +1989,12 @@ static int dump_gfxpipe_command(struct drm_printer *p,
switch (*dw & GFXPIPE_MATCH_MASK) {
#define MATCH(cmd) \
case cmd: \
- drm_printf(p, "LRC[%#5lx] = [%#010x] " #cmd " (%d dwords)\n", \
+ drm_printf(p, "LRC[%#5zx] = [%#010x] " #cmd " (%d dwords)\n", \
dw - start, *dw, numdw); \
return numdw
#define MATCH3D(cmd) \
case CMD_##cmd: \
- drm_printf(p, "LRC[%#5lx] = [%#010x] " #cmd " (%d dwords)\n", \
+ drm_printf(p, "LRC[%#5zx] = [%#010x] " #cmd " (%d dwords)\n", \
dw - start, *dw, numdw); \
return numdw
@@ -2127,7 +2127,7 @@ static int dump_gfxpipe_command(struct drm_printer *p,
MATCH3D(3DSTATE_SLICE_TABLE_STATE_POINTER_2);
default:
- drm_printf(p, "LRC[%#5lx] = [%#010x] unknown GFXPIPE command (pipeline=%#x, opcode=%#x, subopcode=%#x), likely %d dwords\n",
+ drm_printf(p, "LRC[%#5zx] = [%#010x] unknown GFXPIPE command (pipeline=%#x, opcode=%#x, subopcode=%#x), likely %d dwords\n",
dw - start, *dw, pipeline, opcode, subopcode, numdw);
return numdw;
}
@@ -2153,7 +2153,7 @@ static int dump_gfx_state_command(struct drm_printer *p,
MATCH(STATE_WRITE_INLINE);
default:
- drm_printf(p, "LRC[%#5lx] = [%#010x] unknown GFX_STATE command (opcode=%#x), likely %d dwords\n",
+ drm_printf(p, "LRC[%#5zx] = [%#010x] unknown GFX_STATE command (opcode=%#x), likely %d dwords\n",
dw - start, *dw, opcode, numdw);
return numdw;
}
@@ -2188,7 +2188,7 @@ void xe_lrc_dump_default(struct drm_printer *p,
num_dw = dump_gfx_state_command(p, gt, start, dw, remaining_dw);
} else {
num_dw = min(instr_dw(*dw), remaining_dw);
- drm_printf(p, "LRC[%#5lx] = [%#10x] Unknown instruction of type %#x, likely %d dwords\n",
+ drm_printf(p, "LRC[%#5zx] = [%#10x] Unknown instruction of type %#x, likely %d dwords\n",
dw - start,
*dw, REG_FIELD_GET(XE_INSTR_CMD_TYPE, *dw),
num_dw);
--
2.39.5
next reply other threads:[~2026-03-16 22:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 22:43 Arnd Bergmann [this message]
2026-03-16 22:51 ` [PATCH] drm/xe: use %z format string for ptrdiff_t Matt Roper
2026-03-16 23:07 ` Arnd Bergmann
2026-03-17 14:56 ` David Laight
2026-03-17 16:46 ` David Laight
2026-03-17 0:50 ` ✗ CI.checkpatch: warning for " Patchwork
2026-03-17 0:52 ` ✓ CI.KUnit: success " Patchwork
2026-03-17 1:26 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-18 4:29 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316224357.658520-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=airlied@gmail.com \
--cc=arnd@arndb.de \
--cc=demarchi@kernel.org \
--cc=dnyaneshwar.bhadane@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=niranjana.vishwanathapura@intel.com \
--cc=raag.jadav@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tvrtko.ursulin@igalia.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox