From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68442F483C3 for ; Mon, 23 Mar 2026 16:04:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1E55A10E56A; Mon, 23 Mar 2026 16:04:19 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=permerror (0-bit key) header.d=shazbot.org header.i=@shazbot.org header.b="rMILFVqr"; dkim=permerror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="W0gy8EiR"; dkim-atps=neutral X-Greylist: delayed 542 seconds by postgrey-1.36 at gabe; Tue, 17 Mar 2026 14:52:46 UTC Received: from fhigh-a7-smtp.messagingengine.com (fhigh-a7-smtp.messagingengine.com [103.168.172.158]) by gabe.freedesktop.org (Postfix) with ESMTPS id E145B10E4AA for ; Tue, 17 Mar 2026 14:52:46 +0000 (UTC) Received: from phl-compute-11.internal (phl-compute-11.internal [10.202.2.51]) by mailfhigh.phl.internal (Postfix) with ESMTP id 3DA8A140003C; Tue, 17 Mar 2026 10:43:43 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Tue, 17 Mar 2026 10:43:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shazbot.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1773758623; x=1773845023; bh=U9M+HkVQBEYKrxCJ9TstEQmfV+0p5tozuQ5lwFDFX1M=; b= rMILFVqr1IpYmMQ1rQAMzOMN2QYPYf6LtDM3AeD1/yC8cEXCIxG/Z5Q6zPNckHT5 Tkxhz65Fi0GXREx9URvc+1b3aXe+2HX6isUOhYXGnbrJ8dx2pmnYGZE0cuv6CgMX NbU4rDAng1lVv/T3le210RmNJrd8RzACAsqABbvekC2d4CSmPO+n8L6xm9DFOFLf iYJ+5nePmhBSs/KwFR421mxt7uMg/uohHJ0itkC+Nwd3ZudlavLIgllE7vELeuwd hQU2wJRfECKdSJ9Hfj4wL9iiYLv3fvIDIcYe+bAfQgj+sYOQutX/4RGjBoR+xuSu rI8oD8kFFaUIJYli4iyg9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1773758623; x= 1773845023; bh=U9M+HkVQBEYKrxCJ9TstEQmfV+0p5tozuQ5lwFDFX1M=; b=W 0gy8EiR8pDQLseBb825jsb/L6yuG/Bi0/eZuGcEzSr/7W15rxrzwlYRiVlL1oG6G B45rwMGdiiI6e3BdC0J511jkNal2ZVaH1GxWGyBzA626prK+2tloBYmdrRq+Rlr4 2as3afSoYR2vKdYJsK0mdudKoEG9UELqvvYQoCXidEHubjyQ4c7dtHrC4ZbO6YB8 QuVj47+CWoZHam8Ce6HKlYndTGhmQF4xXeWDhXJybnzlhwwyiBwVFU7tIWlgDLrC egMl02HS3UYH0nL3k2ylWrRvv1NszfwPZT/jrGNIzrTxWlTPMrS2SfPTAUdCDVtF UlO+1aeQXkj3aLA1ERlLQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeftdduhedvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkjghfofggtgfgsehtqhertdertdejnecuhfhrohhmpeetlhgvgicu hghilhhlihgrmhhsohhnuceorghlvgigsehshhgriigsohhtrdhorhhgqeenucggtffrrg htthgvrhhnpeegudevhfejueefveduieeuueeifeettdekveekhffgvdetfeelueehgfdt heffhfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grlhgvgiesshhhrgiisghothdrohhrghdpnhgspghrtghpthhtohephedpmhhouggvpehs mhhtphhouhhtpdhrtghpthhtohepphhiohhtrhdrphhiohhrkhhofihskhhisehinhhtvg hlrdgtohhmpdhrtghpthhtohepihhnthgvlhdqgigvsehlihhsthhsrdhfrhgvvgguvghs khhtohhprdhorhhgpdhrtghpthhtohepkhhvmhesvhhgvghrrdhkvghrnhgvlhdrohhrgh dprhgtphhtthhopehmihgthhgrlhdrfihinhhirghrshhkihesihhnthgvlhdrtghomhdp rhgtphhtthhopegrlhgvgiesshhhrgiisghothdrohhrgh X-ME-Proxy: Feedback-ID: i03f14258:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Mar 2026 10:43:42 -0400 (EDT) Date: Tue, 17 Mar 2026 08:43:40 -0600 From: Alex Williamson To: "=?UTF-8?B?UGnDs3Jrb3dza2ks?= Piotr" Cc: , , =?UTF-8?B?TWljaGHFgg==?= Winiarski , alex@shazbot.org Subject: Re: [PATCH v2 2/2] vfio/xe: Notify PF about VF FLR in reset_prepare Message-ID: <20260317084340.619c5fad@shazbot.org> In-Reply-To: <20260309152449.910636-3-piotr.piorkowski@intel.com> References: <20260309152449.910636-1-piotr.piorkowski@intel.com> <20260309152449.910636-3-piotr.piorkowski@intel.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Mon, 23 Mar 2026 16:04:08 +0000 X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 9 Mar 2026 16:24:49 +0100 "Pi=C3=B3rkowski, Piotr" wrote: > From: Piotr Pi=C3=B3rkowski >=20 > Hook into the PCI error handler reset_prepare() callback to notify > the PF about an upcoming VF FLR before reset_done() is executed. > This enables early FLR_PREPARE signaling and ensures that the PF is > aware of the reset before the completion wait begins. >=20 > Signed-off-by: Piotr Pi=C3=B3rkowski > Cc: Micha=C5=82 Winiarski > --- > drivers/vfio/pci/xe/main.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) >=20 > diff --git a/drivers/vfio/pci/xe/main.c b/drivers/vfio/pci/xe/main.c > index fff95b2d5dde..88acfcf840fc 100644 > --- a/drivers/vfio/pci/xe/main.c > +++ b/drivers/vfio/pci/xe/main.c > @@ -85,6 +85,19 @@ static void xe_vfio_pci_state_mutex_unlock(struct xe_v= fio_pci_core_device *xe_vd > spin_unlock(&xe_vdev->reset_lock); > } > =20 > +static void xe_vfio_pci_reset_prepare(struct pci_dev *pdev) > +{ > + struct xe_vfio_pci_core_device *xe_vdev =3D pci_get_drvdata(pdev); > + int ret; > + > + if (!pdev->is_virtfn) > + return; > + > + ret =3D xe_sriov_vfio_flr_prepare(xe_vdev->xe, xe_vdev->vfid); > + if (ret) > + dev_err(&pdev->dev, "Failed to prepare FLR: %d\n", ret); > +} > + > static void xe_vfio_pci_reset_done(struct pci_dev *pdev) > { > struct xe_vfio_pci_core_device *xe_vdev =3D pci_get_drvdata(pdev); > @@ -127,6 +140,7 @@ static void xe_vfio_pci_reset_done(struct pci_dev *pd= ev) > } > =20 > static const struct pci_error_handlers xe_vfio_pci_err_handlers =3D { > + .reset_prepare =3D xe_vfio_pci_reset_prepare, > .reset_done =3D xe_vfio_pci_reset_done, > .error_detected =3D vfio_pci_core_aer_err_detected, > }; Looks ok to me, should really have Micha=C5=82's ack as well. Will this go in through drm? Reviewed-by: Alex Williamson