public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Pekka Paalanen <pekka.paalanen@collabora.com>
To: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>
Cc: Harry Wentland <harry.wentland@amd.com>,
	<dri-devel@lists.freedesktop.org>,
	<intel-gfx@lists.freedesktop.org>,
	<intel-xe@lists.freedesktop.org>, <louis.chauvet@bootlin.com>,
	<mwen@igalia.com>, <contact@emersion.fr>, <alex.hung@amd.com>,
	<daniels@collabora.com>, <uma.shankar@intel.com>,
	<maarten.lankhorst@intel.com>, <pranay.samala@intel.com>,
	<swati2.sharma@intel.com>
Subject: Re: [PATCH 01/10] drm/colorop: Add DRM_COLOROP_CSC_FF
Date: Tue, 17 Mar 2026 16:09:51 +0200	[thread overview]
Message-ID: <20260317160951.407ee82a@eldfell> (raw)
In-Reply-To: <306d456f-4015-4b28-9fd8-b671d4c01929@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1751 bytes --]

On Tue, 17 Mar 2026 17:59:27 +0530
"Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com> wrote:

> AFAIU, the block I wanted to represent is Full Range YCbCr -> Full Range 
> RGB. We have the following configuration in our plane.
> 
> [YUV range correction Block] -> [Degamma LUT] -> [PRESET CSC] -> [Gamma LUT]
> 
> With the legacy "COLOR RANGE" property, selecting limited range enabled 
> the YUV range correction block.
> 
> I still need to figure out what use-case does the degamma LUT in between 
> the Range correction block and the Preset CSC serve since YCbCr to RGB 
> conversion will take place in non-linear domain. But it makes me wonder 

Hi Chaitanya,

yes, that is peculiar indeed. At least "Degamma LUT" is usable with RGB
framebuffers.

> if we can have "COLOR ENCODING" and "COLOR RANGE" property within the 
> same colorop like you have been implementing in [1] or should they be 
> represented by separate colorops.

If there is another operation in between (Degamma LUT) that you want to
expose, then range-conversion and fixed-matrix operations need to have
their own colorops. The chain of colorops cannot go backwards.

OTOH, if there is a single hardware operation that does both
range-conversion and fixed-matrix, then there is no problem for a
driver to translate the pair of colorops into hardware configuration.
So it sounds like they should be defined as separate colorops, and then
drivers usually expose them together. Unless the hardware cannot do all
combinations of their values.


Thanks,
pq

> Uma please weigh in if you have something to add or disagree with.
> 
> ==
> Chaitanya
> 
> [1] https://gitlab.freedesktop.org/hwentland/linux/-/commits/csc-colorop
> 

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-03-17 14:10 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06 16:52 [PATCH 00/10] drm/i915/color: Enable SDR plane color pipeline Chaitanya Kumar Borah
2026-03-06 16:52 ` [PATCH 01/10] drm/colorop: Add DRM_COLOROP_CSC_FF Chaitanya Kumar Borah
2026-03-10 14:32   ` Pekka Paalanen
2026-03-16  7:16     ` Borah, Chaitanya Kumar
2026-03-16  8:57       ` Pekka Paalanen
2026-03-16 10:34         ` Borah, Chaitanya Kumar
2026-03-16 11:53           ` Pekka Paalanen
2026-03-16 14:36             ` Harry Wentland
2026-03-16 16:03               ` Pekka Paalanen
2026-03-16 17:59                 ` Harry Wentland
2026-03-17  8:23                   ` Pekka Paalanen
2026-03-30 15:37                   ` Harry Wentland
2026-03-11  8:49   ` Jani Nikula
2026-03-16 20:45   ` Harry Wentland
2026-03-17 12:29     ` Borah, Chaitanya Kumar
2026-03-17 14:09       ` Pekka Paalanen [this message]
2026-03-06 16:52 ` [PATCH 02/10] drm/i915/color: Add CSC on SDR plane color pipeline Chaitanya Kumar Borah
2026-03-06 16:53 ` [PATCH 03/10] drm/i915/color: Program fixed-function CSC on SDR planes Chaitanya Kumar Borah
2026-03-06 16:53 ` [PATCH 04/10] drm/i915/color: Add support for 1D LUT in " Chaitanya Kumar Borah
2026-03-06 16:53 ` [PATCH 05/10] drm/i915/color: Fix HDR pre-CSC LUT programming loop Chaitanya Kumar Borah
2026-03-06 16:53 ` [PATCH 06/10] drm/i915/color: Extract HDR pre-CSC LUT programming to helper function Chaitanya Kumar Borah
2026-03-06 16:53 ` [PATCH 07/10] drm/i915/color: Program Pre-CSC registers for SDR Chaitanya Kumar Borah
2026-03-06 16:53 ` [PATCH 08/10] drm/i915/color: Extract HDR post-CSC LUT programming to helper function Chaitanya Kumar Borah
2026-03-06 16:53 ` [PATCH 09/10] drm/i915/color: Program Plane Post CSC registers for SDR planes Chaitanya Kumar Borah
2026-03-06 16:53 ` [PATCH 10/10] drm/i915/color: Add color pipeline support " Chaitanya Kumar Borah
2026-03-07  2:40 ` ✓ CI.KUnit: success for drm/i915/color: Enable SDR plane color pipeline Patchwork
2026-03-07  3:25 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-08  6:17 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260317160951.407ee82a@eldfell \
    --to=pekka.paalanen@collabora.com \
    --cc=alex.hung@amd.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=contact@emersion.fr \
    --cc=daniels@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=maarten.lankhorst@intel.com \
    --cc=mwen@igalia.com \
    --cc=pranay.samala@intel.com \
    --cc=swati2.sharma@intel.com \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox