public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Shuicheng Lin <shuicheng.lin@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Shuicheng Lin <shuicheng.lin@intel.com>
Subject: [PATCH 0/5] drm/xe: Fix mismatched include guards in header files
Date: Tue, 17 Mar 2026 21:57:16 +0000	[thread overview]
Message-ID: <20260317215732.2208976-7-shuicheng.lin@intel.com> (raw)

Mostly generated by AI and reviewed to confirm the change is correct.


Audit and normalize include guards across 24 xe driver headers to follow
the dominant _XE_<BASENAME>_H_ convention used by ~232 of ~260 xe headers.

The series is organized from most severe to least:

1. Add missing include guards to 2 completely unprotected headers
   (xe_dep_scheduler.h, xe_pcode_api.h) that could cause duplicate
   definition errors on multiple inclusion.
2. Add missing _H suffix to 10 headers using _XE_<NAME>_ guards.
3. Add missing trailing underscore to 4 headers using _XE_<NAME>_H.
4. Add missing leading underscore to 2 headers using XE_<NAME>_H_.
5. Normalize 6 headers from __XE_<NAME>_H__ double-underscore style
   to single-underscore, avoiding C reserved identifiers (C11 §7.1.3).

No functional changes. Compile-tested only.

Shuicheng Lin (5):
  drm/xe: Add missing include guards to unprotected headers
  drm/xe: Add missing _H to include guard suffixes
  drm/xe: Add missing trailing underscore to include guards
  drm/xe: Add missing leading underscore to include guards
  drm/xe: Normalize double-underscore include guards to
    single-underscore

 drivers/gpu/drm/xe/xe_dep_scheduler.h     | 5 +++++
 drivers/gpu/drm/xe/xe_drm_ras.h           | 4 ++--
 drivers/gpu/drm/xe/xe_eu_stall.h          | 4 ++--
 drivers/gpu/drm/xe/xe_guc_capture.h       | 4 ++--
 drivers/gpu/drm/xe/xe_guc_capture_types.h | 4 ++--
 drivers/gpu/drm/xe/xe_guc_fwif.h          | 4 ++--
 drivers/gpu/drm/xe/xe_hw_error.h          | 4 ++--
 drivers/gpu/drm/xe/xe_migrate.h           | 4 ++--
 drivers/gpu/drm/xe/xe_nvm.h               | 4 ++--
 drivers/gpu/drm/xe/xe_pcode_api.h         | 5 +++++
 drivers/gpu/drm/xe/xe_pt_walk.h           | 4 ++--
 drivers/gpu/drm/xe/xe_pxp.h               | 6 +++---
 drivers/gpu/drm/xe/xe_pxp_debugfs.h       | 6 +++---
 drivers/gpu/drm/xe/xe_pxp_submit.h        | 6 +++---
 drivers/gpu/drm/xe/xe_pxp_types.h         | 6 +++---
 drivers/gpu/drm/xe/xe_reg_sr.h            | 4 ++--
 drivers/gpu/drm/xe/xe_reg_sr_types.h      | 4 ++--
 drivers/gpu/drm/xe/xe_reg_whitelist.h     | 4 ++--
 drivers/gpu/drm/xe/xe_rtp.h               | 4 ++--
 drivers/gpu/drm/xe/xe_rtp_helpers.h       | 4 ++--
 drivers/gpu/drm/xe/xe_rtp_types.h         | 4 ++--
 drivers/gpu/drm/xe/xe_tuning.h            | 4 ++--
 drivers/gpu/drm/xe/xe_uc_fw_abi.h         | 4 ++--
 drivers/gpu/drm/xe/xe_wa.h                | 4 ++--
 24 files changed, 58 insertions(+), 48 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-03-17 22:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 21:57 Shuicheng Lin [this message]
2026-03-17 21:57 ` [PATCH 1/5] drm/xe: Add missing include guards to unprotected headers Shuicheng Lin
2026-03-30  7:14   ` Gote, Nitin R
2026-03-17 21:57 ` [PATCH 2/5] drm/xe: Add missing _H to include guard suffixes Shuicheng Lin
2026-03-30  7:16   ` Gote, Nitin R
2026-03-17 21:57 ` [PATCH 3/5] drm/xe: Add missing trailing underscore to include guards Shuicheng Lin
2026-03-30  7:18   ` Gote, Nitin R
2026-03-17 21:57 ` [PATCH 4/5] drm/xe: Add missing leading " Shuicheng Lin
2026-03-30  7:19   ` Gote, Nitin R
2026-03-17 21:57 ` [PATCH 5/5] drm/xe: Normalize double-underscore include guards to single-underscore Shuicheng Lin
2026-03-30  7:21   ` Gote, Nitin R
2026-03-30  8:31     ` Simon Richter
2026-03-30 10:17       ` Jani Nikula
2026-03-31 16:31         ` Lin, Shuicheng
2026-03-17 22:06 ` ✗ CI.checkpatch: warning for drm/xe: Fix mismatched include guards in header files (rev2) Patchwork
2026-03-17 22:08 ` ✓ CI.KUnit: success " Patchwork
2026-03-17 22:51 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-19  9:30 ` ✓ Xe.CI.FULL: " Patchwork
2026-04-06 16:07   ` Lin, Shuicheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260317215732.2208976-7-shuicheng.lin@intel.com \
    --to=shuicheng.lin@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox