public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Shuicheng Lin <shuicheng.lin@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Shuicheng Lin <shuicheng.lin@intel.com>,
	Nitin Gote <nitin.r.gote@intel.com>
Subject: [PATCH 1/5] drm/xe: Add missing include guards to unprotected headers
Date: Tue, 17 Mar 2026 21:57:17 +0000	[thread overview]
Message-ID: <20260317215732.2208976-8-shuicheng.lin@intel.com> (raw)
In-Reply-To: <20260317215732.2208976-7-shuicheng.lin@intel.com>

Two headers lack include guards entirely, which can cause duplicate
definition errors if they are included more than once (directly or
transitively).

Add standard _XE_<NAME>_H_ include guards to:
  - xe_dep_scheduler.h: forward declarations and function prototypes
  - xe_pcode_api.h: PCODE mailbox register definitions

No functional change.

Suggested-by: Nitin Gote <nitin.r.gote@intel.com>
Assisted-by: GitHub Copilot:claude-opus-4.6
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
---
 drivers/gpu/drm/xe/xe_dep_scheduler.h | 5 +++++
 drivers/gpu/drm/xe/xe_pcode_api.h     | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_dep_scheduler.h b/drivers/gpu/drm/xe/xe_dep_scheduler.h
index 853961eec64b..f314fb5d80f5 100644
--- a/drivers/gpu/drm/xe/xe_dep_scheduler.h
+++ b/drivers/gpu/drm/xe/xe_dep_scheduler.h
@@ -3,6 +3,9 @@
  * Copyright © 2025 Intel Corporation
  */
 
+#ifndef _XE_DEP_SCHEDULER_H_
+#define _XE_DEP_SCHEDULER_H_
+
 #include <linux/types.h>
 
 struct drm_sched_entity;
@@ -19,3 +22,5 @@ void xe_dep_scheduler_fini(struct xe_dep_scheduler *dep_scheduler);
 
 struct drm_sched_entity *
 xe_dep_scheduler_entity(struct xe_dep_scheduler *dep_scheduler);
+
+#endif
diff --git a/drivers/gpu/drm/xe/xe_pcode_api.h b/drivers/gpu/drm/xe/xe_pcode_api.h
index 85cc7478b787..b619030b9e17 100644
--- a/drivers/gpu/drm/xe/xe_pcode_api.h
+++ b/drivers/gpu/drm/xe/xe_pcode_api.h
@@ -3,6 +3,9 @@
  * Copyright © 2022 Intel Corporation
  */
 
+#ifndef _XE_PCODE_API_H_
+#define _XE_PCODE_API_H_
+
 /* Internal to xe_pcode */
 
 #include "regs/xe_reg_defs.h"
@@ -101,3 +104,5 @@
 #define BMG_PCIE_CAP			XE_REG(0x138340)
 #define   LINK_DOWNGRADE		REG_GENMASK(1, 0)
 #define     DOWNGRADE_CAPABLE		2
+
+#endif
-- 
2.43.0


  reply	other threads:[~2026-03-17 22:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 21:57 [PATCH 0/5] drm/xe: Fix mismatched include guards in header files Shuicheng Lin
2026-03-17 21:57 ` Shuicheng Lin [this message]
2026-03-30  7:14   ` [PATCH 1/5] drm/xe: Add missing include guards to unprotected headers Gote, Nitin R
2026-03-17 21:57 ` [PATCH 2/5] drm/xe: Add missing _H to include guard suffixes Shuicheng Lin
2026-03-30  7:16   ` Gote, Nitin R
2026-03-17 21:57 ` [PATCH 3/5] drm/xe: Add missing trailing underscore to include guards Shuicheng Lin
2026-03-30  7:18   ` Gote, Nitin R
2026-03-17 21:57 ` [PATCH 4/5] drm/xe: Add missing leading " Shuicheng Lin
2026-03-30  7:19   ` Gote, Nitin R
2026-03-17 21:57 ` [PATCH 5/5] drm/xe: Normalize double-underscore include guards to single-underscore Shuicheng Lin
2026-03-30  7:21   ` Gote, Nitin R
2026-03-30  8:31     ` Simon Richter
2026-03-30 10:17       ` Jani Nikula
2026-03-31 16:31         ` Lin, Shuicheng
2026-03-17 22:06 ` ✗ CI.checkpatch: warning for drm/xe: Fix mismatched include guards in header files (rev2) Patchwork
2026-03-17 22:08 ` ✓ CI.KUnit: success " Patchwork
2026-03-17 22:51 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-19  9:30 ` ✓ Xe.CI.FULL: " Patchwork
2026-04-06 16:07   ` Lin, Shuicheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260317215732.2208976-8-shuicheng.lin@intel.com \
    --to=shuicheng.lin@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=nitin.r.gote@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox