Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nemesa Garg <nemesa.garg@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Nemesa Garg <nemesa.garg@intel.com>,
	Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 1/3] drm/i915/display: Move casf_compute_config
Date: Thu, 26 Mar 2026 17:30:27 +0530	[thread overview]
Message-ID: <20260326120029.3409676-2-nemesa.garg@intel.com> (raw)
In-Reply-To: <20260326120029.3409676-1-nemesa.garg@intel.com>

Prefill calculations are getting screwed up as casf_compute is getting
called in later stage. So move casf_compute_config to crtc_compute
config and check if there is a change in the sharpness strength, if so
set the flag uapi.mode_changed so that everytime when strength changes
casf_compute_config can be called and new strength value gets updated.

v2: Remove extra casf_check [Ville]
v3: Wrap commit message uto 75 [Ankit]

Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 10b6c6fcb03f..29c165bd8960 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -2516,6 +2516,10 @@ static int intel_crtc_compute_config(struct intel_atomic_state *state,
 
 	intel_vrr_compute_guardband(crtc_state);
 
+	ret = intel_casf_compute_config(crtc_state);
+	if (ret)
+		return ret;
+
 	return 0;
 }
 
@@ -4308,10 +4312,6 @@ static int intel_crtc_atomic_check(struct intel_atomic_state *state,
 		return ret;
 	}
 
-	ret = intel_casf_compute_config(crtc_state);
-	if (ret)
-		return ret;
-
 	if (DISPLAY_VER(display) >= 9) {
 		if (intel_crtc_needs_modeset(crtc_state) ||
 		    intel_crtc_needs_fastset(crtc_state) ||
@@ -6441,6 +6441,10 @@ int intel_atomic_check(struct drm_device *dev,
 		if (new_crtc_state->uapi.scaling_filter !=
 		    old_crtc_state->uapi.scaling_filter)
 			new_crtc_state->uapi.mode_changed = true;
+
+		if (new_crtc_state->uapi.sharpness_strength !=
+		    old_crtc_state->uapi.sharpness_strength)
+			new_crtc_state->uapi.mode_changed = true;
 	}
 
 	intel_vrr_check_modeset(state);
-- 
2.25.1


  reply	other threads:[~2026-03-26 12:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 12:00 [PATCH 0/3] Make casf updates atomic and dsb ready Nemesa Garg
2026-03-26 12:00 ` Nemesa Garg [this message]
2026-03-26 12:00 ` [PATCH 2/3] drm/i915/display: Introduce skl_pipe_scaler_setup() Nemesa Garg
2026-03-26 12:00 ` [PATCH 3/3] drm/i915/display: Common wrapper for casf and pfit Nemesa Garg
2026-03-26 12:11 ` ✓ CI.KUnit: success for Make casf updates atomic and dsb ready (rev3) Patchwork
2026-03-26 12:51 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-03-27  2:28 ` ✓ Xe.CI.FULL: success " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2025-12-23  8:12 [PATCH 0/3] Make casf updates atomic and dsb ready Nemesa Garg
2025-12-23  8:12 ` [PATCH 1/3] drm/i915/display: Move casf_compute_config Nemesa Garg
2026-03-12  3:13   ` Nautiyal, Ankit K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260326120029.3409676-2-nemesa.garg@intel.com \
    --to=nemesa.garg@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox