From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, Jani Nikula <jani.nikula@intel.com>
Subject: [PATCH v2 01/12] drm/i915/qgv: Use intel_de_read() for MTL_MEM_SS_INFO* reads
Date: Tue, 31 Mar 2026 18:42:48 +0300 [thread overview]
Message-ID: <20260331154259.24600-2-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20260331154259.24600-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
The MTL_MEM_SS_INFO* are just regular display registers. Use
intel_de_read() to access them.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_bw.c | 6 +++---
drivers/gpu/drm/i915/display/intel_dram.c | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
index 07b4531a4376..18b80147ddc7 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -9,6 +9,7 @@
#include "intel_bw.h"
#include "intel_crtc.h"
+#include "intel_de.h"
#include "intel_display_core.h"
#include "intel_display_regs.h"
#include "intel_display_types.h"
@@ -211,12 +212,11 @@ static int icl_pcode_restrict_qgv_points(struct intel_display *display,
static int mtl_read_qgv_point_info(struct intel_display *display,
struct intel_qgv_point *sp, int point)
{
- struct intel_uncore *uncore = to_intel_uncore(display->drm);
u32 val, val2;
u16 dclk;
- val = intel_uncore_read(uncore, MTL_MEM_SS_INFO_QGV_POINT_LOW(point));
- val2 = intel_uncore_read(uncore, MTL_MEM_SS_INFO_QGV_POINT_HIGH(point));
+ val = intel_de_read(display, MTL_MEM_SS_INFO_QGV_POINT_LOW(point));
+ val2 = intel_de_read(display, MTL_MEM_SS_INFO_QGV_POINT_HIGH(point));
dclk = REG_FIELD_GET(MTL_DCLK_MASK, val);
sp->dclk = DIV_ROUND_CLOSEST(16667 * dclk, 1000);
sp->t_rp = REG_FIELD_GET(MTL_TRP_MASK, val);
diff --git a/drivers/gpu/drm/i915/display/intel_dram.c b/drivers/gpu/drm/i915/display/intel_dram.c
index bd281d4b4c05..f05796417485 100644
--- a/drivers/gpu/drm/i915/display/intel_dram.c
+++ b/drivers/gpu/drm/i915/display/intel_dram.c
@@ -9,6 +9,7 @@
#include <drm/drm_print.h>
#include <drm/intel/intel_pcode_regs.h>
+#include "intel_de.h"
#include "intel_display_core.h"
#include "intel_display_utils.h"
#include "intel_display_regs.h"
@@ -767,8 +768,7 @@ static int gen12_get_dram_info(struct intel_display *display, struct dram_info *
static int xelpdp_get_dram_info(struct intel_display *display, struct dram_info *dram_info)
{
- struct intel_uncore *uncore = to_intel_uncore(display->drm);
- u32 val = intel_uncore_read(uncore, MTL_MEM_SS_INFO_GLOBAL);
+ u32 val = intel_de_read(display, MTL_MEM_SS_INFO_GLOBAL);
switch (REG_FIELD_GET(MTL_DDR_TYPE_MASK, val)) {
case 0:
--
2.52.0
next prev parent reply other threads:[~2026-03-31 15:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 15:42 [PATCH v2 00/12] drm/i915: More uncore nukage from display code Ville Syrjala
2026-03-31 15:42 ` Ville Syrjala [this message]
2026-03-31 15:42 ` [PATCH v2 02/12] drm/i915/mchbar: Provide intel_mchbar_read*() abstraction Ville Syrjala
2026-03-31 15:42 ` [PATCH v2 03/12] drm/i915/mchbar: Define the end of the MCHBAR mirror Ville Syrjala
2026-03-31 15:42 ` [PATCH v2 04/12] drm/i915/mchbar: WARN when accessing non-MCHBAR registers via intel_mchbar_read*() Ville Syrjala
2026-03-31 15:42 ` [PATCH v2 05/12] drm/i915/mchbar: Use intel_mchbar_read() instead of intel_de_read() Ville Syrjala
2026-03-31 15:42 ` [PATCH v2 06/12] drm/i915/mchbar: Use intel_mchbar_read*() instead of intel_uncore_read*() Ville Syrjala
2026-03-31 15:42 ` [PATCH v2 07/12] drm/i915/de: Add intel_de_read16() Ville Syrjala
2026-03-31 15:42 ` [PATCH v2 08/12] drm/i915/de: s/intel_de_read64_2x32()/intel_de_read64_2x32_volatile()/ Ville Syrjala
2026-03-31 15:42 ` [PATCH v2 09/12] drm/i915/de: Add a simple intel_de_read64_2x32() Ville Syrjala
2026-03-31 15:42 ` [PATCH v2 10/12] drm/i915/vrr: Use intel_de_read64_2x32() Ville Syrjala
2026-03-31 15:42 ` [PATCH v2 11/12] drm/i915/mchbar: Use intel_de_read*() for MCHBAR register accesses Ville Syrjala
2026-03-31 15:42 ` [PATCH v2 12/12] drm/i915/rom: Use intel_de for SPI ROM register access Ville Syrjala
2026-03-31 16:41 ` ✗ CI.checkpatch: warning for drm/i915: More uncore nukage from display code (rev3) Patchwork
2026-03-31 16:42 ` ✓ CI.KUnit: success " Patchwork
2026-03-31 17:16 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-31 22:36 ` ✓ Xe.CI.FULL: " Patchwork
2026-04-01 13:16 ` [PATCH v2 00/12] drm/i915: More uncore nukage from display code Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331154259.24600-2-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox