* [PATCH] drm/xe/vm: Add missing pad and extensions check
@ 2026-03-31 16:44 Jonathan Cavitt
2026-03-31 16:48 ` Matthew Auld
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Cavitt @ 2026-03-31 16:44 UTC (permalink / raw)
To: intel-xe; +Cc: saurabhg.gupta, alex.zuo, jonathan.cavitt, matthew.auld
Add missing pad and extensions check to xe_vm_get_property_ioctl
Fixes: 50c577eab051 ("drm/xe/xe_vm: Implement xe_vm_get_property_ioctl")
Suggested-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
drivers/gpu/drm/xe/xe_vm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 56e2db50bb36..03f129927b0f 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -4159,6 +4159,9 @@ int xe_vm_get_property_ioctl(struct drm_device *drm, void *data,
args->reserved[2])))
return -EINVAL;
+ if (XE_IOCTL_DBG(xe, args->pad || args->extensions))
+ return -EINVAL;
+
vm = xe_vm_lookup(xef, args->vm_id);
if (XE_IOCTL_DBG(xe, !vm))
return -ENOENT;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/xe/vm: Add missing pad and extensions check
2026-03-31 16:44 [PATCH] drm/xe/vm: Add missing pad and extensions check Jonathan Cavitt
@ 2026-03-31 16:48 ` Matthew Auld
0 siblings, 0 replies; 2+ messages in thread
From: Matthew Auld @ 2026-03-31 16:48 UTC (permalink / raw)
To: Jonathan Cavitt, intel-xe; +Cc: saurabhg.gupta, alex.zuo
On 31/03/2026 17:44, Jonathan Cavitt wrote:
> Add missing pad and extensions check to xe_vm_get_property_ioctl
>
> Fixes: 50c577eab051 ("drm/xe/xe_vm: Implement xe_vm_get_property_ioctl")
> Suggested-by: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Would it make sense to combine this with the other reserved checks?
Either way:
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
> ---
> drivers/gpu/drm/xe/xe_vm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 56e2db50bb36..03f129927b0f 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -4159,6 +4159,9 @@ int xe_vm_get_property_ioctl(struct drm_device *drm, void *data,
> args->reserved[2])))
> return -EINVAL;
>
> + if (XE_IOCTL_DBG(xe, args->pad || args->extensions))
> + return -EINVAL;
> +
> vm = xe_vm_lookup(xef, args->vm_id);
> if (XE_IOCTL_DBG(xe, !vm))
> return -ENOENT;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-31 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-31 16:44 [PATCH] drm/xe/vm: Add missing pad and extensions check Jonathan Cavitt
2026-03-31 16:48 ` Matthew Auld
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox