From: Shuicheng Lin <shuicheng.lin@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Shuicheng Lin <shuicheng.lin@intel.com>,
Riana Tauro <riana.tauro@intel.com>
Subject: [PATCH 2/2] drm/xe/ras: Clean up coding style in xe_drm_ras
Date: Tue, 7 Apr 2026 22:59:13 +0000 [thread overview]
Message-ID: <20260407225913.3397059-3-shuicheng.lin@intel.com> (raw)
In-Reply-To: <20260407225913.3397059-1-shuicheng.lin@intel.com>
- Fix long line in cleanup_node_param() signature.
- Drop unnecessary const on pass-by-value enum parameters.
- Simplify xe_drm_ras_init() by removing redundant local variable
and redundant error path.
No functional change.
Cc: Riana Tauro <riana.tauro@intel.com>
Assisted-by: Claude:claude-opus-4.6
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
---
drivers/gpu/drm/xe/xe_drm_ras.c | 19 ++++++++-----------
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_drm_ras.c b/drivers/gpu/drm/xe/xe_drm_ras.c
index 802e4bcb731c..9cddad2be549 100644
--- a/drivers/gpu/drm/xe/xe_drm_ras.c
+++ b/drivers/gpu/drm/xe/xe_drm_ras.c
@@ -68,7 +68,7 @@ static struct xe_drm_ras_counter *allocate_and_copy_counters(struct xe_device *x
}
static int assign_node_params(struct xe_device *xe, struct drm_ras_node *node,
- const enum drm_xe_ras_error_severity severity)
+ enum drm_xe_ras_error_severity severity)
{
struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
struct xe_drm_ras *ras = &xe->ras;
@@ -109,7 +109,8 @@ static int assign_node_params(struct xe_device *xe, struct drm_ras_node *node,
return ret;
}
-static void cleanup_node_param(struct xe_drm_ras *ras, const enum drm_xe_ras_error_severity severity)
+static void cleanup_node_param(struct xe_drm_ras *ras,
+ enum drm_xe_ras_error_severity severity)
{
struct drm_ras_node *node = &ras->node[severity];
@@ -174,15 +175,13 @@ static void xe_drm_ras_unregister_nodes(struct drm_device *device, void *arg)
int xe_drm_ras_init(struct xe_device *xe)
{
struct xe_drm_ras *ras = &xe->ras;
- struct drm_ras_node *node;
int err;
- node = drmm_kcalloc(&xe->drm, DRM_XE_RAS_ERR_SEV_MAX, sizeof(*node), GFP_KERNEL);
- if (!node)
+ ras->node = drmm_kcalloc(&xe->drm, DRM_XE_RAS_ERR_SEV_MAX,
+ sizeof(*ras->node), GFP_KERNEL);
+ if (!ras->node)
return -ENOMEM;
- ras->node = node;
-
err = register_nodes(xe);
if (err) {
drm_err(&xe->drm, "Failed to register DRM RAS nodes (%pe)\n", ERR_PTR(err));
@@ -190,10 +189,8 @@ int xe_drm_ras_init(struct xe_device *xe)
}
err = drmm_add_action_or_reset(&xe->drm, xe_drm_ras_unregister_nodes, xe);
- if (err) {
+ if (err)
drm_err(&xe->drm, "Failed to add action for Xe DRM RAS (%pe)\n", ERR_PTR(err));
- return err;
- }
- return 0;
+ return err;
}
--
2.43.0
next prev parent reply other threads:[~2026-04-07 23:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 22:59 [PATCH 0/2] drm/xe/ras: Fix and clean up xe_drm_ras Shuicheng Lin
2026-04-07 22:59 ` [PATCH 1/2] drm/xe/ras: Fix error handling in register_nodes() Shuicheng Lin
2026-04-11 4:46 ` Nguyen, Brian3
2026-04-13 4:39 ` Tauro, Riana
2026-04-14 0:15 ` Lin, Shuicheng
2026-04-14 4:27 ` Tauro, Riana
2026-04-11 7:56 ` Raag Jadav
2026-04-14 0:30 ` Lin, Shuicheng
2026-04-14 4:30 ` Tauro, Riana
2026-04-07 22:59 ` Shuicheng Lin [this message]
2026-04-11 4:54 ` [PATCH 2/2] drm/xe/ras: Clean up coding style in xe_drm_ras Nguyen, Brian3
2026-04-13 4:46 ` Tauro, Riana
2026-04-14 0:27 ` Lin, Shuicheng
2026-04-14 4:33 ` Tauro, Riana
2026-04-11 7:58 ` Raag Jadav
2026-04-07 23:09 ` ✗ CI.checkpatch: warning for drm/xe/ras: Fix and clean up xe_drm_ras Patchwork
2026-04-07 23:10 ` ✗ CI.KUnit: failure " Patchwork
2026-04-10 3:55 ` ✗ CI.checkpatch: warning for drm/xe/ras: Fix and clean up xe_drm_ras (rev2) Patchwork
2026-04-10 3:56 ` ✓ CI.KUnit: success " Patchwork
2026-04-10 4:32 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-10 10:41 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260407225913.3397059-3-shuicheng.lin@intel.com \
--to=shuicheng.lin@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=riana.tauro@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox