public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/ttm/tests: fix lru_count ASSERT
@ 2026-04-09 12:15 Matthew Auld
  2026-04-09 12:15 ` [PATCH 2/2] drm/ttm/tests: make no_dma_alloc conditional on x86 Matthew Auld
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Matthew Auld @ 2026-04-09 12:15 UTC (permalink / raw)
  To: intel-xe
  Cc: dri-devel, Matthew Brost, Christian Koenig, Dave Airlie,
	Ryszard Knop

On pool init we should expect the lru_count for each node to be zeroed
as per __list_lru_init -> init_one_lru, but here we are asserting the
opposite.

Currently our CI is blowing up with:

10:23:33] # ttm_device_init_pools: ASSERTION FAILED at drivers/gpu/drm/ttm/tests/ttm_device_test.c:178
[10:23:33] Expected !list_lru_count(&pt.pages) to be false, but is true
[10:23:33] [FAILED] DMA allocations, DMA32 required
[10:23:33] [PASSED] No DMA allocations, DMA32 required
[10:23:33]     # ttm_device_init_pools: ASSERTION FAILED at drivers/gpu/drm/ttm/tests/ttm_device_test.c:178
[10:23:33]     Expected !list_lru_count(&pt.pages) to be false, but is true

Fixes: 444e2a19d7fd ("ttm/pool: port to list_lru. (v2)")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Christian Koenig <christian.koenig@amd.com>
Cc: Dave Airlie <airlied@redhat.com>
Reviewed-by: Ryszard Knop <ryszard.knop@intel.com>
---
 drivers/gpu/drm/ttm/tests/ttm_device_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/ttm/tests/ttm_device_test.c b/drivers/gpu/drm/ttm/tests/ttm_device_test.c
index db4b4a09a73f..8bcac84e9846 100644
--- a/drivers/gpu/drm/ttm/tests/ttm_device_test.c
+++ b/drivers/gpu/drm/ttm/tests/ttm_device_test.c
@@ -176,7 +176,7 @@ static void ttm_device_init_pools(struct kunit *test)
 
 				if (ttm_pool_uses_dma_alloc(pool))
 					KUNIT_ASSERT_FALSE(test,
-							   !list_lru_count(&pt.pages));
+							   list_lru_count(&pt.pages));
 			}
 		}
 	}
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-04-09 14:07 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-09 12:15 [PATCH 1/2] drm/ttm/tests: fix lru_count ASSERT Matthew Auld
2026-04-09 12:15 ` [PATCH 2/2] drm/ttm/tests: make no_dma_alloc conditional on x86 Matthew Auld
2026-04-09 14:07   ` Knop, Ryszard
2026-04-09 12:21 ` ✗ CI.checkpatch: warning for series starting with [1/2] drm/ttm/tests: fix lru_count ASSERT Patchwork
2026-04-09 12:22 ` ✓ CI.KUnit: success " Patchwork
2026-04-09 12:59 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-09 13:57 ` ✓ Xe.CI.FULL: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox