From: Xin Wang <x.wang@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Xin Wang <x.wang@intel.com>, Matthew Auld <matthew.auld@intel.com>
Subject: [PATCH v3 0/3] drm/xe/pat: Type cleanup and invalid index hardening
Date: Tue, 14 Apr 2026 14:14:50 -0700 [thread overview]
Message-ID: <20260414211453.303679-1-x.wang@intel.com> (raw)
Small follow-up series to harden the PAT subsystem:
Patch 1 fixes two remaining spots where pat_index was typed as u32/int
instead of u16, aligning with the rest of the driver.
Patch 2 defaults XE_CACHE_NONE_COMPRESSION to XE_PAT_INVALID_IDX (like
WB_COMPRESSION already does).
Patch 3 introduces xe_cache_pat_idx(), an inline helper that validates
cache_mode bounds and checks for XE_PAT_INVALID_IDX before returning the
PAT index. All 20 pat.idx[] read sites across the driver are converted.
Suggested-by: Matthew Auld <matthew.auld@intel.com>
v3:
- Rebased on latest drm-tip
v2:
- Dropped xe_assert() guards from xe_migrate that were added in v1 patch 2;
the new helper in patch 3 now provides the same coverage uniformly across
all call sites (Matthew Auld)
- New patch 3: xe_cache_pat_idx() helper with xe_assert() for every
pat.idx[] read access, including bounds check on cache_mode
Xin Wang (3):
drm/xe: Standardize pat_index to u16 type
drm/xe/pat: Default XE_CACHE_NONE_COMPRESSION to invalid
drm/xe/pat: Introduce xe_cache_pat_idx() helper
drivers/gpu/drm/xe/display/xe_fb_pin.c | 11 ++++++-----
drivers/gpu/drm/xe/tests/xe_migrate.c | 3 ++-
drivers/gpu/drm/xe/xe_device_types.h | 2 +-
drivers/gpu/drm/xe/xe_ggtt.c | 7 ++++---
drivers/gpu/drm/xe/xe_migrate.c | 15 ++++++++-------
drivers/gpu/drm/xe/xe_pat.c | 1 +
drivers/gpu/drm/xe/xe_pat.h | 24 +++++++++++++++++++++++-
drivers/gpu/drm/xe/xe_pt.c | 3 ++-
drivers/gpu/drm/xe/xe_vm.c | 8 ++++----
9 files changed, 51 insertions(+), 23 deletions(-)
--
2.43.0
next reply other threads:[~2026-04-14 21:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 21:14 Xin Wang [this message]
2026-04-14 21:14 ` [PATCH v3 1/3] drm/xe: Standardize pat_index to u16 type Xin Wang
2026-04-14 21:14 ` [PATCH v3 2/3] drm/xe/pat: Default XE_CACHE_NONE_COMPRESSION to invalid Xin Wang
2026-04-14 21:14 ` [PATCH v3 3/3] drm/xe/pat: Introduce xe_cache_pat_idx() helper Xin Wang
2026-04-15 8:54 ` Matthew Auld
2026-04-15 9:12 ` Matthew Auld
2026-04-15 16:46 ` Wang, X
2026-04-14 21:39 ` ✓ CI.KUnit: success for drm/xe/pat: Type cleanup and invalid index hardening Patchwork
2026-04-14 22:37 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-14 23:26 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260414211453.303679-1-x.wang@intel.com \
--to=x.wang@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox