From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B74E2F8E4A7 for ; Fri, 17 Apr 2026 05:59:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7055710E954; Fri, 17 Apr 2026 05:59:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="G8gRsfFH"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8473910E248 for ; Fri, 17 Apr 2026 05:59:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776405570; x=1807941570; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=p2fTSOTy5ZihPPPKpmaCyROroOv/bJnN3bxaFGaMe78=; b=G8gRsfFHW3YXCMwlBI7uz4g86Opzom8YTu1HnTzz6Vh3g1aZXlNlMerm gA7N5p/bMy9bvW25ooJYPkNuapp+sPMVTqRHPl532nQdbWs8w1gH/Qm0/ v2S/eX94WXOX8AAiiE/cKY8N98fGB+W1lAlKRVm0Sfz2v0IYAFKsQNNIE 88ECU+ZsUb3q2eErHboRaLr1Am2z4nplunqBpSrDsAWm5b5VyB4uSy0GT xM1KmKx4lAfE99gMx1J6MdgGSMCNDPLaogv86nCTCCGPLDfwF060FI2VC /0o5eCWtj/Zv2xzXklvLcyXJUJYvL3/qefjZ/wcZRDBdwhCrl4m0TxkQ0 w==; X-CSE-ConnectionGUID: n4/V537zRsOONWLx8Uf7nA== X-CSE-MsgGUID: zsbrakr+S2yeWKiBp44ChQ== X-IronPort-AV: E=McAfee;i="6800,10657,11761"; a="102878739" X-IronPort-AV: E=Sophos;i="6.23,183,1770624000"; d="scan'208";a="102878739" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2026 22:59:27 -0700 X-CSE-ConnectionGUID: 9qUEiT18QqiHWjLuUtTpKw== X-CSE-MsgGUID: dRZ7DLlMT5i2Wuv307Jymw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,183,1770624000"; d="scan'208";a="230871837" Received: from dut6094bmgfrd.fm.intel.com ([10.80.55.31]) by orviesa008.jf.intel.com with ESMTP; 16 Apr 2026 22:59:27 -0700 From: Jia Yao To: intel-xe@lists.freedesktop.org Cc: Jia Yao , stable@vger.kernel.org, Shuicheng Lin , Mathew Alwin , Michal Mrozek , Matthew Brost , Matthew Auld Subject: [PATCH v10 2/2] drm/xe: Reject coh_none PAT index for CPU_ADDR_MIRROR Date: Fri, 17 Apr 2026 05:59:17 +0000 Message-ID: <20260417055917.2027459-3-jia.yao@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260417055917.2027459-1-jia.yao@intel.com> References: <20260417055917.2027459-1-jia.yao@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Add validation in xe_vm_bind_ioctl() to reject PAT indices with XE_COH_NONE coherency mode when used with DRM_XE_VM_BIND_FLAG_CPU_ADDR_MIRROR. CPU address mirror mappings use system memory that is CPU cached, which makes them incompatible with COH_NONE PAT indices. Allowing COH_NONE with CPU cached buffers is a security risk, as the GPU may bypass CPU caches and read stale sensitive data from DRAM. Although CPU_ADDR_MIRROR does not create an immediate mapping, the backing system memory is still CPU cached. Apply the same PAT coherency restrictions as DRM_XE_VM_BIND_OP_MAP_USERPTR. v2: - Correct fix tag v6: - No change v7: - Correct fix tag v8: - Rebase v9: - Limit the restrictions to iGPU v10: - Just add the iGPU logic but keep dGPU logic Fixes: b43e864af0d4 ("drm/xe/uapi: Add DRM_XE_VM_BIND_FLAG_CPU_ADDR_MIRROR") Cc: stable@vger.kernel.org # v6.18 Cc: Shuicheng Lin Cc: Mathew Alwin Cc: Michal Mrozek Cc: Matthew Brost Cc: Matthew Auld Signed-off-by: Jia Yao Reviewed-by: Matthew Auld --- drivers/gpu/drm/xe/xe_vm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c index 2408b547ca3d..1481dd53775d 100644 --- a/drivers/gpu/drm/xe/xe_vm.c +++ b/drivers/gpu/drm/xe/xe_vm.c @@ -3658,6 +3658,8 @@ static int vm_bind_ioctl_check_args(struct xe_device *xe, struct xe_vm *vm, op == DRM_XE_VM_BIND_OP_MAP_USERPTR) || XE_IOCTL_DBG(xe, coh_mode == XE_COH_NONE && op == DRM_XE_VM_BIND_OP_MAP_USERPTR) || + XE_IOCTL_DBG(xe, !IS_DGFX(xe) && coh_mode == XE_COH_NONE && + is_cpu_addr_mirror) || XE_IOCTL_DBG(xe, xe_device_is_l2_flush_optimized(xe) && (op == DRM_XE_VM_BIND_OP_MAP_USERPTR || is_cpu_addr_mirror) && -- 2.43.0