From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64DA7F5580A for ; Mon, 20 Apr 2026 10:37:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 22D4310E4E9; Mon, 20 Apr 2026 10:37:42 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="jYoVr1ct"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id D446E10E4EC; Mon, 20 Apr 2026 10:37:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776681461; x=1808217461; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rLn4uwq0Z6Dkurd9ycSsqd5BcvhyVoUQr+IvpPJjRGE=; b=jYoVr1cttp3vdMjwuWEWK9+TqwtyYyHbqfySghfKJO0mCDE/jPqt37pE Q34pyRrnG8kYSru6ynTvxIqlWCpTZCuXqqD1YKxqQ6CY8b9mvHitiUmGu 0T4J+nQSOTtWXIR81/yPI4xc0KmyCsgtY5P6yiOrCgGEibuo7en/Ox5Xs Q6pCd2ICJoeK4TLBOfSM3YwrbGd6Ipo4Kk+w7Dr1O0Pco6Unt3emnm7fR ZD34PH2LOvbwv4LtKAX4yQ6OP6nLOuzN/rGQUoCPeaxdJ1AG/AAy5/2sM hZJuHSl2a1+2rm9Q38XsbysQ0WSsFarys1FAA2g58B4WpheP8SoipmC0u g==; X-CSE-ConnectionGUID: z0wuEaqJTCOjSRgQLaDVPA== X-CSE-MsgGUID: r3xU68v4T6e5drAuYQuJ1Q== X-IronPort-AV: E=McAfee;i="6800,10657,11762"; a="81464761" X-IronPort-AV: E=Sophos;i="6.23,189,1770624000"; d="scan'208";a="81464761" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2026 03:37:41 -0700 X-CSE-ConnectionGUID: 61x9SuW6Q8yuzF5YznDuSA== X-CSE-MsgGUID: jMy9wwCaTPyRPHxhbQKSSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,189,1770624000"; d="scan'208";a="231554588" Received: from vpanait-mobl.ger.corp.intel.com (HELO hazy.intel.com) ([10.245.244.99]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2026 03:37:38 -0700 From: Luca Coelho To: intel-gfx@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org, jani.nikula@linux.intel.com, ville.syrjala@linux.intel.com Subject: [PATCH v3 8/8] drm/i915: remove HAS_PCH_NOP() dependency from clock gating Date: Mon, 20 Apr 2026 13:30:50 +0300 Message-ID: <20260420103705.3453499-9-luciano.coelho@intel.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260420103705.3453499-1-luciano.coelho@intel.com> References: <20260420103705.3453499-1-luciano.coelho@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" intel_pch_init_clock_gating() already handles unsupported PCH types, including PCH_NOP, by doing nothing. Drop the explicit HAS_PCH_NOP() check from the IVB clock gating path and always call the display helper directly. This removes one more direct dependency on display-side PCH macros from intel_clock_gating.c. Signed-off-by: Luca Coelho --- drivers/gpu/drm/i915/intel_clock_gating.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_clock_gating.c b/drivers/gpu/drm/i915/intel_clock_gating.c index 12559db84cf4..d185199c43b8 100644 --- a/drivers/gpu/drm/i915/intel_clock_gating.c +++ b/drivers/gpu/drm/i915/intel_clock_gating.c @@ -290,8 +290,7 @@ static void ivb_init_clock_gating(struct drm_i915_private *i915) intel_uncore_rmw(&i915->uncore, GEN6_MBCUNIT_SNPCR, GEN6_MBC_SNPCR_MASK, GEN6_MBC_SNPCR_MED); - if (!HAS_PCH_NOP(display)) - intel_pch_init_clock_gating(display); + intel_pch_init_clock_gating(display); gen6_check_mch_setup(i915); } -- 2.53.0