From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A623FF8862 for ; Mon, 27 Apr 2026 11:51:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1871510E6E4; Mon, 27 Apr 2026 11:51:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=permerror (0-bit key) header.d=shazbot.org header.i=@shazbot.org header.b="EoJ/eNa/"; dkim=permerror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="BcEsU73p"; dkim-atps=neutral X-Greylist: delayed 534 seconds by postgrey-1.36 at gabe; Fri, 24 Apr 2026 16:56:44 UTC Received: from fout-b1-smtp.messagingengine.com (fout-b1-smtp.messagingengine.com [202.12.124.144]) by gabe.freedesktop.org (Postfix) with ESMTPS id D532610E3F0 for ; Fri, 24 Apr 2026 16:56:44 +0000 (UTC) Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfout.stl.internal (Postfix) with ESMTP id 51AD51D000BC; Fri, 24 Apr 2026 12:47:49 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Fri, 24 Apr 2026 12:47:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shazbot.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1777049269; x=1777135669; bh=7Jd/Ldgk0Yk4g9VO8dVen6H3KA5tpa2J0W6BFBzbq3c=; b= EoJ/eNa/eezbMRB/mnmXbB8jLcH0ZXi22EkoUjlYQBjgNXO8evjCQI0AE5cNPFAr oOptOl6e7kyaN8nvmWux+5RijvbUasBpUj66Sk3maNCJfD2lfwd22UFSzg8BSJUU 9r4pK9moEtH95NKu4qrBMU+QeLvJBvCB2KmmU0ZBJYggenS5H8ox5ORG2pFPgday C46rktOgqdwSGnWdVCgfyTpvv7ybycknZaUJgBD+moe2woRNkmzwXsY4JwZ+pnOn +9aLaMCwKbQY5/CCe/e7r2Dlzm9fr4kie31jYTcHL5QKzj4LZj6s7DGOA6xs24Rg x791a5WTSDyOOOu0Ui4zoQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1777049269; x= 1777135669; bh=7Jd/Ldgk0Yk4g9VO8dVen6H3KA5tpa2J0W6BFBzbq3c=; b=B cEsU73pEG0Ar6OLfCDdyAkMDmYI1tN81ha1PZv5j+ocOUhrw4mHTYvNWb5NkiNxD S61QaE6K82j2ODZ2CqXXuPEu3CzDxutXoa2vaWnPVew9b342I7+HZMNf4GgFHbt4 KHuTiuiGSOLpkj2sPLzqrw0nwbnuhDM5/ruACzFgS3q6MyIuPQnd+5lsIUMQWTap NWZw+jmlSqZmlKVI4KUeU3qTNfijyXXSiNt3LTBVTHs5Jyp9242pk27qL9VbXFLq WxyoVe2pNMheeA9kmdxsWV8AM468b0cvshtpbUKVQHzSXbrhnlRH+4Sy4iOM/q3M OKip+KveWkzb76OIAaA2g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdejtdehhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfgjfhfogggtgfesthejredtredtvdenucfhrhhomheptehlvgigucgh ihhllhhirghmshhonhcuoegrlhgvgiesshhhrgiisghothdrohhrgheqnecuggftrfgrth htvghrnhepvdekfeejkedvudfhudfhteekudfgudeiteetvdeukedvheetvdekgfdugeev ueeunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hlvgigsehshhgriigsohhtrdhorhhgpdhnsggprhgtphhtthhopedutddpmhhouggvpehs mhhtphhouhhtpdhrtghpthhtohepiihhrghoghhuohhhrghnsehkhihlihhnohhsrdgtnh dprhgtphhtthhopehmihgthhgrlhdrfihinhhirghrshhkihesihhnthgvlhdrtghomhdp rhgtphhtthhopehkvhhmsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepih hnthgvlhdqgigvsehlihhsthhsrdhfrhgvvgguvghskhhtohhprdhorhhgpdhrtghpthht ohepjhhgghesiihivghpvgdrtggrpdhrtghpthhtohephihishhhrghihhesnhhvihguih grrdgtohhmpdhrtghpthhtohepshhkohhlohhthhhumhhthhhosehnvhhiughirgdrtgho mhdprhgtphhtthhopehkvghvihhnrdhtihgrnhesihhnthgvlhdrtghomhdprhgtphhtth hopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i03f14258:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Apr 2026 12:47:47 -0400 (EDT) Date: Fri, 24 Apr 2026 10:47:45 -0600 From: Alex Williamson To: zhaoguohan@kylinos.cn Cc: =?UTF-8?B?TWljaGHFgg==?= Winiarski , kvm@vger.kernel.org, intel-xe@lists.freedesktop.org, Jason Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , linux-kernel@vger.kernel.org, alex@shazbot.org Subject: Re: [PATCH] vfio/xe: avoid duplicate reset in xe_vfio_pci_reset_done Message-ID: <20260424104745.03cfcebe@shazbot.org> In-Reply-To: <20260424091719.58800-1-zhaoguohan@kylinos.cn> References: <20260424091719.58800-1-zhaoguohan@kylinos.cn> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Mon, 27 Apr 2026 11:51:53 +0000 X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 24 Apr 2026 17:17:19 +0800 zhaoguohan@kylinos.cn wrote: > From: GuoHan Zhao > > xe_vfio_pci_reset_done() sets deferred_reset and, when it manages to > acquire state_mutex itself, hands the cleanup off to > xe_vfio_pci_state_mutex_unlock(). > > That helper already clears deferred_reset and runs xe_vfio_pci_reset() > before dropping the mutex. Calling xe_vfio_pci_reset() again right > afterwards repeats the reset handling unnecessarily. > > Fixes: 1b81ed612e12 ("vfio/xe: Reorganize the init to decouple migration from reset") Change looks good to me, but the Fixes: attribution is wrong, this has been present since the original code in 1f5556ec8b9e ("vfio/xe: Add device specific vfio_pci driver variant for Intel graphics"). Thanks, Alex > Signed-off-by: GuoHan Zhao > --- > drivers/vfio/pci/xe/main.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/vfio/pci/xe/main.c b/drivers/vfio/pci/xe/main.c > index 4ecadbbfd86e..cbff5af385ef 100644 > --- a/drivers/vfio/pci/xe/main.c > +++ b/drivers/vfio/pci/xe/main.c > @@ -135,8 +135,6 @@ static void xe_vfio_pci_reset_done(struct pci_dev *pdev) > } > spin_unlock(&xe_vdev->reset_lock); > xe_vfio_pci_state_mutex_unlock(xe_vdev); > - > - xe_vfio_pci_reset(xe_vdev); > } > > static const struct pci_error_handlers xe_vfio_pci_err_handlers = {