public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com, jani.nikula@linux.intel.com,
	Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH 0/2] drm/i915/intel_panel: Fix seamless VRR mode switching for DRRS panels
Date: Tue, 28 Apr 2026 14:03:21 +0530	[thread overview]
Message-ID: <20260428083323.3745772-1-ankit.k.nautiyal@intel.com> (raw)

Currently intel_panel_fixed_mode() can return a lower refresh rate mode
for VRR panels if the lower refresh rate mode is first in the list.
This creates problems for seamless switch features like LRR and
Seamless-DRRS, as it results in changes to vsync_start/end causing a
full modeset instead of a seamless switch.

This is particularly problematic for DRRS panels on platforms without
double buffered M/N support for LNL+ (display version 20+), where
seamless clock changes are not possible.

This series attempts to fixe this by:
1. Adding a helper to get the highest refresh rate mode from the list of
   fixed modes for a connector.
2. When a seamless switch to a lower mode is desired, making
   intel_panel_fixed_mode() return the highest refresh rate mode,
   provided the requested rate is in VRR range. The vblank is then
   extended to provide the desired refresh rate.

To determine whether a full modeset or seamless switch is intended, the
connector state is checked for the allow_modeset flag. A nullable
conn_state parameter is added to intel_panel_fixed_mode() and
intel_panel_compute_config() for this purpose.

Ankit Nautiyal (2):
  drm/i915/intel_panel: Add a helper to get the highest refresh rate
    mode
  drm/i915/intel_panel: Use highest refresh rate mode for seamless VRR
    changes

 drivers/gpu/drm/i915/display/icl_dsi.c     |  2 +-
 drivers/gpu/drm/i915/display/intel_dp.c    |  6 +--
 drivers/gpu/drm/i915/display/intel_dsi.c   |  2 +-
 drivers/gpu/drm/i915/display/intel_dvo.c   |  6 +--
 drivers/gpu/drm/i915/display/intel_lvds.c  |  4 +-
 drivers/gpu/drm/i915/display/intel_panel.c | 50 ++++++++++++++--------
 drivers/gpu/drm/i915/display/intel_panel.h |  8 +++-
 drivers/gpu/drm/i915/display/intel_sdvo.c  |  8 ++--
 drivers/gpu/drm/i915/display/vlv_dsi.c     |  2 +-
 9 files changed, 54 insertions(+), 34 deletions(-)

-- 
2.45.2


             reply	other threads:[~2026-04-28  8:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28  8:33 Ankit Nautiyal [this message]
2026-04-28  8:33 ` [PATCH 1/2] drm/i915/intel_panel: Add a helper to get the highest refresh rate mode Ankit Nautiyal
2026-04-28  8:33 ` [PATCH 2/2] drm/i915/intel_panel: Use highest refresh rate mode for seamless VRR changes Ankit Nautiyal
2026-04-28  9:39   ` Jani Nikula
2026-04-29 13:28     ` Nautiyal, Ankit K
2026-04-29 12:14   ` Ville Syrjälä
2026-04-29 17:00     ` Nautiyal, Ankit K
2026-04-29 17:09       ` Nautiyal, Ankit K
2026-05-04 13:17       ` Nautiyal, Ankit K
2026-05-06  7:25         ` Nautiyal, Ankit K
2026-05-06 15:53           ` Manasi Navare
2026-04-28  9:32 ` ✓ CI.KUnit: success for drm/i915/intel_panel: Fix seamless VRR mode switching for DRRS panels Patchwork
2026-04-28 10:42 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-28 18:57 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260428083323.3745772-1-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox