From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5DE4FF8875 for ; Thu, 30 Apr 2026 03:32:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8ACD510F201; Thu, 30 Apr 2026 03:32:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="dIohoDcG"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id BFE4C10F1FA; Thu, 30 Apr 2026 03:32:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777519951; x=1809055951; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8vKgg6GG2BO9fXdaYpD63Hh9sI1RsI8TaomKxxD7GEg=; b=dIohoDcGd4Vgc3CDUt+GRZh6QOuQRy8R8CWA38l0VKWovnBfltt9VuhH Kt9YfwUrTk4lfJGjJFXQee3uJRF2B3KtTVgxaRSnQe/TiGjHkMt9Xc16l 7+4/cRwVDqDXVPgH/JTD7lsqnLWa/73dHtvt2k68POYRMTnU7CwImW7i6 OJPujXUljEXmwEn94X6s1RgfgQHmILbAD2eoQ1baW/Rgm02vnQqNk62qn WBIzRKkbq3MW5Y715uMZhpfQDzC/6TH3VZsHIIa1xnt/n5LD5ojQT0toz jL5DwIEb/8SfOhuWc0TlWZB2prGRj32G79S2YhjphTXP3AklJGaB+dyif g==; X-CSE-ConnectionGUID: DKoZ73a9R8W/jlxTJII+eQ== X-CSE-MsgGUID: 1BJ//9SzQCm0E4caO55oxQ== X-IronPort-AV: E=McAfee;i="6800,10657,11771"; a="95882097" X-IronPort-AV: E=Sophos;i="6.23,207,1770624000"; d="scan'208";a="95882097" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2026 20:32:31 -0700 X-CSE-ConnectionGUID: NJGpjIL4T9qQVEfxxprUDQ== X-CSE-MsgGUID: 1JQFUOvUS1aqrSrYZZCmMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,207,1770624000"; d="scan'208";a="227954577" Received: from kandpal-x299-ud4-pro.iind.intel.com ([10.190.239.10]) by fmviesa009.fm.intel.com with ESMTP; 29 Apr 2026 20:32:28 -0700 From: Suraj Kandpal To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: ankit.k.nautiyal@intel.com, fnu.vishwanatha@intel.com, santhosh.reddy.guddati@intel.com, Suraj Kandpal Subject: [PATCH 2/2] drm/i915/hdcp: Drop mgr->base.lock acquisition in intel_conn_to_vcpi() Date: Thu, 30 Apr 2026 09:02:22 +0530 Message-Id: <20260430033222.3411174-3-suraj.kandpal@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260430033222.3411174-1-suraj.kandpal@intel.com> References: <20260430033222.3411174-1-suraj.kandpal@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Now that intel_conn_to_vcpi() reads the MST topology state via drm_atomic_get_new_mst_topology_state(), the topology state belongs to this atomic commit and is already serialized through the atomic state's private object machinery. There is no need to additionally take mgr->base.lock here. Taking it from the HDCP enable path in commit_tail with state->base.acquire_ctx is also unsafe: by this point the acquire_ctx is no longer in a state where new modeset locks may be acquired through it, which produces a modeset-lock splat on MST + HDCP. Drop the drm_modeset_lock() call. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_hdcp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c index 91d2d7d823cc..a5d4e77f810f 100644 --- a/drivers/gpu/drm/i915/display/intel_hdcp.c +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c @@ -80,9 +80,8 @@ static int intel_conn_to_vcpi(struct intel_atomic_state *state, /* For HDMI this is forced to be 0x0. For DP SST also this is 0x0. */ if (!connector->mst.port) return 0; - mgr = connector->mst.port->mgr; - drm_modeset_lock(&mgr->base.lock, state->base.acquire_ctx); + mgr = connector->mst.port->mgr; mst_state = drm_atomic_get_new_mst_topology_state(&state->base, mgr); if (!mst_state) { drm_dbg_kms(display->drm, "MST topology still not created\n"); -- 2.34.1