From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 781A8FF885A for ; Mon, 4 May 2026 16:27:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 210DE10E770; Mon, 4 May 2026 16:27:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="TCAf1RYT"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4EA7410E0D2; Mon, 4 May 2026 16:27:25 +0000 (UTC) Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3605B82A; Mon, 4 May 2026 18:27:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1777912042; bh=pb/tc+qet8z57KNYIbl6SB0j1yoUbSKvqYUNc/vuBQM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TCAf1RYTKs7xAHfxC0MRhizC0ArrveHSDdfoVakroTl6JZ5B+7FW0w1LBbEhyc4aI CBWrbU/JfNPJsl//uhwdiNCNsAdRseXr60dxZpffaOkeF9oJqEmppzgIfmIaUuf37I 4sQIAaqoS+tGGO5Hw9Bl1jtP85PZqfBNW70G0HWM= Date: Mon, 4 May 2026 19:27:22 +0300 From: Laurent Pinchart To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Shuah Khan , Dmitry Baryshkov , Jyri Sarha , Tomi Valkeinen , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Simon Ser , Harry Wentland , Melissa Wen , Sebastian Wick , Alex Hung , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Chen-Yu Tsai , Samuel Holland , Dave Stevenson , =?utf-8?B?TWHDrXJh?= Canal , Raspberry Pi Kernel Maintenance , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Stone , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v3 02/20] drm/colorop: Fix typos in the doc Message-ID: <20260504162722.GG1344263@killaraus.ideasonboard.com> References: <20260424-drm-mode-config-init-v3-0-8b68d9db0d8b@kernel.org> <20260424-drm-mode-config-init-v3-2-8b68d9db0d8b@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260424-drm-mode-config-init-v3-2-8b68d9db0d8b@kernel.org> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, Apr 24, 2026 at 12:18:42PM +0200, Maxime Ripard wrote: > In the documentation of drm_colorop introduced by commit cfc27680ee20 > ("drm/colorop: Introduce new drm_colorop mode object"), the > documentation of __drm_colorop_state_reset() and __drm_colorop_reset() > were mentioning CRTC when they really meant colorop, probably due to > copy and paste. > > Fixes: cfc27680ee20 ("drm/colorop: Introduce new drm_colorop mode object") > Reviewed-by: Thomas Zimmermann > Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_colorop.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_colorop.c b/drivers/gpu/drm/drm_colorop.c > index 764d12060666..48d0b7ae3fc9 100644 > --- a/drivers/gpu/drm/drm_colorop.c > +++ b/drivers/gpu/drm/drm_colorop.c > @@ -503,11 +503,11 @@ void drm_colorop_atomic_destroy_state(struct drm_colorop *colorop, > * __drm_colorop_state_reset - resets colorop state to default values > * @colorop_state: atomic colorop state, must not be NULL > * @colorop: colorop object, must not be NULL > * > * Initializes the newly allocated @colorop_state with default > - * values. This is useful for drivers that subclass the CRTC state. > + * values. This is useful for drivers that subclass the colorop state. > */ > static void __drm_colorop_state_reset(struct drm_colorop_state *colorop_state, > struct drm_colorop *colorop) > { > u64 val; > @@ -526,14 +526,14 @@ static void __drm_colorop_state_reset(struct drm_colorop_state *colorop_state, > /** > * __drm_colorop_reset - reset state on colorop > * @colorop: drm colorop > * @colorop_state: colorop state to assign > * > - * Initializes the newly allocated @colorop_state and assigns it to > - * the &drm_crtc->state pointer of @colorop, usually required when > - * initializing the drivers or when called from the &drm_colorop_funcs.reset > - * hook. > + * Initializes the newly allocated @colorop_state and assigns it to the > + * &drm_colorop->state pointer of @colorop, usually required when > + * initializing the drivers or when called from the > + * &drm_colorop_funcs.reset hook. > * > * This is useful for drivers that subclass the colorop state. > */ > static void __drm_colorop_reset(struct drm_colorop *colorop, > struct drm_colorop_state *colorop_state) > -- Regards, Laurent Pinchart