From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, Jani Nikula <jani.nikula@intel.com>
Subject: [PATCH v2 09/16] drm/xe: Reorganize intel_plane_pin_fb() a bit
Date: Fri, 8 May 2026 17:34:19 +0300 [thread overview]
Message-ID: <20260508143426.26504-10-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20260508143426.26504-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Move most of the plane state stuff out from the inner parts
of intel_plane_pin_fb(). The plan is to take those inner parts and
abstract them into the new fb_pin parent interface, and we don't
want any plane_state stuff there.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/xe/display/xe_fb_pin.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/xe/display/xe_fb_pin.c b/drivers/gpu/drm/xe/display/xe_fb_pin.c
index bab9b015ff8d..cddb0f3c7da0 100644
--- a/drivers/gpu/drm/xe/display/xe_fb_pin.c
+++ b/drivers/gpu/drm/xe/display/xe_fb_pin.c
@@ -467,26 +467,30 @@ int intel_plane_pin_fb(struct intel_plane_state *new_plane_state,
{
struct drm_framebuffer *fb = new_plane_state->hw.fb;
struct drm_gem_object *obj = intel_fb_bo(fb);
- struct i915_vma *vma;
struct intel_plane *plane = to_intel_plane(new_plane_state->uapi.plane);
struct intel_fb_pin_params pin_params = {
.view = &new_plane_state->view.gtt,
.alignment = intel_plane_fb_min_alignment(new_plane_state),
.needs_cpu_lmem_access = intel_fb_needs_cpu_access(fb),
};
+ struct i915_vma *ggtt_vma = NULL;
+ struct i915_vma *dpt_vma = NULL;
+ int fence_id = -1;
+ u32 offset;
if (reuse_vma(new_plane_state, old_plane_state))
return 0;
- vma = __xe_pin_fb_vma(obj, intel_fb_uses_dpt(fb), &pin_params);
-
- if (IS_ERR(vma))
- return PTR_ERR(vma);
+ ggtt_vma = __xe_pin_fb_vma(obj, intel_fb_uses_dpt(fb), &pin_params);
+ if (IS_ERR(ggtt_vma))
+ return PTR_ERR(ggtt_vma);
- new_plane_state->ggtt_vma = vma;
+ offset = xe_ggtt_node_addr(ggtt_vma->node);
- new_plane_state->surf = xe_ggtt_node_addr(new_plane_state->ggtt_vma->node) +
- plane->surf_offset(new_plane_state);
+ new_plane_state->dpt_vma = dpt_vma;
+ new_plane_state->ggtt_vma = ggtt_vma;
+ new_plane_state->fence_id = fence_id;
+ new_plane_state->surf = offset + plane->surf_offset(new_plane_state);
return 0;
}
--
2.52.0
next prev parent reply other threads:[~2026-05-08 14:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 14:34 [PATCH v2 00/16] drm/i915: Introduce 'fb_pin' parent interface Ville Syrjala
2026-05-08 14:34 ` [PATCH v2 01/16] drm/i915: Introduce intel_parent_fb_pin_get_map() Ville Syrjala
2026-05-08 14:34 ` [PATCH v2 02/16] drm/i915: Move intel_fb_pin_params to the parent interface Ville Syrjala
2026-05-08 14:34 ` [PATCH v2 03/16] drm/i915: Move the i915_dpt_offset()==0 assert Ville Syrjala
2026-05-08 14:34 ` [PATCH v2 04/16] drm/i915: Reorganize intel_plane_pin_fb() a bit Ville Syrjala
2026-05-08 14:34 ` [PATCH v2 05/16] drm/i915: Introduce i915_fb_pin_dpt_(un)pin() Ville Syrjala
2026-05-08 14:34 ` [PATCH v2 06/16] drm/i915: Introduce i915_fb_pin_ggtt_(un)pin() Ville Syrjala
2026-05-08 14:34 ` [PATCH v2 07/16] drm/xe: Move the FORCE_WC assert into __xe_pin_fb_vma() Ville Syrjala
2026-05-08 14:34 ` [PATCH v2 08/16] drm/xe: Kill the fbdev vma reuse hack Ville Syrjala
2026-05-08 14:34 ` Ville Syrjala [this message]
2026-05-08 14:34 ` [PATCH v2 10/16] drm/xe: Introduce xe_fb_pin_dpt_(un)pin() Ville Syrjala
2026-05-08 14:34 ` [PATCH v2 11/16] drm/xe: Introduce xe_fb_pin_ggtt_(un)pin() Ville Syrjala
2026-05-08 14:34 ` [PATCH v2 12/16] drm/xe: Restructure reuse_vma() Ville Syrjala
2026-05-08 14:34 ` [PATCH v2 13/16] drm/i915: Introduce the main fb_pin parent interface Ville Syrjala
2026-05-08 14:34 ` [PATCH v2 14/16] drm/i915/fbdev: Use intel_parent_fb_pin_ggtt_(un)pin() Ville Syrjala
2026-05-08 14:34 ` [PATCH v2 15/16] drm/xe: Use xe_fb_pin_ggtt_pin() for the initial FB pin Ville Syrjala
2026-05-08 14:34 ` [PATCH v2 16/16] drm/i915: Consolidate the intel_plane_(un)pin_fb() implementations Ville Syrjala
2026-05-08 14:41 ` ✗ CI.checkpatch: warning for drm/i915: Introduce 'fb_pin' parent interface (rev3) Patchwork
2026-05-08 14:42 ` ✓ CI.KUnit: success " Patchwork
2026-05-08 15:44 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-09 2:43 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508143426.26504-10-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox