From: Shekhar Chauhan <shekhar.chauhan@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: shekhar.chauhan@intel.com, balasubramani.vivekanandan@intel.com
Subject: [PATCH] drm/xe/devcoredump: Drop a FIXME in devcoredump
Date: Tue, 12 May 2026 11:25:08 +0530 [thread overview]
Message-ID: <20260512055508.1380191-1-shekhar.chauhan@intel.com> (raw)
The FIXME says that xe_engine_snapshot_print.. is accessing persistent
driver data, unlike what the FIXME says that it does. Drop the FIXME
since the current code is not going to access the hardware while
dumping.
More details about this patch:
https://patchwork.freedesktop.org/patch/703884/?series=161407&rev=1
The starting two feedbacks make sense and the original patch is wrong
in adding those changes, but the last feedback is the one which
highlights the point.
Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
---
drivers/gpu/drm/xe/xe_guc_capture.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_capture.c b/drivers/gpu/drm/xe/xe_guc_capture.c
index bc49e40165a3..21f7caf9ea08 100644
--- a/drivers/gpu/drm/xe/xe_guc_capture.c
+++ b/drivers/gpu/drm/xe/xe_guc_capture.c
@@ -1841,12 +1841,6 @@ void xe_engine_snapshot_print(struct xe_hw_engine_snapshot *snapshot, struct drm
str_yes_no(snapshot->kernel_reserved));
for (type = GUC_STATE_CAPTURE_TYPE_GLOBAL; type < GUC_STATE_CAPTURE_TYPE_MAX; type++) {
- /*
- * FIXME: During devcoredump print we should avoid accessing the
- * driver pointers for gt or engine. Printing should be done only
- * using the snapshot captured. Here we are accessing the gt
- * pointer. It should be fixed.
- */
list = xe_guc_capture_get_reg_desc_list(gt, GUC_CAPTURE_LIST_INDEX_PF, type,
capture_class, false);
snapshot_print_by_list_order(snapshot, p, type, list);
--
2.53.0
next reply other threads:[~2026-05-12 5:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 5:55 Shekhar Chauhan [this message]
2026-05-12 7:17 ` drm/xe/devcoredump: Drop a FIXME in devcoredump Vivekanandan, Balasubramani
2026-05-12 8:57 ` Shekhar Chauhan
2026-05-12 10:23 ` Vivekanandan, Balasubramani
2026-05-12 10:07 ` ✓ CI.KUnit: success for " Patchwork
2026-05-12 11:24 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-12 20:20 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512055508.1380191-1-shekhar.chauhan@intel.com \
--to=shekhar.chauhan@intel.com \
--cc=balasubramani.vivekanandan@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox