Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	Ilia Levi <ilia.levi@intel.com>
Subject: [PATCH 1/9] drm/xe: Add IRQ page to HW engine definition
Date: Thu, 14 May 2026 17:00:02 +0200	[thread overview]
Message-ID: <20260514150010.7123-2-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20260514150010.7123-1-michal.wajdeczko@intel.com>

For each HW engine definition, we already make changes to the IRQ
offset, as required when using MSI-X, but we leave actual MEMIRQ
page selection to the MEMIRQ handler, repeated on every interrupt.

As a preparation step to simplify the MEMIRQ handler, store the
MEMIRQ page number as part of the HW engine definition.

Suggested-by: Ilia Levi <ilia.levi@intel.com>
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Ilia Levi <ilia.levi@intel.com>
---
 drivers/gpu/drm/xe/xe_hw_engine.c       | 11 ++++++++---
 drivers/gpu/drm/xe/xe_hw_engine_types.h |  2 ++
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c b/drivers/gpu/drm/xe/xe_hw_engine.c
index 0f0e08bcc182..3c3b6bcc4b53 100644
--- a/drivers/gpu/drm/xe/xe_hw_engine.c
+++ b/drivers/gpu/drm/xe/xe_hw_engine.c
@@ -503,9 +503,14 @@ static void hw_engine_init_early(struct xe_gt *gt, struct xe_hw_engine *hwe,
 	hwe->class = info->class;
 	hwe->instance = info->instance;
 	hwe->mmio_base = info->mmio_base;
-	hwe->irq_offset = xe_device_has_msix(gt_to_xe(gt)) ?
-		get_msix_irq_offset(gt, info->class) :
-		info->irq_offset;
+	if (xe_device_has_msix(gt_to_xe(gt))) {
+		hwe->irq_offset = get_msix_irq_offset(gt, info->class);
+		hwe->irq_page = info->instance;
+
+	} else {
+		hwe->irq_offset = info->irq_offset;
+		hwe->irq_page = 0;
+	}
 	hwe->domain = info->domain;
 	hwe->name = info->name;
 	hwe->fence_irq = &gt->fence_irq[info->class];
diff --git a/drivers/gpu/drm/xe/xe_hw_engine_types.h b/drivers/gpu/drm/xe/xe_hw_engine_types.h
index 0f87128c6529..2cf898e682f5 100644
--- a/drivers/gpu/drm/xe/xe_hw_engine_types.h
+++ b/drivers/gpu/drm/xe/xe_hw_engine_types.h
@@ -118,6 +118,8 @@ struct xe_hw_engine {
 	u16 logical_instance;
 	/** @irq_offset: IRQ offset of this hw engine */
 	u16 irq_offset;
+	/** @irq_page: MEMIRQ page used by this HW engine */
+	u16 irq_page;
 	/** @mmio_base: MMIO base address of this hw engine*/
 	u32 mmio_base;
 	/**
-- 
2.47.1


  reply	other threads:[~2026-05-14 15:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14 15:00 [PATCH 0/9] drm/xe: Refresh MEMIRQ code Michal Wajdeczko
2026-05-14 15:00 ` Michal Wajdeczko [this message]
2026-05-14 15:00 ` [PATCH 2/9] drm/xe/memirq: Make page layout macros private Michal Wajdeczko
2026-05-14 15:00 ` [PATCH 3/9] drm/xe/memirq: Update GuC initialization and IRQ handler Michal Wajdeczko
2026-05-14 15:00 ` [PATCH 4/9] drm/xe/memirq: Use IRQ page from HW engine definition Michal Wajdeczko
2026-05-14 15:00 ` [PATCH 5/9] drm/xe/memirq: Reduce buffer size Michal Wajdeczko
2026-05-14 15:00 ` [PATCH 6/9] drm/xe/memirq: Update diagnostic message Michal Wajdeczko
2026-05-14 15:00 ` [PATCH 7/9] drm/xe/memirq: Dump all source pages if MSI-X Michal Wajdeczko
2026-05-14 15:00 ` [PATCH 8/9] drm/xe/memirq: Drop cached iosys_map for MEMIRQ mask Michal Wajdeczko
2026-05-14 15:00 ` [PATCH 9/9] drm/xe/memirq: Drop cached iosys_map for MEMIRQ status Michal Wajdeczko
2026-05-14 15:11 ` ✓ CI.KUnit: success for drm/xe: Refresh MEMIRQ code Patchwork
2026-05-14 16:24 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-15  8:26 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-05-15 11:17 ` Patchwork
2026-05-15 13:54   ` Michal Wajdeczko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260514150010.7123-2-michal.wajdeczko@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=ilia.levi@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox