From: Ethan Nelson-Moore <enelsonmoore@gmail.com>
To: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: "Ethan Nelson-Moore" <enelsonmoore@gmail.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Subject: [PATCH] drm/xe/pf: remove code guarded by nonexistent config option
Date: Sat, 13 Jun 2026 16:39:14 -0700 [thread overview]
Message-ID: <20260613233915.162661-1-enelsonmoore@gmail.com> (raw)
Some code in drivers/gpu/drm/xe/xe_lmtt_2l.c depends on
CONFIG_DRM_XE_LMTT_2L_128GB, which has never been defined in the
kernel. Remove this dead code and correct a related comment.
Discovered while searching for CONFIG_* symbols referenced in code but
not defined in any Kconfig file.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
drivers/gpu/drm/xe/xe_lmtt_2l.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_lmtt_2l.c b/drivers/gpu/drm/xe/xe_lmtt_2l.c
index 84bc5c4212b5..707e0d090c62 100644
--- a/drivers/gpu/drm/xe/xe_lmtt_2l.c
+++ b/drivers/gpu/drm/xe/xe_lmtt_2l.c
@@ -14,9 +14,9 @@
/**
* DOC: Two-Level LMTT Structure
*
- * LMHAW (Local Memory Host Address Width) is 37 bit (128GB)
+ * LMHAW (Local Memory Host Address Width) is 35 bit (32GB)
*
- * LMGAW (Local Memory Guest Address Width) is 37 bit (128GB)
+ * LMGAW (Local Memory Guest Address Width) is 35 bit (32GB)
*
* The following figure illustrates the structure and function of the 2L LMTT::
*
@@ -54,11 +54,7 @@
typedef u32 lmtt_2l_pde_t;
typedef u32 lmtt_2l_pte_t;
-#if IS_ENABLED(CONFIG_DRM_XE_LMTT_2L_128GB)
-#define LMTT_2L_HAW 37 /* 128 GiB */
-#else
#define LMTT_2L_HAW 35 /* 32 GiB */
-#endif
#define LMTT_2L_PDE_MAX_NUM 64 /* SRIOV with PF and 63 VFs, index 0 (PF) is unused */
#define LMTT_2L_PDE_LMTT_PTR GENMASK(LMTT_2L_HAW - 13, 4)
@@ -79,7 +75,6 @@ static unsigned int lmtt_2l_pte_num(unsigned int level)
case 1:
return LMTT_2L_PDE_MAX_NUM;
case 0:
- BUILD_BUG_ON(LMTT_2L_HAW == 37 && LMTT_2L_PTE_MAX_NUM != SZ_64K);
BUILD_BUG_ON(LMTT_2L_HAW == 35 && LMTT_2L_PTE_MAX_NUM != SZ_16K);
return LMTT_2L_PTE_MAX_NUM;
default:
--
2.43.0
next reply other threads:[~2026-06-15 12:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-13 23:39 Ethan Nelson-Moore [this message]
2026-06-15 13:35 ` ✗ LGCI.VerificationFailed: failure for drm/xe/pf: remove code guarded by nonexistent config option Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260613233915.162661-1-enelsonmoore@gmail.com \
--to=enelsonmoore@gmail.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox