From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B43ECD98E2 for ; Wed, 17 Jun 2026 18:19:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E31310F08F; Wed, 17 Jun 2026 18:19:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="cHnx329k"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF6C510F08F; Wed, 17 Jun 2026 18:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781720339; x=1813256339; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7Okvw+fsV9Qg1R8JgSR+HzZFPxVLT2qPwpZWC2AiPSo=; b=cHnx329kSlJRImpqptW7zU0eCFYYRlVQewxQwMi8q0B/hHuEOtqikTGK wDGcOhORFzXXQ/AcFP7mhwhVIw/oXrGGhbvzls/0UF8Grlvo3S2DheGck EYPmdc8SB9eW3LGeM+vTnOJKQFpv4qFdmbbb4MZHNpvIXFzULazlu7gZl 6NGUdpkV7QEFeKlqnddj1dxkSV6cYOpDirO/PY6DSQjL7Bp0YE78E+50Q yucS966Evr3UrjeeE/Pv4FpjclnvroLSH9z2rYbcUuouPIu1hXiALpRa4 /ofL06wmscsZM2lBSTbm1VL5hQORNEB1LTWUT0RTyF5K4/6mnkyhCF9YG g==; X-CSE-ConnectionGUID: aV7sZImrS2ykSBy9TvKxEQ== X-CSE-MsgGUID: 93Vdodl5QFaqfvgDpxRH5Q== X-IronPort-AV: E=McAfee;i="6800,10657,11820"; a="82634313" X-IronPort-AV: E=Sophos;i="6.24,210,1774335600"; d="scan'208";a="82634313" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2026 11:18:58 -0700 X-CSE-ConnectionGUID: 9mCF6spJTWeD+8R3niq0Ag== X-CSE-MsgGUID: goR/fFY0QW2qbqiJ+C9VnA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,210,1774335600"; d="scan'208";a="243968445" Received: from osgc-sh-dragon.sh.intel.com ([10.239.81.44]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2026 11:18:55 -0700 From: Jonathan Cavitt To: dri-devel@lists.freedesktop.org Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com, mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch, linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org, Rodrigo.vivi@intel.com, matthew.brost@intel.com, maarten.lankhorst@linux.intel.com, thomas.hellstrom@linux.intel.com, tzimmermann@suse.de Subject: [PATCH v3 1/2] drm/xe/pagefault: Add SRCID to pagefault struct Date: Thu, 18 Jun 2026 02:18:47 +0800 Message-ID: <20260617181849.769247-2-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260617181849.769247-1-jonathan.cavitt@intel.com> References: <20260617181849.769247-1-jonathan.cavitt@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Add SRCID information to pagefault struct for the purpose of reporting the hardware unit that resulted in the pagefault. Signed-off-by: Jonathan Cavitt Cc: Matthew Brost Cc: Thomas Hellström Cc: Rodrigo Vivi Cc: David Airlie Cc: Simona Vetter --- drivers/gpu/drm/xe/xe_guc_pagefault.c | 1 + drivers/gpu/drm/xe/xe_pagefault.c | 6 ++++-- drivers/gpu/drm/xe/xe_pagefault_types.h | 4 +++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_guc_pagefault.c b/drivers/gpu/drm/xe/xe_guc_pagefault.c index 607e32392f46..17cb7f359261 100644 --- a/drivers/gpu/drm/xe/xe_guc_pagefault.c +++ b/drivers/gpu/drm/xe/xe_guc_pagefault.c @@ -91,6 +91,7 @@ int xe_guc_pagefault_handler(struct xe_guc *guc, u32 *msg, u32 len) FIELD_GET(PFD_FAULT_TYPE, msg[2])); pf.consumer.engine_class = FIELD_GET(PFD_ENG_CLASS, msg[0]); pf.consumer.engine_instance = FIELD_GET(PFD_ENG_INSTANCE, msg[0]); + pf.consumer.srcid = FIELD_GET(PFD_SRC_ID, msg[0]); pf.producer.private = guc; pf.producer.ops = &guc_pagefault_ops; diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c index dd3c068e1a39..42b682ba5f9b 100644 --- a/drivers/gpu/drm/xe/xe_pagefault.c +++ b/drivers/gpu/drm/xe/xe_pagefault.c @@ -248,7 +248,8 @@ static void xe_pagefault_print(struct xe_pagefault *pf) "\tAccessType: %lu\n" "\tFaultLevel: %lu\n" "\tEngineClass: %d %s\n" - "\tEngineInstance: %d\n", + "\tEngineInstance: %d\n" + "\tSRCID: 0x%02x\n", pf->consumer.asid, upper_32_bits(pf->consumer.page_addr), lower_32_bits(pf->consumer.page_addr), @@ -260,7 +261,8 @@ static void xe_pagefault_print(struct xe_pagefault *pf) pf->consumer.fault_type_level), pf->consumer.engine_class, xe_hw_engine_class_to_str(pf->consumer.engine_class), - pf->consumer.engine_instance); + pf->consumer.engine_instance, + pf->consumer.srcid); } static void xe_pagefault_save_to_vm(struct xe_device *xe, struct xe_pagefault *pf) diff --git a/drivers/gpu/drm/xe/xe_pagefault_types.h b/drivers/gpu/drm/xe/xe_pagefault_types.h index c4ee625b93dd..60cc269aeea3 100644 --- a/drivers/gpu/drm/xe/xe_pagefault_types.h +++ b/drivers/gpu/drm/xe/xe_pagefault_types.h @@ -86,8 +86,10 @@ struct xe_pagefault { u8 engine_class; /** @consumer.engine_instance: engine instance */ u8 engine_instance; + /** @consumer.srcid: ID of hardware unit producing fault */ + u8 srcid; /** @consumer.reserved: reserved bits for future expansion */ - u64 reserved; + u8 reserved[7]; } consumer; /** * @producer: State for the producer (i.e., HW/FW interface). Populated -- 2.53.0