From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49ED2C43458 for ; Mon, 29 Jun 2026 02:29:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1018E10E6AC; Mon, 29 Jun 2026 02:29:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="Cs4qdwqn"; dkim-atps=neutral Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012067.outbound.protection.outlook.com [40.107.200.67]) by gabe.freedesktop.org (Postfix) with ESMTPS id 39B9910E6A3 for ; Mon, 29 Jun 2026 02:29:46 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mJtzTRUdRtuuYvrStSW8/gNuZdiTlb4sDGmoOv34VjkYWTFxxC9iKPE6PHEDpuRyJUvIZX2MnsIk7/ZOQ/gJDGxWHbYUlbQMo6Fr7VGaH90StMTZSdjnC8mshLaeRVCz8O5zifpZZz27L80ZuR5FKVpxBQffsswf2f80htLE0A+cbiquXRpJoZoDOaqUfGI141M4n5QYe/CSLvbNyIXONKeJe/0tawvdBWW6MtEZEM9Rgvq8WsRTFhmnifPmJoYuAdY1vuGlyDwbalkeD9Goom7IrqdT/NdLSas5ohHX3MVC2zhVWs4h62z+bCKe8/BqRJIZnihby2qj1GD7dFOgbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CHDMa5NODSlqF1ak0f3pBSIUSBefKs/FDTgD36oeFGM=; b=cADMSHBp3qQWKBOHojjW0aPlM1TXthKAA+kdtwExKP2FXaAqk9B31/RBLE0n03PYQ7tzE4EszuiRec6jCncTjgj3fhRALtFkwUOjqZ6rOAfvBYXgDzl6vkiRUzZ6rVwZ0mXOoKm/4VI9BsimAcNXOrkCcnq0V18BlWY2ivtLXsdUX7qzahsNgZqf2lLkF7yiBV750T4pRwrVim+Ljb8jtMQMmQDWMcYyhxw3sx21cEMsbERMSpUlnWpaZrkrE+63nH/inxZQ66o+8f315IUbOgKQr6FT2Qyu4TT304z1mCigaK8zRkafmjUEgqiE7k2d0PJXTCu6gO4fpQXCBJWfWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.freedesktop.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CHDMa5NODSlqF1ak0f3pBSIUSBefKs/FDTgD36oeFGM=; b=Cs4qdwqnK9Oohw3ZF3c6enhqZxkzJjJYLU2QD/ZNpPi1qIFS/lwP45//whbWFx/08PTX8i6/XTKW+0Wmu56MIDp+XAgxTeRXLkqnknPi4AREHDHAyIQLJR5LjfsZnkJhvp0qgXdjXhoxbI+QLv5asKQk0FIer07mWmOpEttie0o= Received: from SA0PR12CA0017.namprd12.prod.outlook.com (2603:10b6:806:6f::22) by MN6PR12MB8471.namprd12.prod.outlook.com (2603:10b6:208:473::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.19; Mon, 29 Jun 2026 02:29:40 +0000 Received: from SA2PEPF00001508.namprd04.prod.outlook.com (2603:10b6:806:6f:cafe::1f) by SA0PR12CA0017.outlook.office365.com (2603:10b6:806:6f::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.159.19 via Frontend Transport; Mon, 29 Jun 2026 02:29:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SA2PEPF00001508.mail.protection.outlook.com (10.167.242.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.6 via Frontend Transport; Mon, 29 Jun 2026 02:29:39 +0000 Received: from honglei-remote.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Sun, 28 Jun 2026 21:29:38 -0500 From: Honglei Huang To: CC: Honglei Huang , Matthew Brost Subject: [PATCH v7 2/5] drm/gpusvm: embed struct drm_device into drm_gpusvm_pages Date: Mon, 29 Jun 2026 10:29:18 +0800 Message-ID: <20260629022921.17533-3-honghuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260629022921.17533-1-honghuan@amd.com> References: <20260629022921.17533-1-honghuan@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb08.amd.com (10.181.42.217) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00001508:EE_|MN6PR12MB8471:EE_ X-MS-Office365-Filtering-Correlation-Id: aa35c70b-b8ed-45ac-262b-08ded5864567 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700016|82310400026|376014|23010399003|1800799024|22082099003|18002099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: BM595shg3g3Ggg/ERvNl6bZU/rPleegPfOPeGHIz+Gn4oNqsrjfy2264XTWqpDV2pHIlYyb9Kc0p5O/yO5fmGtBj9uAZzIRtyD8Y+ILWuMI0U53IRI+3VwiVpJBD9lpO8zUEXoLlml0OzAXHKJM6WLySjb+oi/HWhM/5F4i3Zqglgd2zYz0+KsJUQ6cMZAAti7twYOc/Ujb/OOf63SrAyouBQbbkMHzR9dWzM1zbNx74pGwGWQfszyA6R4AoifmTaHeWUHW2xgLVqGOS1LCeTSLAQQw929MEXWf3ophCCeCEPgQMOwBKLJEFLUjULMf4lWJoo2DpA6KiMAWEppokfvBymSfAXzEhHDd3gOEAoC2iEcwAuMFYKHSC1ZKc+lwALI8YGG4kCjS0diOR7KsxeWIphMxVMcHNPBdTIf9SFVoHyaIItZBogr8DiuShZiDz7IF5IXwlWNdRHV8FKp8+ho7/pSjKJLGo+5IqF/JyzCNDtOpYytz1QfYTbE7t8nhyUCGNNfW2zfavrZdpIg3y2BAtYhkA27R9AW4+6WV0rq1uZq9oy/c7BiAVf1EaT6e//2ssBiZfAzYZOWYWksVXhy1dZAMqcdKtDh1/2aQClhWOJi8axU9qHQQE1SqaMGqsnszY0BPMuYpJK/p6BmT6RauE1dB29Vq8yuJGwHToQ1xpi1/ksV3A/Lrn0fc6UOGKX7CVnyArtTbZi1NTfUo1wA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700016)(82310400026)(376014)(23010399003)(1800799024)(22082099003)(18002099003)(56012099006)(11063799006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: c42LH5G3TiJEdIIINlNli/Z7ZNvoygeBOkFZa9wHBB2vmYJ7tugQFIai3He2/K5515xUBZzO2OvaC75dtC6rEaifWhTpcn/0zBKgBTKlIyv6RE2kfAqhYZSBu1DNlKeq08wr86rDL0gGWi+8xi00ihvd/p9xTFxz8Q+EhPuxTEOM8HRALD4w00v3MejM/YsRKwC2iJ/GW63wk27L1JWz3XixYoAEI6IniCsysVzZfvStTd0ZULjzJ8G5W+GFQQFWSlzpNs/OgKYEjShNR7suPzdce4TmkZTdIkJ3Q98+aavK/vCTAfWnxdFNywN1ctw+KLhQcDnRkK2+NE2cK9Jw0uz5i3Twe2KfNX7B2HVBG6n18r9RxmJdam9aZeRTDf1Op2XGD1i3pPM5+L4kNwZfI1iGjMxLiCa1zat1lGAxBCQHgdGw0IHuLALWx3zZpDew X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2026 02:29:39.9143 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aa35c70b-b8ed-45ac-262b-08ded5864567 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00001508.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8471 X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" drm_gpusvm_pages is the layer that actually represents physical pages/mappings it owns the dma_addr array, the dma_iova_state... With the previous patch, so drm_gpusvm_pages is now strictly about physical pages and their DMA view. Since now the drm_gpusvm_pages instance is inherently bound to one specific drm_device, make that ownership explicit by giving drm_gpusvm_pages its own drm_device handle, and drive all DMA through it instead of through the gpusvm: - Add drm to struct drm_gpusvm_pages and route all DMA in drm_gpusvm_get_pages() / __drm_gpusvm_unmap_pages() through svm_pages->drm instead of gpusvm->drm. - Bind svm_pages->drm where the pages object is initialised (drm_gpusvm_range_alloc() and the xe userptr setup) and require it to be set on entry to drm_gpusvm_get_pages(); the dma device is immutable for the lifetime of the pages instance. A later patch introduces drm_gpusvm_init_pages() to centralise this. Suggested-by: Matthew Brost Reviewed-by: Matthew Brost Signed-off-by: Honglei Huang --- drivers/gpu/drm/drm_gpusvm.c | 30 ++++++++++++++++++++---------- drivers/gpu/drm/xe/xe_userptr.c | 2 ++ include/drm/drm_gpusvm.h | 2 ++ 3 files changed, 24 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_gpusvm.c b/drivers/gpu/drm/drm_gpusvm.c index abdfdaaf5e2..604554e40f6 100644 --- a/drivers/gpu/drm/drm_gpusvm.c +++ b/drivers/gpu/drm/drm_gpusvm.c @@ -641,6 +641,7 @@ drm_gpusvm_range_alloc(struct drm_gpusvm *gpusvm, range->itree.last = ALIGN(fault_addr + 1, chunk_size) - 1; INIT_LIST_HEAD(&range->entry); range->pages.notifier_seq = LONG_MAX; + range->pages.drm = gpusvm->drm; range->flags.migrate_devmem = migrate_devmem ? 1 : 0; return range; @@ -1135,11 +1136,16 @@ static void __drm_gpusvm_unmap_pages(struct drm_gpusvm *gpusvm, unsigned long npages) { struct drm_pagemap *dpagemap = svm_pages->dpagemap; - struct device *dev = gpusvm->drm->dev; + struct device *dev; unsigned long i, j; lockdep_assert_held(&gpusvm->notifier_lock); + if (!svm_pages->drm) + return; + + dev = svm_pages->drm->dev; + if (svm_pages->flags.has_dma_mapping) { struct drm_gpusvm_pages_flags flags = { .__flags = svm_pages->flags.__flags, @@ -1421,6 +1427,9 @@ int drm_gpusvm_get_pages(struct drm_gpusvm *gpusvm, DMA_BIDIRECTIONAL; struct dma_iova_state *state = &svm_pages->state; + if (!svm_pages->drm) + return -EINVAL; + retry: if (time_after(jiffies, timeout)) return -EBUSY; @@ -1520,7 +1529,7 @@ int drm_gpusvm_get_pages(struct drm_gpusvm *gpusvm, pagemap = page_pgmap(page); dpagemap = drm_pagemap_page_to_dpagemap(page); - if (drm_WARN_ON(gpusvm->drm, !dpagemap)) { + if (drm_WARN_ON(svm_pages->drm, !dpagemap)) { /* * Raced. This is not supposed to happen * since hmm_range_fault() should've migrated @@ -1532,10 +1541,10 @@ int drm_gpusvm_get_pages(struct drm_gpusvm *gpusvm, } svm_pages->dma_addr[j] = dpagemap->ops->device_map(dpagemap, - gpusvm->drm->dev, + svm_pages->drm->dev, page, order, dma_dir); - if (dma_mapping_error(gpusvm->drm->dev, + if (dma_mapping_error(svm_pages->drm->dev, svm_pages->dma_addr[j].addr)) { err = -EFAULT; goto err_unmap; @@ -1555,11 +1564,11 @@ int drm_gpusvm_get_pages(struct drm_gpusvm *gpusvm, } if (!i) - dma_iova_try_alloc(gpusvm->drm->dev, state, + dma_iova_try_alloc(svm_pages->drm->dev, state, 0, npages * PAGE_SIZE); if (dma_use_iova(state)) { - err = dma_iova_link(gpusvm->drm->dev, state, + err = dma_iova_link(svm_pages->drm->dev, state, hmm_pfn_to_phys(pfns[i]), svm_pages->state_offset, PAGE_SIZE << order, @@ -1570,11 +1579,11 @@ int drm_gpusvm_get_pages(struct drm_gpusvm *gpusvm, addr = state->addr + svm_pages->state_offset; svm_pages->state_offset += PAGE_SIZE << order; } else { - addr = dma_map_page(gpusvm->drm->dev, + addr = dma_map_page(svm_pages->drm->dev, page, 0, PAGE_SIZE << order, dma_dir); - if (dma_mapping_error(gpusvm->drm->dev, addr)) { + if (dma_mapping_error(svm_pages->drm->dev, addr)) { err = -EFAULT; goto err_unmap; } @@ -1590,7 +1599,7 @@ int drm_gpusvm_get_pages(struct drm_gpusvm *gpusvm, } if (dma_use_iova(state)) { - err = dma_iova_sync(gpusvm->drm->dev, state, 0, + err = dma_iova_sync(svm_pages->drm->dev, state, 0, svm_pages->state_offset); if (err) goto err_unmap; @@ -1640,7 +1649,8 @@ int drm_gpusvm_range_get_pages(struct drm_gpusvm *gpusvm, struct drm_gpusvm_range *range, const struct drm_gpusvm_ctx *ctx) { - return drm_gpusvm_get_pages(gpusvm, &range->pages, gpusvm->mm, + return drm_gpusvm_get_pages(gpusvm, &range->pages, + gpusvm->mm, &range->notifier->notifier, drm_gpusvm_range_start(range), drm_gpusvm_range_end(range), ctx); diff --git a/drivers/gpu/drm/xe/xe_userptr.c b/drivers/gpu/drm/xe/xe_userptr.c index 6761005c0b9..1b540e62af6 100644 --- a/drivers/gpu/drm/xe/xe_userptr.c +++ b/drivers/gpu/drm/xe/xe_userptr.c @@ -390,6 +390,7 @@ int xe_userptr_setup(struct xe_userptr_vma *uvma, unsigned long start, unsigned long range) { struct xe_userptr *userptr = &uvma->userptr; + struct xe_vm *vm = xe_vma_vm(&uvma->vma); int err; INIT_LIST_HEAD(&userptr->invalidate_link); @@ -402,6 +403,7 @@ int xe_userptr_setup(struct xe_userptr_vma *uvma, unsigned long start, return err; userptr->pages.notifier_seq = LONG_MAX; + userptr->pages.drm = &vm->xe->drm; return 0; } diff --git a/include/drm/drm_gpusvm.h b/include/drm/drm_gpusvm.h index 251a7266a73..842353afb27 100644 --- a/include/drm/drm_gpusvm.h +++ b/include/drm/drm_gpusvm.h @@ -129,6 +129,7 @@ struct drm_gpusvm_pages_flags { /** * struct drm_gpusvm_pages - Structure representing a GPU SVM mapped pages * + * @drm: The DRM device that owns the dma mappings * @dma_addr: Device address array * @dpagemap: The struct drm_pagemap of the device pages we're dma-mapping. * Note this is assuming only one drm_pagemap per range is allowed. @@ -138,6 +139,7 @@ struct drm_gpusvm_pages_flags { * @flags: Flags for the range; see &struct drm_gpusvm_pages_flags */ struct drm_gpusvm_pages { + struct drm_device *drm; struct drm_pagemap_addr *dma_addr; struct drm_pagemap *dpagemap; struct dma_iova_state state; -- 2.34.1