Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Zhanjun Dong <zhanjun.dong@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: daniele.ceraolospurio@intel.com, Zhanjun Dong <zhanjun.dong@intel.com>
Subject: [PATCH v4 2/2] drm/xe/guc: Preserve HW error state in wedged mode 2
Date: Mon, 29 Jun 2026 10:08:36 -0400	[thread overview]
Message-ID: <20260629140836.2074349-3-zhanjun.dong@intel.com> (raw)
In-Reply-To: <20260629140836.2074349-1-zhanjun.dong@intel.com>

When HW reports an uncorrectable error, debugging the root cause may
require halting the GPU in the error state so scan dumps can be collected
and inspected.

Use wedged_mode=2 for this debug mode. In this mode, Xe already avoids GPU
reset on hangs, so also skip the engine reset cleanup path for GuC
uncorrectable error reports to keep the HW state intact.

Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 29ccabc4b7a4..05fa4e466461 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -3024,8 +3024,10 @@ int xe_guc_uncorrectable_error_handler(struct xe_guc *guc, u32 *msg, u32 len)
 
 	trace_xe_guc_uncorrectable_error(q);
 
-	/* Treat the same as engine reset */
-	xe_guc_exec_queue_reset_trigger_cleanup(q);
+	if (guc_to_xe(guc)->wedged.mode != XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET) {
+		/* Treat the same as engine reset */
+		xe_guc_exec_queue_reset_trigger_cleanup(q);
+	}
 
 	return 0;
 }
-- 
2.34.1


  parent reply	other threads:[~2026-06-29 14:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29 14:08 [PATCH v4 0/2] drm/xe/guc: Handle GuC local uncorrectable error notifications Zhanjun Dong
2026-06-29 14:08 ` [PATCH v4 1/2] " Zhanjun Dong
2026-06-29 14:08 ` Zhanjun Dong [this message]
2026-06-29 23:31   ` [PATCH v4 2/2] drm/xe/guc: Preserve HW error state in wedged mode 2 Daniele Ceraolo Spurio
2026-06-30 19:27     ` Dong, Zhanjun
2026-06-30  0:52 ` ✓ CI.KUnit: success for drm/xe/guc: Handle GuC local uncorrectable error notifications Patchwork
2026-06-30  1:36 ` ✓ Xe.CI.BAT: " Patchwork
2026-06-30 13:58 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260629140836.2074349-3-zhanjun.dong@intel.com \
    --to=zhanjun.dong@intel.com \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox