From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 769F9C4452B for ; Tue, 21 Jul 2026 23:48:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D37510E2FB; Tue, 21 Jul 2026 23:48:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="BXC/l7Sm"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8132810E2FB for ; Tue, 21 Jul 2026 23:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784677705; x=1816213705; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=KkcJD/UUM0R4n5jZI+ceq72yYVsd0KGuZZklSSA0f+0=; b=BXC/l7Sm6S8822ld9QG1GlSBj4EJpRMaCdO8gAw2XGabtbhC/eINLl5l yxyBTcUOWnDUcsFRXL4vPjkTc1Z7JBNj/8r005nafDUqvO7HvXRi1Jtcn qQWjJVIwgVtXjeBm6oPsCr/zYbeQHK4m2IJ0Whn3zaFT1d+T/aRAK5M53 aJlYX3r9V1+S71NsFhMVJlDO++2iXvrLNpp/GERTPz8oMVkp0WeeFKHtu XKgpp9bpSBIEGaBSuWIOwnW5t+Wu+OloeAajGRV2JOtzAEpe/mbJtr2mj HoEnhe9r0I1hMN4bvUpoAO5KR0x31GnKCVMTbDtcnJaffJtyilPb/JGSp g==; X-CSE-ConnectionGUID: kt6jLX9wTpyiioiwqwbDCA== X-CSE-MsgGUID: +WsiOX7OTbSUEsT2AaKGxw== X-IronPort-AV: E=McAfee;i="6800,10657,11853"; a="87832233" X-IronPort-AV: E=Sophos;i="6.25,177,1779174000"; d="scan'208";a="87832233" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2026 16:48:23 -0700 X-CSE-ConnectionGUID: oW+A8kmhT1e4Tm7lEd1b5A== X-CSE-MsgGUID: WcMf4cBNR+uveouKexLzSw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,177,1779174000"; d="scan'208";a="259882097" Received: from orsosgc001.jf.intel.com ([10.88.27.185]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2026 16:48:23 -0700 From: Umesh Nerlige Ramappa To: intel-xe@lists.freedesktop.org, Ashutosh Dixit Subject: [PATCH 1/3] drm/xe/xe_oa: Clear status only if relevant bits are set Date: Tue, 21 Jul 2026 16:48:19 -0700 Message-ID: <20260721234817.2473294-6-umesh.nerlige.ramappa@intel.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260721234817.2473294-5-umesh.nerlige.ramappa@intel.com> References: <20260721234817.2473294-5-umesh.nerlige.ramappa@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" OA monitors only a few bits in the status field. The current read-modify-write will write to the MMIO even if none of the relevant bits are set. Clear the status only if relevant bits are set. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/xe/xe_oa.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c index fa90441d3052..5afccda6abcd 100644 --- a/drivers/gpu/drm/xe/xe_oa.c +++ b/drivers/gpu/drm/xe/xe_oa.c @@ -524,14 +524,16 @@ static int __xe_oa_read(struct xe_oa_stream *stream, char __user *buf, size_t count, size_t *offset) { /* Only clear our bits to avoid side-effects */ - stream->oa_status = xe_mmio_rmw32(&stream->gt->mmio, __oa_regs(stream)->oa_status, - OASTATUS_RELEVANT_BITS, 0); + stream->oa_status = xe_mmio_read32(&stream->gt->mmio, __oa_regs(stream)->oa_status); /* * Signal to userspace that there is non-zero OA status to read via * @DRM_XE_OBSERVATION_IOCTL_STATUS observation stream fd ioctl */ - if (stream->oa_status & OASTATUS_RELEVANT_BITS) + if (stream->oa_status & OASTATUS_RELEVANT_BITS) { + xe_mmio_write32(&stream->gt->mmio, __oa_regs(stream)->oa_status, + stream->oa_status & ~OASTATUS_RELEVANT_BITS); return -EIO; + } return xe_oa_append_reports(stream, buf, count, offset); } -- 2.51.0