Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Gustavo Sousa <gustavo.sousa@intel.com>,
	Matt Roper <matthew.d.roper@intel.com>
Subject: [PATCH v3 1/2] drm/xe/mcr: Take vcs1/vecs1 into account for first media slice
Date: Mon, 27 Jul 2026 10:27:11 -0700	[thread overview]
Message-ID: <20260727172712.2877706-2-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20260727172712.2877706-1-ashutosh.dixit@intel.com>

vcs1 and vecs1 may also be present on the first media slice, so take
vcs1/vecs1 also into account when determining if the first media slice is
absent.

Bspec: 67103, 77977

Cc: Gustavo Sousa <gustavo.sousa@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
v2: Bug fix
v3: Fix for BMG (Matt Roper)
---
 drivers/gpu/drm/xe/xe_gt_mcr.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_gt_mcr.c b/drivers/gpu/drm/xe/xe_gt_mcr.c
index 9799ffadf85d2..8beb4006cd891 100644
--- a/drivers/gpu/drm/xe/xe_gt_mcr.c
+++ b/drivers/gpu/drm/xe/xe_gt_mcr.c
@@ -452,11 +452,15 @@ static void init_steering_dss(struct xe_gt *gt)
 
 static void init_steering_oaddrm(struct xe_gt *gt)
 {
+	u64 hwe_mask = XE_HW_ENGINE_VCS0 | XE_HW_ENGINE_VECS0;
+
+	if (MEDIA_VERx100(gt_to_xe(gt)) >= 3500)
+		hwe_mask |= XE_HW_ENGINE_VCS1 | XE_HW_ENGINE_VECS1;
 	/*
 	 * First instance is only terminated if the entire first media slice
-	 * is absent (i.e., no VCS0 or VECS0).
+	 * is absent (i.e., no engines in hwe_mask).
 	 */
-	if (gt->info.engine_mask & (XE_HW_ENGINE_VCS0 | XE_HW_ENGINE_VECS0))
+	if (gt->info.engine_mask & hwe_mask)
 		gt->steering[OADDRM].group_target = 0;
 	else
 		gt->steering[OADDRM].group_target = 1;
-- 
2.54.0


  reply	other threads:[~2026-07-27 17:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 17:27 [PATCH v3 0/2] drm/xe: Changes for Xe3p_HPM media Ashutosh Dixit
2026-07-27 17:27 ` Ashutosh Dixit [this message]
2026-07-28 20:57   ` [PATCH v3 1/2] drm/xe/mcr: Take vcs1/vecs1 into account for first media slice Matt Roper
2026-07-29 23:09     ` Dixit, Ashutosh
2026-07-27 17:27 ` [PATCH v3 2/2] drm/xe/oa: Extend OAM unit hwe assignment for new dGfx Ashutosh Dixit
2026-07-29 22:17   ` Umesh Nerlige Ramappa
2026-07-27 17:34 ` ✓ CI.KUnit: success for drm/xe: Changes for Xe3p_HPM media (rev3) Patchwork
2026-07-27 18:09 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-27 22:22 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260727172712.2877706-2-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=gustavo.sousa@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox