From: Arvind Yadav <arvind.yadav@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: rodrigo.vivi@intel.com, badal.nilawar@intel.com,
michal.wajdeczko@intel.com, himal.prasad.ghimiray@intel.com,
dnyaneshwar.bhadane@intel.com, mallesh.koujalagi@intel.com,
matthew.brost@intel.com
Subject: [PATCH v4 3/4] drm/xe/svm: Report terminal page-fault failures using SIGID
Date: Fri, 28 Aug 2026 15:28:02 +0530 [thread overview]
Message-ID: <20260828095803.2130312-4-arvind.yadav@intel.com> (raw)
In-Reply-To: <20260828095803.2130312-1-arvind.yadav@intel.com>
Route terminal SVM page-fault failures through the structured SIGID logging
helper.
These errors are reported only after the retry count is exceeded, so they
represent terminal page-fault handling failures rather than transient retry
conditions.
Use the PAGEFAULT component, which maps to XE_SIGID_MEM_FAULT, and pass the
real errno value to the helper. The helper renders the errno, so remove the
manual ERR_PTR() formatting from the message text.
Cc: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
Cc: Badal Nilawar <badal.nilawar@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Suggested-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
Signed-off-by: Arvind Yadav <arvind.yadav@intel.com>
---
drivers/gpu/drm/xe/xe_svm.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_svm.c b/drivers/gpu/drm/xe/xe_svm.c
index 627a741293d5..349e307ca092 100644
--- a/drivers/gpu/drm/xe/xe_svm.c
+++ b/drivers/gpu/drm/xe/xe_svm.c
@@ -13,6 +13,7 @@
#include "xe_bo.h"
#include "xe_exec_queue_types.h"
#include "xe_gt_stats.h"
+#include "xe_log.h"
#include "xe_migrate.h"
#include "xe_module.h"
#include "xe_pagefault.h"
@@ -1361,9 +1362,9 @@ static int __xe_svm_handle_pagefault(struct xe_vm *vm, struct xe_vma *vma,
else
goto retry;
} else {
- drm_err(&vm->xe->drm,
- "VRAM allocation failed, retry count exceeded, asid=%u, errno=%pe\n",
- vm->usm.asid, ERR_PTR(err));
+ xe_log_err(gt, PAGEFAULT, err,
+ "VRAM allocation failed, retry count exceeded, asid=%u\n",
+ vm->usm.asid);
goto err_out;
}
}
@@ -1384,9 +1385,9 @@ static int __xe_svm_handle_pagefault(struct xe_vm *vm, struct xe_vma *vma,
range_debug(range, "PAGE FAULT - RETRY PAGES");
goto retry;
} else {
- drm_err(&vm->xe->drm,
- "Get pages failed, retry count exceeded, asid=%u, gpusvm=%p, errno=%pe\n",
- vm->usm.asid, &vm->svm.gpusvm, ERR_PTR(err));
+ xe_log_err(gt, PAGEFAULT, err,
+ "Get pages failed, retry count exceeded, asid=%u, gpusvm=%p\n",
+ vm->usm.asid, &vm->svm.gpusvm);
}
}
if (err) {
--
2.43.0
next prev parent reply other threads:[~2026-08-28 9:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 9:57 [PATCH v4 0/4] drm/xe: Report GT TDR and VM rebind faults using SIGID Arvind Yadav
2026-08-28 9:58 ` [PATCH v4 1/4] drm/xe/guc: Report reset-request failure " Arvind Yadav
2026-08-28 10:28 ` Michal Wajdeczko
2026-08-31 6:11 ` Yadav, Arvind
2026-08-28 9:58 ` [PATCH v4 2/4] drm/xe/guc: Report CGP protocol errors " Arvind Yadav
2026-08-28 10:37 ` Michal Wajdeczko
2026-08-31 5:38 ` Yadav, Arvind
2026-08-28 9:58 ` Arvind Yadav [this message]
2026-08-28 9:58 ` [PATCH v4 4/4] drm/xe/gt: Report GT reset and power failures " Arvind Yadav
2026-08-28 14:18 ` Michal Wajdeczko
2026-08-31 5:10 ` Yadav, Arvind
2026-08-28 10:06 ` ✓ CI.KUnit: success for drm/xe: Report GT TDR and VM rebind faults using SIGID (rev4) Patchwork
2026-08-28 11:09 ` ✓ Xe.CI.BAT: " Patchwork
2026-08-28 11:48 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260828095803.2130312-4-arvind.yadav@intel.com \
--to=arvind.yadav@intel.com \
--cc=badal.nilawar@intel.com \
--cc=dnyaneshwar.bhadane@intel.com \
--cc=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=mallesh.koujalagi@intel.com \
--cc=matthew.brost@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox