Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arvind Yadav <arvind.yadav@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: rodrigo.vivi@intel.com, badal.nilawar@intel.com,
	michal.wajdeczko@intel.com, himal.prasad.ghimiray@intel.com,
	dnyaneshwar.bhadane@intel.com, mallesh.koujalagi@intel.com,
	matthew.brost@intel.com
Subject: [PATCH v6 4/4] drm/xe/gt: Report GT reset failure using SIGID
Date: Tue,  1 Sep 2026 12:00:59 +0530	[thread overview]
Message-ID: <20260901063059.2547247-5-arvind.yadav@intel.com> (raw)
In-Reply-To: <20260901063059.2547247-1-arvind.yadav@intel.com>

Route the GT reset failure log through the structured SIGID logging helper.

Failure to complete the full graphics reset means GT reset did not finish
as expected. Use the GT component, which maps to XE_SIGID_GT_TDR, and pass
the reset errno value to the helper.

Also update the message to describe the actual failure. The driver does not
clear GRDOM_FULL directly. the reset should complete and clear it within
the timeout.

Cc: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
Cc: Badal Nilawar <badal.nilawar@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Suggested-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
Signed-off-by: Arvind Yadav <arvind.yadav@intel.com>
---
v6:
 - Corrected the GT reset timeout in the log message to 5 ms.
   (sashiko)

v5:
 - Kept this patch limited to the GT reset failure path. (Michal)
 - Improved the GRDOM_FULL failure message to describe that full graphics
   reset did not complete. (Michal)

 drivers/gpu/drm/xe/xe_gt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
index 6805e0d3bf21..d72c7ec9a956 100644
--- a/drivers/gpu/drm/xe/xe_gt.c
+++ b/drivers/gpu/drm/xe/xe_gt.c
@@ -824,8 +824,8 @@ static int do_gt_reset(struct xe_gt *gt)
 	xe_mmio_write32(&gt->mmio, GDRST, GRDOM_FULL);
 	err = xe_mmio_wait32(&gt->mmio, GDRST, GRDOM_FULL, 0, 5000, NULL, false);
 	if (err)
-		xe_gt_err(gt, "failed to clear GRDOM_FULL (%pe)\n",
-			  ERR_PTR(err));
+		xe_log_err(gt, GT, err,
+			   "full graphics reset not completed in 5 ms\n");
 
 	xe_gsc_wa_14015076503(gt, false);
 
-- 
2.43.0


  parent reply	other threads:[~2026-09-01  6:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01  6:30 [PATCH v6 0/4] drm/xe: Report GT TDR and VM rebind faults using SIGID Arvind Yadav
2026-09-01  6:30 ` [PATCH v6 1/4] drm/xe/log: Add GUCSUBMIT component Arvind Yadav
2026-09-02 12:33   ` Michal Wajdeczko
2026-09-03  3:16     ` Yadav, Arvind
2026-09-01  6:30 ` [PATCH v6 2/4] drm/xe/guc: Report reset failure using SIGID Arvind Yadav
2026-09-02 12:36   ` Michal Wajdeczko
2026-09-01  6:30 ` [PATCH v6 3/4] drm/xe/svm: Report terminal page-fault failures " Arvind Yadav
2026-09-02 11:54   ` Mallesh, Koujalagi
2026-09-02 12:43   ` Michal Wajdeczko
2026-09-03  3:44     ` Yadav, Arvind
2026-09-01  6:30 ` Arvind Yadav [this message]
2026-09-02 11:45   ` [PATCH v6 4/4] drm/xe/gt: Report GT reset failure " Mallesh, Koujalagi
2026-09-02 12:51   ` Michal Wajdeczko
2026-09-03  4:32     ` Yadav, Arvind
2026-09-01  6:39 ` ✓ CI.KUnit: success for drm/xe: Report GT TDR and VM rebind faults using SIGID (rev6) Patchwork
2026-09-01  7:20 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-01  8:27 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260901063059.2547247-5-arvind.yadav@intel.com \
    --to=arvind.yadav@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=dnyaneshwar.bhadane@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=mallesh.koujalagi@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=michal.wajdeczko@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox