From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34C90C624D7 for ; Tue, 1 Sep 2026 19:28:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E99FF10EED1; Tue, 1 Sep 2026 19:28:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="gVeUEbVx"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6209610EEC7 for ; Tue, 1 Sep 2026 19:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788290882; x=1819826882; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=SyAVWT6KgAM5tXOdhYc/Z3jziTilyik4/niMBF+vMzA=; b=gVeUEbVxoqbx4iwfLVQ/rWpb02oI34iTK/m60IKn7a3CitU1cdQzvq4i wMs8NQO/CO+aH6PJms2aRd8v89lIGC8viWJJxiLSJacZIzbfZOV+AABv1 GVLyG9QtbCDVSQPU0OXJaljts7qbv3z4RNo6rFoE6XmtX2SLmSEQEinQB //fbbGcVr6u48aGVxUNkzAtN6OV5W0tlQHexN1T92W2Rvq6b3i2945KQh oyXbSs0iKd/OnUhCH2KHBDRIR8t/twvBooVhnsbRZblmzijQ7U9Fmu0ZU rxUcSnVMXsIAu+WktZ9L8bLAvXI+CMlwpbHlWuN3MYV0Z4N9lv3aIm3NK w==; X-CSE-ConnectionGUID: 5ufqyeaXQOCE9LFUCu2LFw== X-CSE-MsgGUID: w4eyrcGlTcqLBJ6WcBP9bw== X-IronPort-AV: E=McAfee;i="6800,10657,11893"; a="88762537" X-IronPort-AV: E=Sophos;i="6.25,256,1779174000"; d="scan'208";a="88762537" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2026 12:28:02 -0700 X-CSE-ConnectionGUID: suQOp32DQ0CyK0jBtQtu7g== X-CSE-MsgGUID: ZLy8cAfxSJWZQ0TNdEFMTA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,256,1779174000"; d="scan'208";a="269776786" Received: from mjruhl-vm.amr.corp.intel.com ([10.11.186.166]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2026 12:28:02 -0700 From: "Michael J. Ruhl" To: platform-driver-x86@vger.kernel.org, intel-xe@lists.freedesktop.org, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, matthew.brost@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, airlied@gmail.com, simona@ffwll.ch, david.e.box@linux.intel.com, anoop.c.vijay@intel.com, badal.nilawar@intel.com, matthew.d.roper@intel.com, james.ausmus@intel.com, karthik.poosa@intel.com Subject: [PATCH v4 13/18] drm/xe/vsec: Crescent Island PMT decode Date: Tue, 1 Sep 2026 12:27:48 -0700 Message-ID: <20260901192736.626777-33-michael.j.ruhl@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260901192736.626777-20-michael.j.ruhl@intel.com> References: <20260901192736.626777-20-michael.j.ruhl@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Crescent Island (CRI) has different index and offset values for accessing the PMT data area. Update the decode path to support the CRI device. Update the data read callback so to support the CRI usage. Signed-off-by: Michael J. Ruhl --- drivers/gpu/drm/xe/xe_vsec.c | 98 ++++++++++++++++++++++++++++++++---- 1 file changed, 89 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c index c109fc2d13b9..d95f4343c78d 100644 --- a/drivers/gpu/drm/xe/xe_vsec.c +++ b/drivers/gpu/drm/xe/xe_vsec.c @@ -109,19 +109,25 @@ static struct intel_vsec_platform_info xe_vsec_info[] = { /* * The GUID will have the following bits to decode: * [0:3] - {Telemetry space iteration number (0,1,..)} - * [4:7] - Segment (SEGMENT_INDEPENDENT-0, Client-1, Server-2) + * [4:7] - BMG Segment (SEGMENT_INDEPENDENT-0, Client-1, Server-2) + * [4:5] - CRI Segment (SEGMENT_INDEPENDENT-0, Client-1, Server-2) + * [6:7] - CRI Instance * [8:11] - SOC_SKU * [12:27] – Device ID – changes for each down bin SKU’s * [28:29] - Capability Type (Crashlog-0, Telemetry Aggregator-1, Watcher-2) * [30:31] - Record-ID (0-PUNIT, 1-OOBMSM_0, 2-OOBMSM_1) */ #define GUID_TELEM_ITERATION GENMASK(3, 0) -#define GUID_SEGMENT GENMASK(7, 4) #define GUID_SOC_SKU GENMASK(11, 8) #define GUID_DEVICE_ID GENMASK(27, 12) #define GUID_CAP_TYPE GENMASK(29, 28) #define GUID_RECORD_ID GENMASK(31, 30) +#define BMG_GUID_SEGMENT GENMASK(7, 4) + +#define CRI_GUID_SEGMENT GENMASK(5, 4) +#define CRI_GUID_INSTANCE GENMASK(7, 6) + #define BMG_IDX_TELEM_PUNIT 0x00 #define BMG_IDX_TELEM_OOBMSM 0x01 #define BMG_IDX_CRASHLOG_PUNIT 0x02 @@ -132,6 +138,18 @@ static struct intel_vsec_platform_info xe_vsec_info[] = { #define BMG_OOBMSM_0_WATCHER_OFFSET 0x18D8 #define BMG_OOBMSM_1_TELEMETRY_OFFSET 0x1000 +#define CRI_IDX_TELEM_DISCOVERY 0x00 +#define CRI_IDX_TELEM_PUNIT 0x01 +#define CRI_IDX_TELEM_OOBMSM 0x02 +#define CRI_IDX_CRASHLOG_PUNIT 0x03 +#define CRI_IDX_WATCHER_OOBMSM 0x03 /* PUNIT and OOBMSM share this index */ +#define CRI_IDX_CRASHLOG_OOBMSM 0x04 + +#define CRI_PUNIT_WATCHER_OFFSET 0x08A0 +#define CRI_OOBMSM_WATCHER_OFFSET 0x0CF8 +#define CRI_OOBMSM_GFSP_TELEMETRY_OFFSET 0x1600 +#define CRI_PUNIT_CRASHLOG_OFFSET 0x0E78 + enum record_id { PUNIT, OOBMSM_0, @@ -148,13 +166,6 @@ static int xe_guid_decode(u32 guid, int *index, u32 *offset) { u32 record_id = FIELD_GET(GUID_RECORD_ID, guid); u32 cap_type = FIELD_GET(GUID_CAP_TYPE, guid); - u32 device_id = FIELD_GET(GUID_DEVICE_ID, guid); - - if (device_id != BMG_DEVICE_ID) - return -ENODEV; - - if (cap_type > WATCHER) - return -EINVAL; *offset = 0; @@ -190,6 +201,75 @@ static int xe_guid_decode(u32 guid, int *index, u32 *offset) return 0; } +static int cri_guid_decode(u32 guid, int *index, u32 *offset) +{ + u32 record_id = FIELD_GET(GUID_RECORD_ID, guid); + u32 cap_type = FIELD_GET(GUID_CAP_TYPE, guid); + u32 instance = FIELD_GET(CRI_GUID_INSTANCE, guid); + + *offset = 0; + + if (cap_type == CRASHLOG) { + if (record_id == PUNIT) { + *index = CRI_IDX_CRASHLOG_PUNIT; + *offset = CRI_PUNIT_CRASHLOG_OFFSET; + } else { + *index = CRI_IDX_CRASHLOG_OOBMSM; + } + return 0; + } + + switch (record_id) { + case PUNIT: + *index = CRI_IDX_TELEM_PUNIT; + if (cap_type == WATCHER) + *offset = CRI_PUNIT_WATCHER_OFFSET; + break; + + case OOBMSM_0: + *index = CRI_IDX_TELEM_OOBMSM; + switch (instance) { + case 0: + if (cap_type == WATCHER) { + *index = CRI_IDX_WATCHER_OOBMSM; + *offset = CRI_OOBMSM_WATCHER_OFFSET; + } + break; + + case 1: + if (cap_type == TELEMETRY) + *offset = CRI_OOBMSM_GFSP_TELEMETRY_OFFSET; + break; + + default: + return -EINVAL; + } + break; + + default: + return -EINVAL; + } + + return 0; +} + +static int xe_guid_decode(u32 guid, int *index, u32 *offset) +{ + u32 cap_type = FIELD_GET(GUID_CAP_TYPE, guid); + u32 device_id = FIELD_GET(GUID_DEVICE_ID, guid); + + if (cap_type > WATCHER) + return -EINVAL; + + if (device_id == BMG_DEVICE_ID) + return bmg_guid_decode(guid, index, offset); + + if (device_id == CRI_DEVICE_ID) + return cri_guid_decode(guid, index, offset); + + return -ENODEV; +} + /* * xe_pmt_telem_read is a callback API. I.e this can be accessed external to * XE driver (PMT driver scope). Because of this, DRM hotplug needs to be -- 2.43.0