From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: alex.zuo@intel.com, jonathan.cavitt@intel.com,
michal.wajdeczko@intel.com, raag.jadav@intel.com,
andi.shyti@linux.intel.com, jani.nikula@intel.com
Subject: [PATCH v6 3/3] drm/xe/i2c: Use xe print functions in xe_i2c.c
Date: Thu, 3 Sep 2026 03:58:51 +0800 [thread overview]
Message-ID: <20260902195851.306669-4-jonathan.cavitt@intel.com> (raw)
In-Reply-To: <20260902195851.306669-1-jonathan.cavitt@intel.com>
Update xe_i2c.c to use the xe error reporting helper functions in
xe_printk.h instead of directly calling the associated drm print
functions from drm_print.h
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Reviewed-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/gpu/drm/xe/xe_i2c.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_i2c.c b/drivers/gpu/drm/xe/xe_i2c.c
index d8fa68206f418..af43a093ddf19 100644
--- a/drivers/gpu/drm/xe/xe_i2c.c
+++ b/drivers/gpu/drm/xe/xe_i2c.c
@@ -5,7 +5,6 @@
* Copyright (C) 2025 Intel Corporation.
*/
-#include <drm/drm_print.h>
#include <linux/array_size.h>
#include <linux/container_of.h>
#include <linux/delay.h>
@@ -32,6 +31,7 @@
#include "xe_device.h"
#include "xe_i2c.h"
#include "xe_mmio.h"
+#include "xe_printk.h"
#include "xe_sriov.h"
#include "xe_survivability_mode.h"
@@ -304,7 +304,7 @@ void xe_i2c_pm_suspend(struct xe_device *xe)
return;
xe_mmio_rmw32(mmio, I2C_CONFIG_PMCSR, PCI_PM_CTRL_STATE_MASK, (__force u32)PCI_D3hot);
- drm_dbg(&xe->drm, "pmcsr: 0x%08x\n", xe_mmio_read32(mmio, I2C_CONFIG_PMCSR));
+ xe_dbg(xe, "pmcsr: 0x%08x\n", xe_mmio_read32(mmio, I2C_CONFIG_PMCSR));
}
void xe_i2c_pm_resume(struct xe_device *xe, bool d3cold)
@@ -318,7 +318,7 @@ void xe_i2c_pm_resume(struct xe_device *xe, bool d3cold)
xe_mmio_rmw32(mmio, I2C_CONFIG_CMD, 0, PCI_COMMAND_MEMORY | PCI_COMMAND_MASTER);
xe_mmio_rmw32(mmio, I2C_CONFIG_PMCSR, PCI_PM_CTRL_STATE_MASK, (__force u32)PCI_D0);
- drm_dbg(&xe->drm, "pmcsr: 0x%08x\n", xe_mmio_read32(mmio, I2C_CONFIG_PMCSR));
+ xe_dbg(xe, "pmcsr: 0x%08x\n", xe_mmio_read32(mmio, I2C_CONFIG_PMCSR));
}
static void xe_i2c_remove(void *data)
--
2.53.0
next prev parent reply other threads:[~2026-09-02 19:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 19:58 [PATCH v6 0/3] drm/xe: Refactor I2C and HECI error messages Jonathan Cavitt
2026-09-02 19:58 ` [PATCH v6 1/3] drm/xe/printk: Add xe_warn_once() Jonathan Cavitt
2026-09-02 19:58 ` [PATCH v6 2/3] drm/xe/heci: Use xe print functions in xe_heci_gsc.c Jonathan Cavitt
2026-09-02 19:58 ` Jonathan Cavitt [this message]
2026-09-02 20:06 ` ✓ CI.KUnit: success for drm/xe: Refactor I2C and HECI error messages Patchwork
2026-09-02 21:02 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-03 11:32 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902195851.306669-4-jonathan.cavitt@intel.com \
--to=jonathan.cavitt@intel.com \
--cc=alex.zuo@intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox