From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0E91C79FAD for ; Tue, 8 Sep 2026 10:19:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 945F910EB05; Tue, 8 Sep 2026 10:19:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Ii9yeT3Y"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F38510EAFB for ; Tue, 8 Sep 2026 10:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788862737; x=1820398737; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=OAn088WBmB/VtDIIIw4c46CFP84ocU4cCBGh2JDD79A=; b=Ii9yeT3YVGjpTY1XH00EfjAGvbTi6ej4a3JJLVK3p8uhUB180BVbrMLt nVwt4cjzHpzxb152PFkd28BU5C1Gnx2KCxJJqNhCy7b8p8HFJ/h5Rj5t9 CoFiJf3kFF/iH/hG18LGB/yITY56JbMRdjaYiLI4alm6JzDQE0GvTwFYX USKpaBv5j8juaK8AMFhVCuitPTVNNVXqgBcs2azrhCcj3t3l/rBg1vVp5 sLjphlTwpV6oQ2yJekYqwlXBzm4mtVB9qpJPIOjsDF/+tWVfxg6b+ioSJ eVoy+HKZPwW0sFCS1tj8e8FCNIJlHg5EQ/AGUTg6lpeBms1vjMmT1rkS6 A==; X-CSE-ConnectionGUID: bG3wo7wZQbWJr6jTN4ZDVw== X-CSE-MsgGUID: aMx8fQQcTAq1MVtcqGSN7Q== X-IronPort-AV: E=McAfee;i="6800,10657,11899"; a="89278268" X-IronPort-AV: E=Sophos;i="6.25,268,1779174000"; d="scan'208";a="89278268" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2026 03:18:57 -0700 X-CSE-ConnectionGUID: 1yETr5bfR3aznzZSS6v3Ew== X-CSE-MsgGUID: 6PdmIa/DRmmm0062N4Hm3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,268,1779174000"; d="scan'208";a="269628427" Received: from dbhadane-mobl1.iind.intel.com ([10.190.239.58]) by orviesa010.jf.intel.com with ESMTP; 08 Sep 2026 03:18:56 -0700 From: Dnyaneshwar Bhadane To: intel-xe@lists.freedesktop.org Cc: mallesh.koujalagi@intel.com, Dnyaneshwar Bhadane Subject: [PATCH v2 03/13] drm/xe/hwmon: Report errors using structured xe_log API Date: Tue, 8 Sep 2026 15:48:39 +0530 Message-ID: <20260908101849.1219614-4-dnyaneshwar.bhadane@intel.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260908101849.1219614-1-dnyaneshwar.bhadane@intel.com> References: <20260908101849.1219614-1-dnyaneshwar.bhadane@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Replace drm_err() calls with xe_log_err() using the HWMON component tag to enable structured error reporting with SIGID for hardware monitor failures: Signed-off-by: Dnyaneshwar Bhadane --- drivers/gpu/drm/xe/xe_hwmon.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c index 5284cab6703d..0f87bd517164 100644 --- a/drivers/gpu/drm/xe/xe_hwmon.c +++ b/drivers/gpu/drm/xe/xe_hwmon.c @@ -15,6 +15,7 @@ #include "regs/xe_pcode_regs.h" #include "xe_device.h" #include "xe_hwmon.h" +#include "xe_log.h" #include "xe_mmio.h" #include "xe_pcode.h" #include "xe_pcode_api.h" @@ -563,9 +564,9 @@ xe_hwmon_power_max_interval_show(struct device *dev, struct device_attribute *at if (hwmon->xe->info.has_mbx_power_limits) { ret = xe_hwmon_pcode_read_power_limit(hwmon, power_attr, channel, ®_val); if (ret) { - drm_err(&hwmon->xe->drm, - "power interval read fail, ch %d, attr %d, val 0x%08x, ret %d\n", - channel, power_attr, reg_val, ret); + xe_log_err(hwmon->xe, HWMON, ret, + "power interval read fail, ch %d, attr %d, val 0x%08x\n", + channel, power_attr, reg_val); reg_val = 0; } } else { @@ -1599,7 +1600,8 @@ int xe_hwmon_register(struct xe_device *xe) &hwmon_chip_info, hwmon_groups); if (IS_ERR(hwmon->hwmon_dev)) { - drm_err(&xe->drm, "Failed to register xe hwmon (%pe)\n", hwmon->hwmon_dev); + xe_log_err(xe, HWMON, PTR_ERR(hwmon->hwmon_dev), + "Failed to register xe hwmon\n"); xe->hwmon = NULL; return PTR_ERR(hwmon->hwmon_dev); } -- 2.54.0