From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35F54C79FAE for ; Tue, 8 Sep 2026 10:19:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC86410EB07; Tue, 8 Sep 2026 10:19:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="HAop6D0r"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id D22AC10EB05 for ; Tue, 8 Sep 2026 10:18:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788862739; x=1820398739; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=uG2/9wCPyn8+LVsrJSGGfVPbOMN47v/7mr6YE84WmZo=; b=HAop6D0rES5BqBZPC7z4CH3Eguo5hr3TELJksYfhT/8/KhQzoEwvuPme 5ne1BCxpQruEndZHaljRHFEEW4dn+hq7Z9Ph2oQosh4e/bzSrDUdPiMEe jrC7wHjQ0T7RV/+hsknEa/nuYKyZ6BA8k7GTQd5PFbiPSeX9yjsZnhDjV XfV8hbpMkSZBT33uF1VzAtiYftV/Gs8F7iZO2k/imY6Ge3N74/2ImGjyX 3AhCe3+knArVAL+UaTQEZwlXuxsmhUfNWumMKJzeN9AP0MwzJwCc4kyuY kdGVMM2q08TVcyFNYoAoHJ4T1xbcWGUEXBqM7vLZ4ZqMvS4YM7NEbFThx Q==; X-CSE-ConnectionGUID: fupcB6CzSEWKaIKqWUinog== X-CSE-MsgGUID: UBSsehCtRc6ZyFGYxmp0Fw== X-IronPort-AV: E=McAfee;i="6800,10657,11899"; a="89278273" X-IronPort-AV: E=Sophos;i="6.25,268,1779174000"; d="scan'208";a="89278273" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2026 03:18:59 -0700 X-CSE-ConnectionGUID: NKvw9v6ET7OMzivVp1vKDA== X-CSE-MsgGUID: 6/oqkGfOSwKWJK8yB1v4Dw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,268,1779174000"; d="scan'208";a="269628442" Received: from dbhadane-mobl1.iind.intel.com ([10.190.239.58]) by orviesa010.jf.intel.com with ESMTP; 08 Sep 2026 03:18:59 -0700 From: Dnyaneshwar Bhadane To: intel-xe@lists.freedesktop.org Cc: mallesh.koujalagi@intel.com, Dnyaneshwar Bhadane Subject: [PATCH v2 05/13] drm/xe/memirq: Report errors using structured xe_log API Date: Tue, 8 Sep 2026 15:48:41 +0530 Message-ID: <20260908101849.1219614-6-dnyaneshwar.bhadane@intel.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260908101849.1219614-1-dnyaneshwar.bhadane@intel.com> References: <20260908101849.1219614-1-dnyaneshwar.bhadane@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Replace memirq_err() calls with xe_log_err() using the MEMIRQ component tag for memory-based IRQ failures v2: - No need to log ERR_PTR(err) explicitly (Mallesh) - Using tile instead of xe for more local log location(sashiko bot) Signed-off-by: Dnyaneshwar Bhadane --- drivers/gpu/drm/xe/xe_memirq.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_memirq.c b/drivers/gpu/drm/xe/xe_memirq.c index 9dfe965cb46e..32b9f87a10ec 100644 --- a/drivers/gpu/drm/xe/xe_memirq.c +++ b/drivers/gpu/drm/xe/xe_memirq.c @@ -15,6 +15,7 @@ #include "xe_gt.h" #include "xe_guc.h" #include "xe_hw_engine.h" +#include "xe_log.h" #include "xe_memirq.h" #include "xe_tile_printk.h" @@ -232,7 +233,7 @@ static int memirq_alloc_pages(struct xe_memirq *memirq) return 0; out: - memirq_err(memirq, "Failed to allocate memirq page (%pe)\n", ERR_PTR(err)); + xe_log_err(tile, MEMIRQ, err, "Failed to allocate memirq page\n"); return err; } @@ -370,8 +371,8 @@ int xe_memirq_init_guc(struct xe_memirq *memirq, struct xe_guc *guc) return 0; failed: - memirq_err(memirq, "Failed to setup report pages in %s (%pe)\n", - guc_name(guc), ERR_PTR(err)); + xe_log_err(memirq_to_tile(memirq), MEMIRQ, err, + "Failed to setup report pages in %s\n", guc_name(guc)); return err; } -- 2.54.0