Re: [PATCH v5 4/4] drm/xe/ggtt: Add KUnit tests for usable and shareable pools

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Test assertion aborts cause memory leaks and DRM MM teardown warnings in KUnit tests.
--

commit 0482b39a261e5a5e9244a46c2fbb33074c936fb0
Author: Piotr Piórkowski <piotr.piorkowski@intel.com>

    drm/xe/ggtt: Add KUnit tests for usable and shareable pools
    
    Add GGTT KUnit tests focused on the newly introduced usable and
    shareable pools.

> diff --git a/drivers/gpu/drm/xe/tests/xe_ggtt_kunit.c b/drivers/gpu/drm/xe/tests/xe_ggtt_kunit.c
> new file mode 100644
> index 0000000000000..9bac48982a81b
> --- /dev/null
> +++ b/drivers/gpu/drm/xe/tests/xe_ggtt_kunit.c
[ ... ]
> +static void alloc_usable_pool_oversized(struct kunit *test)
> +{
[ ... ]
> +	node = xe_ggtt_insert_node(ggtt, usable + XE_PAGE_SIZE, XE_PAGE_SIZE);
> +	KUNIT_ASSERT_TRUE(test, IS_ERR(node));

[Severity: Medium]
If the allocation unexpectedly succeeds in alloc_usable_pool_oversized(),
this assertion will fail and abort the test. Will the allocated node be leaked
and cause a warning from drm_mm_takedown() since it remains in the memory
manager?

[ ... ]
> +static void alloc_partial_overlap(struct kunit *test)
> +{
[ ... ]
> +	usable_node = xe_ggtt_insert_node(ggtt, XE_PAGE_SIZE, XE_PAGE_SIZE);
> +	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, usable_node);
> +	shareable_node = xe_ggtt_insert_node_shareable(ggtt, XE_PAGE_SIZE, XE_PAGE_SIZE);
> +	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, shareable_node);

[Severity: Medium]
If the allocation for shareable_node fails in alloc_partial_overlap(),
the assertion will abort the test. Does this leave usable_node in the memory
manager, leaking it and triggering a warning during DRM MM teardown?

[ ... ]
> +static void alloc_partial_overlap_usable_full(struct kunit *test)
> +{
[ ... ]
> +	usable_node = xe_ggtt_insert_node(ggtt, usable, XE_PAGE_SIZE);
> +	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, usable_node);
> +	shareable_node = xe_ggtt_insert_node_shareable(ggtt, shareable, XE_PAGE_SIZE);
> +	KUNIT_ASSERT_TRUE(test, IS_ERR(shareable_node));

[Severity: Medium]
If the shareable_node allocation unexpectedly succeeds here in
alloc_partial_overlap_usable_full(), the assertion will abort the test.
Could this cause usable_node to be leaked and trigger a drm_mm_takedown()
warning?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908100602.1626556-1-piotr.piorkowski@intel.com?part=4