Re: [PATCH 2/3] drm/xe/xe_oa: Avoid checking and setting fields in the OA report

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `oa_report_header_64bit` macro is left as dead code after all of its usages are removed.
--

commit 5d5bed5887d7f8c23553a4f7f71318408e15027b
Author: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

drm/xe/xe_oa: Avoid checking and setting fields in the OA report

This commit removes the workaround of checking and clearing OA report fields
to verify if reports have fully landed in memory. It drops helpers like
oa_report_id() and oa_timestamp() since reports may land out of order.

> diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
> index 2353a8c0e6c11..08d6e94f5fcee 100644
> --- a/drivers/gpu/drm/xe/xe_oa.c
> +++ b/drivers/gpu/drm/xe/xe_oa.c
> @@ -216,42 +216,6 @@ static u32 xe_oa_hw_tail_read(struct xe_oa_stream *stream)
>  #define oa_report_header_64bit(__s) \
>  	((__s)->oa_buffer.format->header == HDR_64_BIT)
>  

[Severity: Low]
Since all callers of oa_report_header_64bit() (such as oa_report_id() and
oa_timestamp()) are removed in this patch, should the macro definition
itself be removed as well to avoid leaving unused code behind?

> -static u64 oa_report_id(struct xe_oa_stream *stream, u32 report_offset)
> -{
> -	struct iosys_map *map = &stream->oa_buffer.bo->vmap;
> -

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908222356.1210175-5-umesh.nerlige.ramappa@intel.com?part=2